Skip to content

A platform for community discussion. Free, open, simple.

UX: post reply count position change (#39606)

David Battersbye3ba94fc06aa
diff --git a/plugins/discourse-reactions/assets/javascripts/discourse/components/discourse-reactions-actions-summary.gjs b/plugins/discourse-reactions/assets/javascripts/discourse/components/discourse-reactions-actions-summary.gjs
index 624fa818b94..8be86c7bc1e 100644
--- a/plugins/discourse-reactions/assets/javascripts/discourse/components/discourse-reactions-actions-summary.gjs
+++ b/plugins/discourse-reactions/assets/javascripts/discourse/components/discourse-reactions-actions-summary.gjs
@@ -33,7 +33,7 @@ export default class ReactionsActionSummary extends Component {
<template>
{{#if @shouldRender}}
- <div>
+ <div class="reactions-actions-summary">
<DiscourseReactionsActions @post={{@post}} @position="left" />
</div>
{{/if}}
diff --git a/plugins/discourse-reactions/assets/javascripts/discourse/initializers/discourse-reactions.gjs b/plugins/discourse-reactions/assets/javascripts/discourse/initializers/discourse-reactions.gjs
index 7595b81286f..6339ee04d31 100644
--- a/plugins/discourse-reactions/assets/javascripts/discourse/initializers/discourse-reactions.gjs
+++ b/plugins/discourse-reactions/assets/javascripts/discourse/initializers/discourse-reactions.gjs
@@ -12,8 +12,8 @@ import ReactionsActionSummary from "../components/discourse-reactions-actions-su
replaceIcon("notification.reaction", "bell");
-function initializeDiscourseReactions(api) {
- customizePostMenu(api);
+function initializeDiscourseReactions(api, siteSettings) {
+ customizePostMenu(api, siteSettings);
api.addKeyboardShortcut("l", null, {
click: ".topic-post.selected .discourse-reactions-reaction-button",
@@ -157,14 +157,18 @@ function initializeDiscourseReactions(api) {
}
}
-function customizePostMenu(api) {
+function customizePostMenu(api, siteSettings) {
api.registerValueTransformer(
"post-menu-buttons",
({ value: dag, context: { buttonKeys } }) => {
dag.replace(buttonKeys.LIKE, ReactionsActionButton);
- dag.add("discourse-reactions-actions", ReactionsActionSummary, {
- after: buttonKeys.REPLIES,
- });
+ dag.add(
+ "discourse-reactions-actions",
+ ReactionsActionSummary,
+ siteSettings.enable_new_post_reply_count_position
+ ? { before: buttonKeys.REPLIES }
+ : { after: buttonKeys.REPLIES }
+ );
}
);
}
@@ -176,7 +180,7 @@ export default {
const siteSettings = container.lookup("service:site-settings");
if (siteSettings.discourse_reactions_enabled) {
- withPluginApi(initializeDiscourseReactions);
+ withPluginApi((api) => initializeDiscourseReactions(api, siteSettings));
}
},
diff --git a/plugins/discourse-reactions/assets/stylesheets/common/discourse-reactions.scss b/plugins/discourse-reactions/assets/stylesheets/common/discourse-reactions.scss
index fd4e2502897..05df245ce07 100644
--- a/plugins/discourse-reactions/assets/stylesheets/common/discourse-reactions.scss
+++ b/plugins/discourse-reactions/assets/stylesheets/common/discourse-reactions.scss
@@ -463,6 +463,11 @@ html.discourse-reactions-no-select {
}
}
+.reactions-actions-summary + .show-replies {
+ margin-right: 0;
+ margin-left: var(--space-2);
+}
+
.discourse-reactions-counter {
display: flex;
align-items: center;
diff --git a/plugins/discourse-reactions/config/locales/server.en.yml b/plugins/discourse-reactions/config/locales/server.en.yml
index d5bd9ab930d..8cefdf9d4a0 100644
--- a/plugins/discourse-reactions/config/locales/server.en.yml
+++ b/plugins/discourse-reactions/config/locales/server.en.yml
@@ -3,6 +3,7 @@ en:
discourse_reactions_like_icon: "Defines the icon used for the main reaction button. This should be a <a href='https://fontawesome.com/v6/search?o=r&m=free' target='_blank'>Font Awesome</a> icon name, not an emoji name."
discourse_reactions_reaction_for_like: "Defines the reaction associated to the Like action. Historical Like records will not be changed if this setting changes, it is <strong>strongly recommended</strong> that this setting is never changed."
discourse_reactions_enabled: "Enable the discourse-reactions plugin."
+ enable_new_post_reply_count_position: "Move the post reactions summary before the reply count in the post controls."
discourse_reactions_enabled_reactions: "Defines a list of enabled reactions, any emoji is allowed here."
discourse_reactions_desaturated_reaction_panel: "Reduces visual noise of reactions by displaying them desaturated until hover."
discourse_reactions_excluded_from_like: "Reactions that do not count as a Like. Any reactions that are not on this list will count as a Like for badges, reporting, and other purposes."
diff --git a/plugins/discourse-reactions/config/settings.yml b/plugins/discourse-reactions/config/settings.yml
index 9f4ad957e8d..0cc7e39d81d 100644
--- a/plugins/discourse-reactions/config/settings.yml
+++ b/plugins/discourse-reactions/config/settings.yml
@@ -31,3 +31,11 @@ discourse_reactions:
default: false
client: true
area: "emojis"
+ enable_new_post_reply_count_position:
+ default: false
+ client: true
+ hidden: true
+ area: "experimental"
+ upcoming_change:
+ status: "beta"
+ impact: "feature,all_members"
diff --git a/plugins/discourse-reactions/public/images/upcoming_changes/enable_new_post_reply_count_position.png b/plugins/discourse-reactions/public/images/upcoming_changes/enable_new_post_reply_count_position.png
new file mode 100644
index 00000000000..03b447859f9
Binary files /dev/null and b/plugins/discourse-reactions/public/images/upcoming_changes/enable_new_post_reply_count_position.png differ