A platform for community discussion. Free, open, simple.
PERF: Add covering indexes for browser pageview rollups (#43939)
Krzysztof Kotlareke50f90db94ae
diff --git a/app/models/browser_pageview_event.rb b/app/models/browser_pageview_event.rbindex 8e8e3dfd6f8..12a39e7d6af 100644--- a/app/models/browser_pageview_event.rb+++ b/app/models/browser_pageview_event.rb@@ -276,6 +276,7 @@ end## idx_bpe_beacon_created_at_id (created_at,id) WHERE (source = 2)# idx_bpe_browser_backfill (created_at,id) WHERE (browser IS NULL)+# idx_bpe_crawler_created_at_covering (created_at) WHERE (score > 55)# idx_bpe_created_at_country_code (created_at,country_code)# idx_bpe_created_at_id (created_at,id)# idx_bpe_created_at_normalized_referrer (created_at,normalized_referrer)@@ -283,6 +284,7 @@ end# idx_bpe_ip_ua_created_at (ip_address,user_agent,created_at)# idx_bpe_referrer_backfill (created_at,id) WHERE ((referrer IS NOT NULL) AND ((normalized_referrer_version IS NULL) OR (normalized_referrer_version < 1)))# idx_bpe_session_created_at (session_id,created_at)+# idx_bpe_session_created_at_covering (session_id,created_at)# idx_bpe_url_backfill (created_at,id) WHERE ((normalized_url_version IS NULL) OR (normalized_url_version < 1))# index_browser_pageview_events_on_created_at (created_at) USING brin# index_browser_pageview_events_on_topic_id (topic_id)diff --git a/db/migrate/20260921074918_add_covering_index_to_browser_pageview_events.rb b/db/migrate/20260921074918_add_covering_index_to_browser_pageview_events.rbnew file mode 100644index 00000000000..51c1d977d2c--- /dev/null+++ b/db/migrate/20260921074918_add_covering_index_to_browser_pageview_events.rb@@ -0,0 +1,34 @@+# frozen_string_literal: true+class AddCoveringIndexToBrowserPageviewEvents < ActiveRecord::Migration[8.0]+ disable_ddl_transaction!++ def up+ if index_exists?(+ :browser_pageview_events,+ %i[session_id created_at],+ name: "idx_bpe_session_created_at_covering",+ include: %i[user_id score],+ valid: true,+ )+ return+ end++ remove_index :browser_pageview_events,+ name: "idx_bpe_session_created_at_covering",+ algorithm: :concurrently,+ if_exists: true++ add_index :browser_pageview_events,+ %i[session_id created_at],+ name: "idx_bpe_session_created_at_covering",+ include: %i[user_id score],+ algorithm: :concurrently+ end++ def down+ remove_index :browser_pageview_events,+ name: "idx_bpe_session_created_at_covering",+ algorithm: :concurrently,+ if_exists: true+ end+enddiff --git a/db/migrate/20260921081150_add_crawler_covering_index_to_browser_pageview_events.rb b/db/migrate/20260921081150_add_crawler_covering_index_to_browser_pageview_events.rbnew file mode 100644index 00000000000..663483685b4--- /dev/null+++ b/db/migrate/20260921081150_add_crawler_covering_index_to_browser_pageview_events.rb@@ -0,0 +1,35 @@+# frozen_string_literal: true+class AddCrawlerCoveringIndexToBrowserPageviewEvents < ActiveRecord::Migration[8.0]+ disable_ddl_transaction!++ def up+ if index_exists?(+ :browser_pageview_events,+ :created_at,+ name: "idx_bpe_crawler_created_at_covering",+ include: %i[topic_id user_id ip_address],+ valid: true,+ )+ return+ end++ remove_index :browser_pageview_events,+ name: "idx_bpe_crawler_created_at_covering",+ algorithm: :concurrently,+ if_exists: true++ add_index :browser_pageview_events,+ :created_at,+ name: "idx_bpe_crawler_created_at_covering",+ include: %i[topic_id user_id ip_address],+ where: "score > 55",+ algorithm: :concurrently+ end++ def down+ remove_index :browser_pageview_events,+ name: "idx_bpe_crawler_created_at_covering",+ algorithm: :concurrently,+ if_exists: true+ end+enddiff --git a/db/structure.sql b/db/structure.sqlindex a1d11cbbf98..9f754a39397 100644--- a/db/structure.sql+++ b/db/structure.sql@@ -19221,6 +19221,13 @@ CREATE INDEX idx_bpe_beacon_created_at_id ON public.browser_pageview_events USINCREATE INDEX idx_bpe_browser_backfill ON public.browser_pageview_events USING btree (created_at DESC, id DESC) WHERE (browser IS NULL);+--+-- Name: idx_bpe_crawler_created_at_covering; Type: INDEX; Schema: public; Owner: -+--++CREATE INDEX idx_bpe_crawler_created_at_covering ON public.browser_pageview_events USING btree (created_at) INCLUDE (topic_id, user_id, ip_address) WHERE (score > 55);++---- Name: idx_bpe_created_at_country_code; Type: INDEX; Schema: public; Owner: ---@@ -19270,6 +19277,13 @@ CREATE INDEX idx_bpe_referrer_backfill ON public.browser_pageview_events USING bCREATE INDEX idx_bpe_session_created_at ON public.browser_pageview_events USING btree (session_id, created_at);+--+-- Name: idx_bpe_session_created_at_covering; Type: INDEX; Schema: public; Owner: -+--++CREATE INDEX idx_bpe_session_created_at_covering ON public.browser_pageview_events USING btree (session_id, created_at) INCLUDE (user_id, score);++---- Name: idx_bpe_url_backfill; Type: INDEX; Schema: public; Owner: ---@@ -25391,6 +25405,8 @@ ALTER TABLE ONLY public.ad_plugin_house_ads_groupsSET search_path TO "$user", public;INSERT INTO "schema_migrations" (version) VALUES+('20260921081150'),+('20260921074918'),('20260921015711'),('20260918061735'),('20260915204557'),