A platform for community discussion. Free, open, simple.
PERF: Avoid full table scans in browser pageview engagement rollup (#43662)
Keegan Georgeea27126c2f42
diff --git a/app/models/browser_pageview_event.rb b/app/models/browser_pageview_event.rbindex 887bc0c0023..377291b5f13 100644--- a/app/models/browser_pageview_event.rb+++ b/app/models/browser_pageview_event.rb@@ -320,6 +320,7 @@ end# idx_bpe_browser_backfill (source,created_at DESC,id DESC) WHERE (browser IS NULL)# idx_bpe_created_at_country_code (created_at,country_code)# idx_bpe_created_at_normalized_referrer (created_at,normalized_referrer)+# idx_bpe_created_at_session_id (created_at,session_id,source)# idx_bpe_ip_ua_created_at (ip_address,user_agent,created_at)# idx_bpe_referrer_backfill (created_at,id) WHERE ((referrer IS NOT NULL) AND ((normalized_referrer_version IS NULL) OR (normalized_referrer_version < 1)))# idx_bpe_session_created_at (session_id,created_at)diff --git a/app/models/browser_pageview_session_engagement_daily_rollup.rb b/app/models/browser_pageview_session_engagement_daily_rollup.rbindex c4b2bf49406..cd2df7fe92a 100644--- a/app/models/browser_pageview_session_engagement_daily_rollup.rb+++ b/app/models/browser_pageview_session_engagement_daily_rollup.rb@@ -37,17 +37,21 @@ class BrowserPageviewSessionEngagementDailyRollup < ActiveRecord::BaseAND #{source_condition}),session_pageviews AS (- SELECT- bpe.session_id,- MIN(bpe.created_at)::date AS date,- COUNT(*) AS pageview_count,- bool_or(bpe.user_id IS NOT NULL) AS logged_in,- bool_or(#{CrawlerScorer.likely_crawler_condition(table: "bpe")}) AS likely_crawler- FROM browser_pageview_events bpe- JOIN active_sessions ON active_sessions.session_id = bpe.session_id- WHERE #{BrowserPageviewEvent.rollup_source_condition(table: "bpe")}- GROUP BY bpe.session_id- HAVING MIN(bpe.created_at) >= :start_date+ SELECT sp.*+ FROM active_sessions+ CROSS JOIN LATERAL (+ SELECT+ bpe.session_id,+ MIN(bpe.created_at)::date AS date,+ COUNT(*) AS pageview_count,+ bool_or(bpe.user_id IS NOT NULL) AS logged_in,+ bool_or(#{CrawlerScorer.likely_crawler_condition(table: "bpe")}) AS likely_crawler+ FROM browser_pageview_events bpe+ WHERE bpe.session_id = active_sessions.session_id+ AND #{BrowserPageviewEvent.rollup_source_condition(table: "bpe")}+ GROUP BY bpe.session_id+ HAVING MIN(bpe.created_at) >= :start_date+ ) sp)INSERT INTO browser_pageview_session_engagement_daily_rollups(diff --git a/db/migrate/20260914213908_add_created_at_session_id_index_to_browser_pageview_events.rb b/db/migrate/20260914213908_add_created_at_session_id_index_to_browser_pageview_events.rbnew file mode 100644index 00000000000..e1cdb6ba755--- /dev/null+++ b/db/migrate/20260914213908_add_created_at_session_id_index_to_browser_pageview_events.rb@@ -0,0 +1,25 @@+# frozen_string_literal: true++class AddCreatedAtSessionIdIndexToBrowserPageviewEvents < ActiveRecord::Migration[8.0]+ disable_ddl_transaction!++ INDEX_NAME = "idx_bpe_created_at_session_id"++ def up+ remove_index :browser_pageview_events,+ name: INDEX_NAME,+ algorithm: :concurrently,+ if_exists: true+ add_index :browser_pageview_events,+ %i[created_at session_id source],+ name: INDEX_NAME,+ algorithm: :concurrently+ end++ def down+ remove_index :browser_pageview_events,+ name: INDEX_NAME,+ algorithm: :concurrently,+ if_exists: true+ end+enddiff --git a/db/structure.sql b/db/structure.sqlindex da91789f75b..1e72f1d5972 100644--- a/db/structure.sql+++ b/db/structure.sql@@ -19003,6 +19003,13 @@ CREATE INDEX idx_bpe_created_at_country_code ON public.browser_pageview_events UCREATE INDEX idx_bpe_created_at_normalized_referrer ON public.browser_pageview_events USING btree (created_at, normalized_referrer);+--+-- Name: idx_bpe_created_at_session_id; Type: INDEX; Schema: public; Owner: -+--++CREATE INDEX idx_bpe_created_at_session_id ON public.browser_pageview_events USING btree (created_at, session_id, source);++---- Name: idx_bpe_ip_ua_created_at; Type: INDEX; Schema: public; Owner: ---@@ -25073,6 +25080,7 @@ ALTER TABLE ONLY public.ad_plugin_house_ads_groupsSET search_path TO "$user", public;INSERT INTO "schema_migrations" (version) VALUES+('20260914213908'),('20260914172801'),('20260914172757'),('20260910033302'),