Skip to content

A platform for community discussion. Free, open, simple.

DEV: Ensure non-existent site setting dependency does not crash (#39068)

Natalie Tayeb83b41e37bd
diff --git a/lib/site_setting_extension.rb b/lib/site_setting_extension.rb
index c801a84eefc..510fb6b6885 100644
--- a/lib/site_setting_extension.rb
+++ b/lib/site_setting_extension.rb
@@ -372,7 +372,7 @@ module SiteSettingExtension
# change settings use their resolved value (promotion status, admin override, etc.).
is_hidden =
!type_supervisor.dependencies[setting_name].all? do |dependency|
- public_send(dependency)
+ respond_to?(dependency) && public_send(dependency)
end
end
diff --git a/spec/lib/site_setting_extension_spec.rb b/spec/lib/site_setting_extension_spec.rb
index 3097faa798b..5afeb29fb57 100644
--- a/spec/lib/site_setting_extension_spec.rb
+++ b/spec/lib/site_setting_extension_spec.rb
@@ -757,6 +757,22 @@ RSpec.describe SiteSettingExtension do
end
end
+ context "when the depends_on setting does not exist" do
+ before do
+ settings.setting(
+ :orphan_setting,
+ nil,
+ depends_on: [:nonexistent_setting],
+ depends_behavior: :hidden,
+ )
+ settings.refresh!
+ end
+
+ it "is not present in all_settings" do
+ expect(settings.all_settings.find { |s| s[:setting] == :orphan_setting }).to be_blank
+ end
+ end
+
context "when the setting is also explicitly hidden" do
before do
settings.setting(:enable_cool_thing, true)