Skip to content

A platform for community discussion. Free, open, simple.

UX: Open bulk manage tags replace tag choosers above field on mobile (#39632) (#40513)

Alan Guo Xiang Tanedf13ea1cec9
diff --git a/app/assets/stylesheets/common/select-kit/select-kit.scss b/app/assets/stylesheets/common/select-kit/select-kit.scss
index 702e5d00a19..33daa0ca965 100644
--- a/app/assets/stylesheets/common/select-kit/select-kit.scss
+++ b/app/assets/stylesheets/common/select-kit/select-kit.scss
@@ -31,6 +31,17 @@
pointer-events: none;
}
+ &.is-placed-above.is-expanded {
+ .select-kit-body {
+ flex-direction: column-reverse;
+ }
+
+ .select-kit-collection {
+ display: flex;
+ flex-direction: column-reverse;
+ }
+ }
+
&.is-expanded {
z-index: z("dropdown");
diff --git a/frontend/discourse/app/components/modal/bulk-topic-actions/manage-tags-form.gjs b/frontend/discourse/app/components/modal/bulk-topic-actions/manage-tags-form.gjs
index ac8f4bc51b3..1d3ff84a6e8 100644
--- a/frontend/discourse/app/components/modal/bulk-topic-actions/manage-tags-form.gjs
+++ b/frontend/discourse/app/components/modal/bulk-topic-actions/manage-tags-form.gjs
@@ -3,6 +3,7 @@ import { array, fn, hash } from "@ember/helper";
import { action } from "@ember/object";
import { trustHTML } from "@ember/template";
import Form from "discourse/components/form";
+import { bind } from "discourse/lib/decorators";
import dIcon from "discourse/ui-kit/helpers/d-icon";
import { i18n } from "discourse-i18n";
@@ -44,6 +45,15 @@ export default class ManageTagsForm extends Component {
return tags?.length ? tags : undefined;
}
+ @bind
+ mobilePlacementForReplaceRowTagChooser(rows, index) {
+ const rowsBelow = rows.length - 1 - index;
+ if (rowsBelow < 3) {
+ return "top";
+ }
+ return null;
+ }
+
@action
removeReplaceRow(collection, index) {
collection.remove(index);
@@ -228,6 +238,10 @@ export default class ManageTagsForm extends Component {
index
"to"
}}
+ @mobilePlacement={{this.mobilePlacementForReplaceRowTagChooser
+ transientData.replace_rows
+ index
+ }}
/>
</collection.Field>
</row.Col>
@@ -257,6 +271,10 @@ export default class ManageTagsForm extends Component {
index
"from"
}}
+ @mobilePlacement={{this.mobilePlacementForReplaceRowTagChooser
+ transientData.replace_rows
+ index
+ }}
/>
</collection.Field>
</row.Col>
diff --git a/frontend/discourse/app/form-kit/components/fk/control/tag-chooser.gjs b/frontend/discourse/app/form-kit/components/fk/control/tag-chooser.gjs
index a337d9c5f71..cf174bea97f 100644
--- a/frontend/discourse/app/form-kit/components/fk/control/tag-chooser.gjs
+++ b/frontend/discourse/app/form-kit/components/fk/control/tag-chooser.gjs
@@ -26,6 +26,7 @@ export default class FKControlTagChooser extends FKBaseControl {
filterPlaceholder=@placeholder
maximum=@maximum
+ mobilePlacement=@mobilePlacement
}}
class="form-kit__control-tag-chooser"
/>
diff --git a/frontend/discourse/select-kit/components/select-kit.js b/frontend/discourse/select-kit/components/select-kit.js
index 07dfc8650b8..4d77fce7262 100644
--- a/frontend/discourse/select-kit/components/select-kit.js
+++ b/frontend/discourse/select-kit/components/select-kit.js
@@ -127,6 +127,7 @@ function protoProp(prototype, key, descriptor) {
@classNameBindings(
"selectKit.isLoading:is-loading",
"selectKit.isExpanded:is-expanded",
+ "selectKit.isPlacedAbove:is-placed-above",
"selectKit.options.disabled:is-disabled",
"selectKit.isHidden:is-hidden",
"selectKit.hasSelection:has-selection"
@@ -161,6 +162,7 @@ function protoProp(prototype, key, descriptor) {
autofocus: false,
placementStrategy: null,
mobilePlacementStrategy: null,
+ mobilePlacement: null,
desktopPlacementStrategy: null,
hiddenValues: null,
disabled: false,
@@ -220,6 +222,7 @@ export default class SelectKit extends Component {
isLoading: false,
isHidden: false,
isExpanded: false,
+ isPlacedAbove: false,
isFilterExpanded: false,
enterDisabled: false,
hasSelection: false,
@@ -969,6 +972,7 @@ export default class SelectKit extends Component {
this.selectKit.setProperties({
isExpanded: false,
+ isPlacedAbove: false,
filter: null,
});
}
@@ -982,16 +986,12 @@ export default class SelectKit extends Component {
this.clearErrors();
this.selectKit.onOpen(event);
- if (this.site.desktopView) {
- this.cleanupFloatingUi?.();
- this.cleanupFloatingUi = autoUpdate(
- this.getHeader(),
- this._bodyElement(),
- () => this.updateFloatingUiPosition()
- );
- } else {
- this.updateFloatingUiPosition();
- }
+ this.cleanupFloatingUi?.();
+ this.cleanupFloatingUi = autoUpdate(
+ this.getHeader(),
+ this._bodyElement(),
+ () => this.updateFloatingUiPosition()
+ );
this.selectKit.setProperties({
isExpanded: true,
@@ -1104,11 +1104,11 @@ export default class SelectKit extends Component {
hide(),
];
- computePosition(referenceElement, floatingElement, {
- placement: this.selectKit.options.placement,
+ return computePosition(referenceElement, floatingElement, {
+ placement: this._computePlacement(),
strategy,
middleware,
- }).then(({ x, y, middlewareData }) => {
+ }).then(({ x, y, placement, middlewareData }) => {
const style = {
width,
minWidth,
@@ -1127,6 +1127,7 @@ export default class SelectKit extends Component {
}
}
+ this.selectKit.set("isPlacedAbove", placement.startsWith("top"));
Object.assign(floatingElement.style, style);
});
}
@@ -1222,6 +1223,14 @@ export default class SelectKit extends Component {
return placementStrategy;
}
+ _computePlacement() {
+ if (this.site.mobileView && this.selectKit.options.mobilePlacement) {
+ return this.selectKit.options.mobilePlacement;
+ }
+
+ return this.selectKit.options.placement;
+ }
+
_deprecated(text) {
deprecated(text, {
since: "v2.4.0",
diff --git a/frontend/discourse/tests/integration/components/select-kit/single-select-test.gjs b/frontend/discourse/tests/integration/components/select-kit/single-select-test.gjs
index 02cb3a96970..16c1bf2f40f 100644
--- a/frontend/discourse/tests/integration/components/select-kit/single-select-test.gjs
+++ b/frontend/discourse/tests/integration/components/select-kit/single-select-test.gjs
@@ -1,6 +1,7 @@
import { hash } from "@ember/helper";
import { find, render, tab } from "@ember/test-helpers";
import { module, test } from "qunit";
+import { forceMobile } from "discourse/lib/mobile";
import SingleSelect from "discourse/select-kit/components/single-select";
import { setupRenderingTest } from "discourse/tests/helpers/component-test";
import selectKit from "discourse/tests/helpers/select-kit-helper";
@@ -506,6 +507,30 @@ module("Integration | Component | SelectKit | SingleSelect", function (hooks) {
assert.true(header.bottom > body.top, "correctly offsets the body");
});
+ test("options.mobilePlacement", async function (assert) {
+ forceMobile();
+ setDefaultState(this);
+
+ await render(
+ <template>
+ <div style="position: fixed; top: 50%; left: 0; right: 0;">
+ <SingleSelect
+ @value={{this.value}}
+ @content={{this.content}}
+ @options={{hash mobilePlacement="top"}}
+ />
+ </div>
+ </template>
+ );
+ await this.subject.expand();
+
+ const header = find(".select-kit-header").getBoundingClientRect();
+ const body = find(".select-kit-body").getBoundingClientRect();
+
+ assert.true(body.bottom < header.top, "body opens above the header");
+ assert.dom(".select-kit").hasClass("is-placed-above");
+ });
+
test("options.expandedOnInsert", async function (assert) {
setDefaultState(this);
await render(