A platform for community discussion. Free, open, simple.
DEV: Skip rendering BlockOutlet container when no blocks are visible (#38806)
Sérgio Saquetimee76b07a1847
diff --git a/frontend/discourse/app/lib/blocks/-internals/components/block-outlet-root-container.gjs b/frontend/discourse/app/lib/blocks/-internals/components/block-outlet-root-container.gjsindex 0e58d686d00..fa79928f80f 100644--- a/frontend/discourse/app/lib/blocks/-internals/components/block-outlet-root-container.gjs+++ b/frontend/discourse/app/lib/blocks/-internals/components/block-outlet-root-container.gjs@@ -263,14 +263,16 @@ export default class BlockOutletRootContainer extends Component {}<template>- <div class={{this.safeOutletName}}>- <div class={{this.containerClassName}}>- <div class={{this.layoutClassName}}>- {{#each this.processedChildren key="key" as |child|}}- <child.Component />- {{/each}}+ {{#if this.processedChildren.length}}+ <div class={{this.safeOutletName}}>+ <div class={{this.containerClassName}}>+ <div class={{this.layoutClassName}}>+ {{#each this.processedChildren key="key" as |child|}}+ <child.Component />+ {{/each}}+ </div></div></div>- </div>+ {{/if}}</template>}diff --git a/frontend/discourse/tests/integration/components/block-outlet-conditions-test.gjs b/frontend/discourse/tests/integration/components/block-outlet-conditions-test.gjsindex 4fc1e7f4fa0..cb8f7501555 100644--- a/frontend/discourse/tests/integration/components/block-outlet-conditions-test.gjs+++ b/frontend/discourse/tests/integration/components/block-outlet-conditions-test.gjs@@ -589,6 +589,28 @@ module("Integration | Blocks | BlockOutlet | Conditions", function (hooks) {assert.dom(".deeply-visible-child").exists();});+ test("does not render outlet container when all blocks are hidden by conditions", async function (assert) {+ @block("all-hidden-block")+ class AllHiddenBlock extends Component {+ <template>+ <div class="all-hidden">Hidden</div>+ </template>+ }++ withPluginApi((api) =>+ api.renderBlocks("sidebar-blocks", [+ { block: AllHiddenBlock, conditions: { type: "always-false" } },+ ])+ );++ await render(<template><BlockOutlet @name="sidebar-blocks" /></template>);++ assert.dom(".all-hidden").doesNotExist();+ assert.dom(".sidebar-blocks").doesNotExist();+ assert.dom(".sidebar-blocks__container").doesNotExist();+ assert.dom(".sidebar-blocks__layout").doesNotExist();+ });+test("container with own failing condition does not render even with visible children", async function (assert) {@block("child-would-be-visible")class ChildWouldBeVisible extends Component {