A platform for community discussion. Free, open, simple.
PERF: Drop two redundant indexes on browser pageview events (#44008)
Osama Sayeghf0f78ec94ba0
diff --git a/app/models/browser_pageview_event.rb b/app/models/browser_pageview_event.rbindex 12a39e7d6af..47f3549de5e 100644--- a/app/models/browser_pageview_event.rb+++ b/app/models/browser_pageview_event.rb@@ -274,7 +274,6 @@ end## Indexes#-# idx_bpe_beacon_created_at_id (created_at,id) WHERE (source = 2)# idx_bpe_browser_backfill (created_at,id) WHERE (browser IS NULL)# idx_bpe_crawler_created_at_covering (created_at) WHERE (score > 55)# idx_bpe_created_at_country_code (created_at,country_code)@@ -283,7 +282,6 @@ end# idx_bpe_created_at_session_id (created_at,session_id,source)# idx_bpe_ip_ua_created_at (ip_address,user_agent,created_at)# idx_bpe_referrer_backfill (created_at,id) WHERE ((referrer IS NOT NULL) AND ((normalized_referrer_version IS NULL) OR (normalized_referrer_version < 1)))-# idx_bpe_session_created_at (session_id,created_at)# idx_bpe_session_created_at_covering (session_id,created_at)# idx_bpe_url_backfill (created_at,id) WHERE ((normalized_url_version IS NULL) OR (normalized_url_version < 1))# index_browser_pageview_events_on_created_at (created_at) USING brindiff --git a/db/post_migrate/20260922233816_drop_redundant_browser_pageview_indexes.rb b/db/post_migrate/20260922233816_drop_redundant_browser_pageview_indexes.rbnew file mode 100644index 00000000000..abe89db750a--- /dev/null+++ b/db/post_migrate/20260922233816_drop_redundant_browser_pageview_indexes.rb@@ -0,0 +1,32 @@+# frozen_string_literal: true++class DropRedundantBrowserPageviewIndexes < ActiveRecord::Migration[8.0]+ disable_ddl_transaction!++ def up+ remove_index :browser_pageview_events,+ name: "idx_bpe_session_created_at",+ algorithm: :concurrently,+ if_exists: true+ remove_index :browser_pageview_events,+ name: "idx_bpe_beacon_created_at_id",+ algorithm: :concurrently,+ if_exists: true+ end++ def down+ add_index :browser_pageview_events,+ %i[session_id created_at],+ name: "idx_bpe_session_created_at",+ algorithm: :concurrently+ add_index :browser_pageview_events,+ %i[created_at id],+ name: "idx_bpe_beacon_created_at_id",+ order: {+ created_at: :desc,+ id: :desc,+ },+ where: "source = 2",+ algorithm: :concurrently+ end+enddiff --git a/db/structure.sql b/db/structure.sqlindex 5c10b624468..b3daa63b7cd 100644--- a/db/structure.sql+++ b/db/structure.sql@@ -19207,13 +19207,6 @@ CREATE UNIQUE INDEX idx_bpcd_rollups_date_country_unique ON public.browser_pagevCREATE UNIQUE INDEX idx_bpcrawler_rollups_date_logged_in_unique ON public.browser_pageview_crawler_daily_rollups USING btree (date, logged_in);------ Name: idx_bpe_beacon_created_at_id; Type: INDEX; Schema: public; Owner: ------CREATE INDEX idx_bpe_beacon_created_at_id ON public.browser_pageview_events USING btree (created_at DESC, id DESC) WHERE (source = 2);------ Name: idx_bpe_browser_backfill; Type: INDEX; Schema: public; Owner: ---@@ -19270,13 +19263,6 @@ CREATE INDEX idx_bpe_ip_ua_created_at ON public.browser_pageview_events USING btCREATE INDEX idx_bpe_referrer_backfill ON public.browser_pageview_events USING btree (created_at DESC, id DESC) WHERE ((referrer IS NOT NULL) AND ((normalized_referrer_version IS NULL) OR (normalized_referrer_version < 1)));------ Name: idx_bpe_session_created_at; Type: INDEX; Schema: public; Owner: ------CREATE INDEX idx_bpe_session_created_at ON public.browser_pageview_events USING btree (session_id, created_at);------ Name: idx_bpe_session_created_at_covering; Type: INDEX; Schema: public; Owner: ---@@ -25405,6 +25391,7 @@ ALTER TABLE ONLY public.ad_plugin_house_ads_groupsSET search_path TO "$user", public;INSERT INTO "schema_migrations" (version) VALUES+('20260922233816'),('20260921120000'),('20260921081150'),('20260921074918'),