A platform for community discussion. Free, open, simple.
FIX: Only fail invalid items in the "Award score" workflow node (#45224)
Régis Hanolf1a4b1733461
diff --git a/plugins/discourse-gamification/lib/discourse_workflows/nodes/gamification_score/v1.rb b/plugins/discourse-gamification/lib/discourse_workflows/nodes/gamification_score/v1.rbindex c4174522dd2..0f6e08e3df9 100644--- a/plugins/discourse-gamification/lib/discourse_workflows/nodes/gamification_score/v1.rb+++ b/plugins/discourse-gamification/lib/discourse_workflows/nodes/gamification_score/v1.rb@@ -88,7 +88,7 @@ if defined?(DiscourseWorkflows)def execute(exec_ctx)items =- exec_ctx.input_items.map.with_index do |_item, item_index|+ exec_ctx.each_item do |_item, item_index|config = {"username" => exec_ctx.get_node_parameter("username", item_index),"points" => exec_ctx.get_node_parameter("points", item_index),diff --git a/plugins/discourse-gamification/spec/lib/discourse_workflows/nodes/gamification_score/v1_spec.rb b/plugins/discourse-gamification/spec/lib/discourse_workflows/nodes/gamification_score/v1_spec.rbindex dedfecd001e..2e5d1e3cc14 100644--- a/plugins/discourse-gamification/spec/lib/discourse_workflows/nodes/gamification_score/v1_spec.rb+++ b/plugins/discourse-gamification/spec/lib/discourse_workflows/nodes/gamification_score/v1_spec.rb@@ -92,6 +92,27 @@ RSpec.describe DiscourseWorkflows::Nodes::GamificationScore::V1 doexpect { execute_node(configuration: config) }.to raise_error(DiscourseWorkflows::NodeError)end+ it "fails only the unknown user's item when continuing on error" do+ config = { "username" => "={{ $json.username }}", "points" => 10 }+ input_items = [+ { "json" => { "username" => user.username } },+ { "json" => { "username" => "nonexistent" } },+ { "json" => { "username" => user.username } },+ ]++ output =+ execute_node_output(+ configuration: config,+ input_items:,+ node_settings: {+ "onError" => "continueErrorOutput",+ },+ )++ expect(output.first.map { |item| item.key?("__failed") }).to eq([false, true, false])+ expect(DiscourseGamification::GamificationScoreEvent.where(user:).count).to eq(2)+ end+it "raises when points is zero" doconfig = { "username" => user.username, "points" => 0 }