Skip to content

A platform for community discussion. Free, open, simple.

SECURITY: Templates endpoint exposes hidden tag names

Arpit Jalanf216f258bd47
diff --git a/plugins/discourse-templates/app/serializers/discourse_templates/templates_serializer.rb b/plugins/discourse-templates/app/serializers/discourse_templates/templates_serializer.rb
index 6f6b6437d8d..7ec3c29ea9e 100644
--- a/plugins/discourse-templates/app/serializers/discourse_templates/templates_serializer.rb
+++ b/plugins/discourse-templates/app/serializers/discourse_templates/templates_serializer.rb
@@ -13,7 +13,7 @@ module DiscourseTemplates
end
def tags
- object.tags.map(&:name).sort
+ object.visible_tags(scope || Guardian.new).map(&:name).sort
end
def usages
diff --git a/plugins/discourse-templates/spec/requests/templates_controller_spec.rb b/plugins/discourse-templates/spec/requests/templates_controller_spec.rb
index bf643d92269..960c43a85db 100644
--- a/plugins/discourse-templates/spec/requests/templates_controller_spec.rb
+++ b/plugins/discourse-templates/spec/requests/templates_controller_spec.rb
@@ -97,6 +97,24 @@ describe DiscourseTemplates::TemplatesController do
expect(parsed["templates"]).to eq(expected_response)
end
+ it "omits tags hidden by tag group permissions" do
+ SiteSetting.discourse_templates_categories = templates_sub_category_everyone.id.to_s
+ hidden_tag = Fabricate(:tag, topics: [template_item6], name: "staff-only")
+ Fabricate(
+ :tag_group,
+ permissions: {
+ "staff" => TagGroupPermission.permission_types[:full],
+ },
+ tag_names: [hidden_tag.name],
+ )
+
+ get "/discourse_templates"
+
+ expect(response.status).to eq(200)
+ template = response.parsed_body["templates"].find { |item| item["id"] == template_item6.id }
+ expect(template["tags"]).to contain_exactly(everyone_tag.name)
+ end
+
it "should list topics from multiple parent categories" do
SiteSetting.discourse_templates_categories = [
templates_sub_category_everyone,