A platform for community discussion. Free, open, simple.
UX: Composer reply icon (#39338)
Derek Rushforthf3855eba0eb8
diff --git a/frontend/discourse/select-kit/components/composer-actions.js b/frontend/discourse/select-kit/components/composer-actions.jsindex 4d999726624..892a638c030 100644--- a/frontend/discourse/select-kit/components/composer-actions.js+++ b/frontend/discourse/select-kit/components/composer-actions.js@@ -70,7 +70,7 @@ export default class ComposerActions extends DropdownSelectBoxComponent {} else if (this.isEditing) {return "pencil";} else {- return "share";+ return "reply";}}@@ -169,7 +169,7 @@ export default class ComposerActions extends DropdownSelectBoxComponent {postUsername: _postSnapshot.username,}),description: i18n("composer.composer_actions.reply_to_post.desc"),- icon: "share",+ icon: "reply",id: "reply_to_post",});}@@ -186,7 +186,7 @@ export default class ComposerActions extends DropdownSelectBoxComponent {items.push({name: i18n("composer.composer_actions.reply_to_topic.label"),description: i18n("composer.composer_actions.reply_to_topic.desc"),- icon: "share",+ icon: "reply",id: "reply_to_topic",});}diff --git a/frontend/discourse/tests/acceptance/composer-actions-test.js b/frontend/discourse/tests/acceptance/composer-actions-test.jsindex e405b433dab..d617bd84b51 100644--- a/frontend/discourse/tests/acceptance/composer-actions-test.js+++ b/frontend/discourse/tests/acceptance/composer-actions-test.js@@ -88,7 +88,7 @@ acceptance(`Composer Actions`, function (needs) {.dom(".composer-actions svg.d-icon-far-eye-slash").doesNotExist("whisper icon is not visible");assert- .dom(".composer-actions svg.d-icon-share")+ .dom(".composer-actions svg.d-icon-reply").exists("reply icon is visible");await composerActions.expand();@@ -98,7 +98,7 @@ acceptance(`Composer Actions`, function (needs) {.dom(".composer-actions svg.d-icon-far-eye-slash").exists("whisper icon is visible");assert- .dom(".composer-actions svg.d-icon-share")+ .dom(".composer-actions svg.d-icon-reply").doesNotExist("reply icon is not visible");});@@ -246,7 +246,7 @@ acceptance(`Composer Actions`, function (needs) {.dom(".composer-actions svg.d-icon-anchor").doesNotExist("no-bump icon is not visible");assert- .dom(".composer-actions svg.d-icon-share")+ .dom(".composer-actions svg.d-icon-reply").exists("reply icon is visible");await composerActions.expand();@@ -256,7 +256,7 @@ acceptance(`Composer Actions`, function (needs) {.dom(".composer-actions svg.d-icon-anchor").exists("no-bump icon is visible");assert- .dom(".composer-actions svg.d-icon-share")+ .dom(".composer-actions svg.d-icon-reply").doesNotExist("reply icon is not visible");await composerActions.expand();@@ -266,7 +266,7 @@ acceptance(`Composer Actions`, function (needs) {.dom(".composer-actions svg.d-icon-anchor").doesNotExist("no-bump icon is not visible");assert- .dom(".composer-actions svg.d-icon-share")+ .dom(".composer-actions svg.d-icon-reply").exists("reply icon is visible");});@@ -283,7 +283,7 @@ acceptance(`Composer Actions`, function (needs) {.dom(".reply-details .whisper .d-icon-anchor").doesNotExist("no-bump icon is not visible");assert- .dom(".composer-actions svg.d-icon-share")+ .dom(".composer-actions svg.d-icon-reply").exists("reply icon is visible");await composerActions.expand();@@ -298,7 +298,7 @@ acceptance(`Composer Actions`, function (needs) {.dom(".reply-details .no-bump .d-icon-anchor").exists("no-bump icon is visible");assert- .dom(".composer-actions svg.d-icon-share")+ .dom(".composer-actions svg.d-icon-reply").doesNotExist("reply icon is not visible");});