Skip to content

A platform for community discussion. Free, open, simple.

DEV: Update omniauth-facebook from 9.0.0 to 10.0.0 (#39657)

Jarek Radoszf49db6f74722
diff --git a/Gemfile.lock b/Gemfile.lock
index 2142b2d98d3..ae359c9fbc1 100644
--- a/Gemfile.lock
+++ b/Gemfile.lock
@@ -374,8 +374,9 @@ GEM
hashie (>= 3.4.6)
rack (>= 2.2.3)
rack-protection
- omniauth-facebook (9.0.0)
- omniauth-oauth2 (~> 1.2)
+ omniauth-facebook (10.0.0)
+ bigdecimal
+ omniauth-oauth2 (>= 1.2, < 3)
omniauth-github (2.0.0)
omniauth (~> 2.0)
omniauth-oauth2 (~> 1.7.1)
@@ -1112,7 +1113,7 @@ CHECKSUMS
octokit (10.0.0) sha256=82e99a539b7637b7e905e6d277bb0c1a4bed56735935cc33db6da7eae49a24e8
oj (3.16.12) sha256=ad9fad6a06dabcf4cfe6a420690a4375377685c16eee0ae88e8d38a43ed7b556
omniauth (2.1.2) sha256=def03277298b8f8a5d3ff16cdb2eb5edb9bffed60ee7dda24cc0c89b3ae6a0ce
- omniauth-facebook (9.0.0) sha256=440ad8dd9edc9ebec1fd6607b787667c8ce70d2969c2030d7e9ca42a271af854
+ omniauth-facebook (10.0.0) sha256=dfdc6cbada5387572d554784861546cf6382f9fa16c4731cbe5813e570fcb9e1
omniauth-github (2.0.0) sha256=1ca26576125a97e27d3f8dc39cd98853d7382dd0fc04a40d3b9ec345ee378649
omniauth-google-oauth2 (1.0.1) sha256=2ed7a4ac8d98ab824c95e0d6760784abf1248262b3ba2ab56ec7ebd7074d12a6
omniauth-oauth (1.2.1) sha256=25bf22c90234280fa825200490f03ff1ce7d76f1a4fbd6c882c6c5b169c58da8
diff --git a/spec/integration/facebook_omniauth_spec.rb b/spec/integration/facebook_omniauth_spec.rb
index 48990835cf2..e5b657e944a 100644
--- a/spec/integration/facebook_omniauth_spec.rb
+++ b/spec/integration/facebook_omniauth_spec.rb
@@ -22,7 +22,7 @@ describe "Facebook OAuth2" do
stub_request(
:get,
- "https://graph.facebook.com/v5.0/me?appsecret_proof=#{appsecret_proof}&fields=name,first_name,last_name,email",
+ "https://graph.facebook.com/v19.0/me?appsecret_proof=#{appsecret_proof}&fields=name,first_name,last_name,email",
).with(headers: { "Authorization" => "OAuth #{access_token}" }).to_return(
status: 200,
body: JSON.dump(body),
@@ -37,7 +37,7 @@ describe "Facebook OAuth2" do
SiteSetting.facebook_app_id = app_id
SiteSetting.facebook_app_secret = app_secret
- stub_request(:post, "https://graph.facebook.com/v5.0/oauth/access_token").with(
+ stub_request(:post, "https://graph.facebook.com/v19.0/oauth/access_token").with(
body:
hash_including(
"client_id" => app_id,
@@ -59,7 +59,7 @@ describe "Facebook OAuth2" do
it "signs in the user if the API response from facebook includes an email (implies it's verified) and the email matches an existing user's" do
post "/auth/facebook"
expect(response.status).to eq(302)
- expect(response.location).to start_with("https://www.facebook.com/v5.0/dialog/oauth")
+ expect(response.location).to start_with("https://www.facebook.com/v19.0/dialog/oauth")
setup_facebook_email_stub(email: user1.email)
@@ -73,7 +73,7 @@ describe "Facebook OAuth2" do
it "doesn't sign in anyone if the API response from facebook doesn't include an email (implying the user's email on facebook isn't verified)" do
post "/auth/facebook"
expect(response.status).to eq(302)
- expect(response.location).to start_with("https://www.facebook.com/v5.0/dialog/oauth")
+ expect(response.location).to start_with("https://www.facebook.com/v19.0/dialog/oauth")
setup_facebook_email_stub(email: nil)