A platform for community discussion. Free, open, simple.
PERF: Replace the IP and user agent index on browser pageview events (#44022)
Osama Sayeghf4d6be0f620b
diff --git a/app/models/browser_pageview_event.rb b/app/models/browser_pageview_event.rbindex 47f3549de5e..f4828e03f39 100644--- a/app/models/browser_pageview_event.rb+++ b/app/models/browser_pageview_event.rb@@ -280,7 +280,7 @@ end# idx_bpe_created_at_id (created_at,id)# idx_bpe_created_at_normalized_referrer (created_at,normalized_referrer)# idx_bpe_created_at_session_id (created_at,session_id,source)-# idx_bpe_ip_ua_created_at (ip_address,user_agent,created_at)+# idx_bpe_ip_created_at (ip_address,created_at)# idx_bpe_referrer_backfill (created_at,id) WHERE ((referrer IS NOT NULL) AND ((normalized_referrer_version IS NULL) OR (normalized_referrer_version < 1)))# idx_bpe_session_created_at_covering (session_id,created_at)# idx_bpe_url_backfill (created_at,id) WHERE ((normalized_url_version IS NULL) OR (normalized_url_version < 1))diff --git a/db/migrate/20260923080642_add_ip_created_at_index_to_browser_pageview_events.rb b/db/migrate/20260923080642_add_ip_created_at_index_to_browser_pageview_events.rbnew file mode 100644index 00000000000..a567489dde9--- /dev/null+++ b/db/migrate/20260923080642_add_ip_created_at_index_to_browser_pageview_events.rb@@ -0,0 +1,25 @@+# frozen_string_literal: true++class AddIpCreatedAtIndexToBrowserPageviewEvents < ActiveRecord::Migration[8.0]+ disable_ddl_transaction!++ INDEX_NAME = "idx_bpe_ip_created_at"++ def up+ remove_index :browser_pageview_events,+ name: INDEX_NAME,+ algorithm: :concurrently,+ if_exists: true+ add_index :browser_pageview_events,+ %i[ip_address created_at],+ name: INDEX_NAME,+ algorithm: :concurrently+ end++ def down+ remove_index :browser_pageview_events,+ name: INDEX_NAME,+ algorithm: :concurrently,+ if_exists: true+ end+enddiff --git a/db/post_migrate/20260923080644_drop_ip_ua_index_from_browser_pageview_events.rb b/db/post_migrate/20260923080644_drop_ip_ua_index_from_browser_pageview_events.rbnew file mode 100644index 00000000000..9320f97f326--- /dev/null+++ b/db/post_migrate/20260923080644_drop_ip_ua_index_from_browser_pageview_events.rb@@ -0,0 +1,21 @@+# frozen_string_literal: true++class DropIpUaIndexFromBrowserPageviewEvents < ActiveRecord::Migration[8.0]+ disable_ddl_transaction!++ INDEX_NAME = "idx_bpe_ip_ua_created_at"++ def up+ remove_index :browser_pageview_events,+ name: INDEX_NAME,+ algorithm: :concurrently,+ if_exists: true+ end++ def down+ add_index :browser_pageview_events,+ %i[ip_address user_agent created_at],+ name: INDEX_NAME,+ algorithm: :concurrently+ end+enddiff --git a/db/structure.sql b/db/structure.sqlindex a81215dc485..5cce8f7ac14 100644--- a/db/structure.sql+++ b/db/structure.sql@@ -19342,10 +19342,10 @@ CREATE INDEX idx_bpe_created_at_session_id ON public.browser_pageview_events USI----- Name: idx_bpe_ip_ua_created_at; Type: INDEX; Schema: public; Owner: -+-- Name: idx_bpe_ip_created_at; Type: INDEX; Schema: public; Owner: ----CREATE INDEX idx_bpe_ip_ua_created_at ON public.browser_pageview_events USING btree (ip_address, user_agent, created_at);+CREATE INDEX idx_bpe_ip_created_at ON public.browser_pageview_events USING btree (ip_address, created_at);--@@ -25504,6 +25504,8 @@ ALTER TABLE ONLY public.ad_plugin_house_ads_groupsSET search_path TO "$user", public;INSERT INTO "schema_migrations" (version) VALUES+('20260923080644'),+('20260923080642'),('20260922233816'),('20260921120000'),('20260921081150'),