A platform for community discussion. Free, open, simple.
SECURITY: Onebox Domain Blocklist Bypass via Case-Sensitive Comparison
Arpit Jalanf503971d311b
diff --git a/lib/onebox/domain_checker.rb b/lib/onebox/domain_checker.rbindex 9d78c62bde1..38eee3ad91f 100644--- a/lib/onebox/domain_checker.rb+++ b/lib/onebox/domain_checker.rb@@ -3,10 +3,16 @@module Oneboxclass DomainCheckerdef self.is_blocked?(hostname)+ normalized_hostname = hostname.to_s.downcase+SiteSetting.blocked_onebox_domains&.split("|")- &.any? { |blocked| hostname == blocked || hostname.end_with?(".#{blocked}") }+ &.any? do |blocked|+ normalized_blocked = blocked.downcase+ normalized_hostname == normalized_blocked ||+ normalized_hostname.end_with?(".#{normalized_blocked}")+ endendendenddiff --git a/spec/lib/onebox/domain_checker_spec.rb b/spec/lib/onebox/domain_checker_spec.rbindex 0b375363ce8..08cf83e2eaa 100644--- a/spec/lib/onebox/domain_checker_spec.rb+++ b/spec/lib/onebox/domain_checker_spec.rb@@ -19,5 +19,19 @@ RSpec.describe Onebox::DomainChecker doit { expect(described_class.is_blocked?("xapi.cat.org")).to be(false) }it { expect(described_class.is_blocked?("xkitten.cloud")).to be(false) }end++ describe "matches regardless of hostname casing" do+ it { expect(described_class.is_blocked?("API.CAT.ORG")).to be(true) }+ it { expect(described_class.is_blocked?("Api.Cat.Org")).to be(true) }+ it { expect(described_class.is_blocked?("Dev.Api.Cat.Org")).to be(true) }+ it { expect(described_class.is_blocked?("KITTEN.CLOUD")).to be(true) }+ end++ describe "matches regardless of blocked entry casing" do+ before { SiteSetting.blocked_onebox_domains = "API.CAT.ORG" }++ it { expect(described_class.is_blocked?("api.cat.org")).to be(true) }+ it { expect(described_class.is_blocked?("dev.api.cat.org")).to be(true) }+ endendend