Skip to content

A platform for community discussion. Free, open, simple.

UX: Don't include `powered_by` string in site text overrides (#39660)

Penar Musarajfd3d277d68a6
diff --git a/app/controllers/admin/site_texts_controller.rb b/app/controllers/admin/site_texts_controller.rb
index 1f25f256e2f..7112267a2d7 100644
--- a/app/controllers/admin/site_texts_controller.rb
+++ b/app/controllers/admin/site_texts_controller.rb
@@ -15,7 +15,8 @@ class Admin::SiteTextsController < Admin::AdminController
"user_notifications.confirm_old_email.text_body_template",
"user_notifications.confirm_old_email_add.title",
"user_notifications.confirm_old_email_add.subject_template",
- "user_notifications.confirm_old_email_add.text_body_template"
+ "user_notifications.confirm_old_email_add.text_body_template",
+ "js.powered_by_discourse"
].freeze
def self.restricted_key?(key)
diff --git a/db/migrate/20260430142946_drop_powered_by_discourse_translation_override.rb b/db/migrate/20260430142946_drop_powered_by_discourse_translation_override.rb
new file mode 100644
index 00000000000..c5fc17a2942
--- /dev/null
+++ b/db/migrate/20260430142946_drop_powered_by_discourse_translation_override.rb
@@ -0,0 +1,10 @@
+# frozen_string_literal: true
+class DropPoweredByDiscourseTranslationOverride < ActiveRecord::Migration[8.0]
+ def up
+ execute "DELETE FROM translation_overrides WHERE translation_key = 'js.powered_by_discourse'"
+ end
+
+ def down
+ raise ActiveRecord::IrreversibleMigration
+ end
+end
diff --git a/spec/requests/admin/site_texts_controller_spec.rb b/spec/requests/admin/site_texts_controller_spec.rb
index dc956c15ed7..3e7d74f145a 100644
--- a/spec/requests/admin/site_texts_controller_spec.rb
+++ b/spec/requests/admin/site_texts_controller_spec.rb
@@ -335,6 +335,11 @@ RSpec.describe Admin::SiteTextsController do
expect(response.status).to eq(200)
returned_ids = response.parsed_body["site_texts"].map { |t| t["id"] }
expect((returned_ids & Admin::SiteTextsController::RESTRICTED_KEYS.to_a)).to be_empty
+
+ get "/admin/customize/site_texts.json", params: { q: "powered_by", locale: }
+ expect(response.status).to eq(200)
+ returned_ids = response.parsed_body["site_texts"].map { |t| t["id"] }
+ expect(returned_ids).not_to include("js.powered_by_discourse")
end
end