Skip to content

A platform for community discussion. Free, open, simple.

DEV: Enable admin warning for all pending deprecations (#41697)

David Taylorfd98c6d576ec
diff --git a/frontend/discourse/app/deprecation-workflow.js b/frontend/discourse/app/deprecation-workflow.js
index 48238f783d6..0a2a2bba8d5 100644
--- a/frontend/discourse/app/deprecation-workflow.js
+++ b/frontend/discourse/app/deprecation-workflow.js
@@ -317,65 +317,101 @@ const workflows = [
handler: "silence",
matchId: "deprecate-import-meta-from-ember",
},
- {
- handler: "log",
- matchId: /^discourse\.native-array-extensions\..+$/,
- },
// CRITICAL DEPRECATIONS that should trigger admin warnings,
// To keep warnings meaningful and prevent overflowing users with them,
// we should only add values here after fixing core and official plugins
- {
- handler: "notify-admin",
- matchId: "discourse.category-hashtags.categoryHashtagTriggerRule",
- },
- {
- handler: "notify-admin",
- matchId: "discourse.click-track.is-valid-link-jquery",
- },
- {
- handler: "notify-admin",
- matchId: "discourse.component-template-resolving",
- },
- { handler: "notify-admin", matchId: "discourse.create-store-helper" },
- { handler: "notify-admin", matchId: "discourse.decorate-plugin-outlet" },
- { handler: "notify-admin", matchId: "discourse.ember-computed-decorators" },
- {
- handler: "notify-admin",
- matchId: "discourse.formatter.update-relative-age-node-list",
- },
- { handler: "notify-admin", matchId: "discourse.global.site-settings" },
- { handler: "notify-admin", matchId: "discourse.global.site" },
- { handler: "notify-admin", matchId: "discourse.global.user" },
- {
- handler: "notify-admin",
- matchId: "discourse.icon-renderer-translatedtitle",
- },
- { handler: "notify-admin", matchId: "discourse.jquery-cookie" },
- { handler: "notify-admin", matchId: "discourse.markdown-it.whitelist" },
- {
- handler: "notify-admin",
- matchId: "discourse.nav-item.built-list-site-settings",
- },
- {
- handler: "notify-admin",
- matchId: "discourse.offset-calculator.minimumOffset",
- },
- {
- handler: "notify-admin",
- matchId: "discourse.plugin-outlet-classic-args-clash",
- },
- {
- handler: "notify-admin",
- matchId: "discourse.post-stream.trigger-new-post",
- },
- { handler: "notify-admin", matchId: "discourse.pretty-text.registerOption" },
- { handler: "notify-admin", matchId: "discourse.qunit.acceptance-function" },
- { handler: "notify-admin", matchId: "discourse.qunit.global-exists" },
- { handler: "notify-admin", matchId: "discourse.resolver-resolutions" },
- { handler: "notify-admin", matchId: "discourse.safari-hacks-disabled" },
- { handler: "notify-admin", matchId: "discourse.user.resolved-timezone" },
- { handler: "notify-admin", matchId: "discourse.user.userOptions" },
- { handler: "notify-admin", matchId: "template-action" }, // removed in Ember 6.0, but we have a polyfill
+ ...[
+ "discourse.add-saveable-user-option-field",
+ "discourse.add-toolbar-popup-menu-options-callback",
+ "discourse.add-user-menu-glyph",
+ "discourse.application-show-footer",
+ "discourse.avatar-utils",
+ "discourse.base-url",
+ "discourse.bound-date",
+ "discourse.capitalize-string",
+ "discourse.category-hashtags.categoryHashtagTriggerRule",
+ "discourse.category-list.categories",
+ "discourse.category-list.listForParent",
+ "discourse.chat.addToolbarButton",
+ "discourse.click-track.is-valid-link-jquery",
+ "discourse.component-template-resolving",
+ "discourse.composer-controller.clear-popup-menu-options-callback",
+ "discourse.composer.usernames",
+ "discourse.computed-html-safe",
+ "discourse.create-store-helper",
+ "discourse.createNewMessageViaParams",
+ "discourse.createNewTopicViaParams",
+ "discourse.current-theme-key",
+ "discourse.d-editor.on-toolbar-create",
+ "discourse.d-popover",
+ "discourse.d-section",
+ "discourse.decorate-plugin-outlet",
+ "discourse.deprecated-resolver-normalization",
+ "discourse.discourse-module",
+ "discourse.discovery-topics-controller",
+ "discourse.ember-computed-decorators",
+ "discourse.fa-icon",
+ "discourse.form-kit.legacy-field-yield",
+ "discourse.format-age",
+ "discourse.formatter.update-relative-age-node-list",
+ "discourse.get-owner-with-fallback",
+ "discourse.get-url-helper",
+ "discourse.global.site",
+ "discourse.global.site-settings",
+ "discourse.global.user",
+ "discourse.hbs-extension",
+ "discourse.header-extra-info.needs-second-row-if",
+ "discourse.header-service-topic",
+ "discourse.hide-popover",
+ "discourse.html-helper",
+ "discourse.html-safe-helper",
+ "discourse.icon-picker",
+ "discourse.icon-renderer-translatedtitle",
+ "discourse.inline-date",
+ "discourse.is-legacy-ember",
+ "discourse.jquery-cookie",
+ "discourse.legacy-array-like-object.proxied-array",
+ "discourse.legacy-topic-list",
+ "discourse.markdown-it.whitelist",
+ "discourse.nav-item.built-list-site-settings",
+ "discourse.navigation-category-controller",
+ "discourse.number-field",
+ "discourse.offset-calculator.minimumOffset",
+ "discourse.plugin-outlet-args",
+ "discourse.plugin-outlet-classic-args-clash",
+ "discourse.plugin-outlet-classic-hooks",
+ "discourse.plugin-outlet-context-get",
+ "discourse.post-stream.trigger-new-post",
+ "discourse.pretty-text.registerOption",
+ "discourse.qunit-helpers.jquery-selector",
+ "discourse.qunit-helpers.query-all",
+ "discourse.qunit.acceptance-function",
+ "discourse.qunit.global-exists",
+ "discourse.register-connector-class-legacy",
+ "discourse.register-raw-helper",
+ "discourse.register-unbound",
+ "discourse.resolver-resolutions",
+ "discourse.safari-hacks-disabled",
+ "discourse.section-link-class-arg",
+ "discourse.select-kit-resolved-components",
+ "discourse.show-popover",
+ "discourse.site.is-mobile-device",
+ "discourse.static-viewport-initialization",
+ "discourse.tag-show-controller",
+ "discourse.template-action", // removed in Ember 6.0, but we have a polyfill
+ "discourse.text.cook-async",
+ "discourse.this-container",
+ "discourse.topic-list-find",
+ "discourse.topic.totalUnread",
+ "discourse.uploads.display-error-for-upload",
+ "discourse.user-menu.panel-component-class",
+ "discourse.user.resolved-timezone",
+ "discourse.user.userOptions",
+ "discourse.utils-decorators-import",
+ "discourse.utils-decorators-observes",
+ "discourse.utils-decorators-on",
+ /^discourse\.native-array-extensions\..+$/,
+ ].map((matchId) => ({ handler: "notify-admin", matchId })),
// used in system specs
{