Skip to content

A platform for community discussion. Free, open, simple.

UX: link helpful flags from user profile staff counters (#39011)

Krisfe70d5f2918b
diff --git a/app/assets/stylesheets/common/base/user.scss b/app/assets/stylesheets/common/base/user.scss
index 36276050693..e70fa10cd40 100644
--- a/app/assets/stylesheets/common/base/user.scss
+++ b/app/assets/stylesheets/common/base/user.scss
@@ -431,12 +431,12 @@
color: var(--secondary);
display: flex;
flex-wrap: wrap;
- padding: 10px;
- margin-bottom: 16px;
- gap: var(--space-2);
+ padding: var(--space-2);
+ margin-bottom: var(--space-4);
+ gap: var(--space-3);
- > div,
- > div a {
+ a,
+ > div {
display: flex;
align-items: baseline;
flex: 0 1 auto;
@@ -444,9 +444,13 @@
color: var(--secondary);
span {
- padding: 0 7px 1px;
- border-radius: 10px;
+ display: inline-block;
+ min-width: 0.85em; // keep low counts round
+ text-align: center;
+ padding: 0.15em 0.4em;
+ border-radius: 1em;
margin-right: 5px;
+ font-size: var(--font-down-1);
}
}
diff --git a/frontend/discourse/app/templates/user.gjs b/frontend/discourse/app/templates/user.gjs
index e8641d6c66a..2c0ba0373a1 100644
--- a/frontend/discourse/app/templates/user.gjs
+++ b/frontend/discourse/app/templates/user.gjs
@@ -52,13 +52,21 @@ export default <template>
<div class="staff-counters">
{{#if @controller.model.number_of_flags_given}}
<div>
- {{trustHTML
- (i18n
- "user.staff_counters.flags_given"
- className="helpful-flags"
- [email protected]_of_flags_given
- )
- }}
+ <LinkTo
+ @route="review"
+ @query={{hash
+ status="approved"
+ }}
+ >
+ {{trustHTML
+ (i18n
+ "user.staff_counters.flags_given"
+ className="helpful-flags"
+ [email protected]_of_flags_given
+ )
+ }}
+ </LinkTo>
</div>
{{/if}}
{{#if @controller.model.number_of_flags}}
diff --git a/spec/system/page_objects/pages/user.rb b/spec/system/page_objects/pages/user.rb
index 91bcb1d2955..335a7f0590b 100644
--- a/spec/system/page_objects/pages/user.rb
+++ b/spec/system/page_objects/pages/user.rb
@@ -61,6 +61,15 @@ module PageObjects
page.has_css?(".staff-counters .flags", text: count.to_s)
end
+ def click_staff_info_flags_given_link
+ page.find(".staff-counters .helpful-flags").click
+ self
+ end
+
+ def has_staff_counter_flags_given?(count:)
+ page.has_css?(".staff-counters .helpful-flags", text: count.to_s)
+ end
+
def expand_info_panel
button = page.find("button[aria-controls='collapsed-info-panel']")
button.click if button["aria-expanded"] == "false"
diff --git a/spec/system/user_page/staff_info_spec.rb b/spec/system/user_page/staff_info_spec.rb
index 48e59485a17..ec3db2812cb 100644
--- a/spec/system/user_page/staff_info_spec.rb
+++ b/spec/system/user_page/staff_info_spec.rb
@@ -39,6 +39,27 @@ describe "Viewing user staff info as an admin" do
end
end
+ context "for flags given" do
+ fab!(:flagged_post) { Fabricate(:post, user: admin) }
+
+ before do
+ Group.refresh_automatic_groups!
+ PostActionCreator.create(user, flagged_post, :inappropriate)
+ end
+
+ it "shows count and links to review queue filtered by flagger" do
+ user_page.visit(user)
+
+ expect(user_page).to have_staff_counter_flags_given(count: 1)
+
+ user_page.click_staff_info_flags_given_link
+
+ expect(page).to have_current_path(%r{/review})
+ expect(page).to have_current_path(/flagged_by=#{user.username}/)
+ expect(page).to have_current_path(/status=approved/)
+ end
+ end
+
context "for flags" do
fab!(:reviewable_flagged_post) { Fabricate(:reviewable_flagged_post, target_created_by: user) }
fab!(:reviewable_queued_post) { Fabricate(:reviewable_queued_post, target_created_by: user) }