Skip to content

The Open Source DocuSign Alternative.

fix: ensures new expire on setSessionCookie (#2708)

Clayton Chew583e35c76857
diff --git a/packages/auth/server/lib/session/session-cookies.ts b/packages/auth/server/lib/session/session-cookies.ts
index cf2dea247..39ed9f45c 100644
--- a/packages/auth/server/lib/session/session-cookies.ts
+++ b/packages/auth/server/lib/session/session-cookies.ts
@@ -30,7 +30,6 @@ export const sessionCookieOptions = {
sameSite: useSecureCookies ? 'none' : 'lax',
secure: useSecureCookies,
domain: getCookieDomain(),
- expires: new Date(Date.now() + AUTH_SESSION_LIFETIME),
} as const;
export const extractSessionCookieFromHeaders = (headers: Headers): string | null => {
@@ -56,7 +55,10 @@ export const getSessionCookie = async (c: Context): Promise<string | null> => {
* @param sessionToken - The session token to set.
*/
export const setSessionCookie = async (c: Context, sessionToken: string) => {
- await setSignedCookie(c, sessionCookieName, sessionToken, getAuthSecret(), sessionCookieOptions).catch((err) => {
+ await setSignedCookie(c, sessionCookieName, sessionToken, getAuthSecret(), {
+ ...sessionCookieOptions,
+ expires: new Date(Date.now() + AUTH_SESSION_LIFETIME),
+ }).catch((err) => {
appLog('SetSessionCookie', `Error setting signed cookie: ${err}`);
throw err;