Skip to content

The Open Source DocuSign Alternative.

fix: dirty type safe job definitions

Mythie93ea3e264430
diff --git a/packages/lib/jobs/client.ts b/packages/lib/jobs/client.ts
index 62ff057c4..03e6a8ca1 100644
--- a/packages/lib/jobs/client.ts
+++ b/packages/lib/jobs/client.ts
@@ -7,6 +7,6 @@ import { SEND_SIGNING_EMAIL_JOB_DEFINITION } from './definitions/send-signing-em
* triggering jobs.
*/
export const jobsClient = new JobClient([
- SEND_CONFIRMATION_EMAIL_JOB_DEFINITION,
SEND_SIGNING_EMAIL_JOB_DEFINITION,
+ SEND_CONFIRMATION_EMAIL_JOB_DEFINITION,
] as const);
diff --git a/packages/lib/jobs/definitions/send-confirmation-email.ts b/packages/lib/jobs/definitions/send-confirmation-email.ts
index b5ca6e43c..09bf479ef 100644
--- a/packages/lib/jobs/definitions/send-confirmation-email.ts
+++ b/packages/lib/jobs/definitions/send-confirmation-email.ts
@@ -3,16 +3,20 @@ import { z } from 'zod';
import { sendConfirmationToken } from '../../server-only/user/send-confirmation-token';
import type { JobDefinition } from '../client/_internal/job';
+const SEND_CONFIRMATION_EMAIL_JOB_DEFINITION_ID = 'send.signup.confirmation.email';
+
+const SEND_CONFIRMATION_EMAIL_JOB_DEFINITION_SCHEMA = z.object({
+ email: z.string().email(),
+ force: z.boolean().optional(),
+});
+
export const SEND_CONFIRMATION_EMAIL_JOB_DEFINITION = {
- id: 'send.signup.confirmation.email',
+ id: SEND_CONFIRMATION_EMAIL_JOB_DEFINITION_ID,
name: 'Send Confirmation Email',
version: '1.0.0',
trigger: {
- name: 'send.signup.confirmation.email',
- schema: z.object({
- email: z.string().email(),
- force: z.boolean().optional(),
- }),
+ name: SEND_CONFIRMATION_EMAIL_JOB_DEFINITION_ID,
+ schema: SEND_CONFIRMATION_EMAIL_JOB_DEFINITION_SCHEMA,
},
handler: async ({ payload }) => {
await sendConfirmationToken({
@@ -20,4 +24,7 @@ export const SEND_CONFIRMATION_EMAIL_JOB_DEFINITION = {
force: payload.force,
});
},
-} as const satisfies JobDefinition;
+} as const satisfies JobDefinition<
+ typeof SEND_CONFIRMATION_EMAIL_JOB_DEFINITION_ID,
+ z.infer<typeof SEND_CONFIRMATION_EMAIL_JOB_DEFINITION_SCHEMA>
+>;
diff --git a/packages/lib/jobs/definitions/send-signing-email.ts b/packages/lib/jobs/definitions/send-signing-email.ts
index 88e228844..dc2c17d12 100644
--- a/packages/lib/jobs/definitions/send-signing-email.ts
+++ b/packages/lib/jobs/definitions/send-signing-email.ts
@@ -23,20 +23,24 @@ import { DOCUMENT_AUDIT_LOG_TYPE } from '../../types/document-audit-logs';
import { ZRequestMetadataSchema } from '../../universal/extract-request-metadata';
import { createDocumentAuditLogData } from '../../utils/document-audit-logs';
import { renderCustomEmailTemplate } from '../../utils/render-custom-email-template';
-import type { JobDefinition } from '../client/_internal/job';
+import { type JobDefinition } from '../client/_internal/job';
+
+const SEND_SIGNING_EMAIL_JOB_DEFINITION_ID = 'send.signing.requested.email';
+
+const SEND_SIGNING_EMAIL_JOB_DEFINITION_SCHEMA = z.object({
+ userId: z.number(),
+ documentId: z.number(),
+ recipientId: z.number(),
+ requestMetadata: ZRequestMetadataSchema.optional(),
+});
export const SEND_SIGNING_EMAIL_JOB_DEFINITION = {
- id: 'send.signing.requested.email',
+ id: SEND_SIGNING_EMAIL_JOB_DEFINITION_ID,
name: 'Send Signing Email',
version: '1.0.0',
trigger: {
- name: 'send.signing.requested.email',
- schema: z.object({
- userId: z.number(),
- documentId: z.number(),
- recipientId: z.number(),
- requestMetadata: ZRequestMetadataSchema.optional(),
- }),
+ name: SEND_SIGNING_EMAIL_JOB_DEFINITION_ID,
+ schema: SEND_SIGNING_EMAIL_JOB_DEFINITION_SCHEMA,
},
handler: async ({ payload, io }) => {
const { userId, documentId, recipientId, requestMetadata } = payload;
@@ -161,4 +165,7 @@ export const SEND_SIGNING_EMAIL_JOB_DEFINITION = {
});
});
},
-} as const satisfies JobDefinition;
+} as const satisfies JobDefinition<
+ typeof SEND_SIGNING_EMAIL_JOB_DEFINITION_ID,
+ z.infer<typeof SEND_SIGNING_EMAIL_JOB_DEFINITION_SCHEMA>
+>;