Skip to content

The Open Source DocuSign Alternative.

chore: cleanup

David Nguyenc1c7cfaf8b07
diff --git a/.github/workflows/e2e-tests.yml b/.github/workflows/e2e-tests.yml
index 4673dfca1..9d935d83f 100644
--- a/.github/workflows/e2e-tests.yml
+++ b/.github/workflows/e2e-tests.yml
@@ -1,7 +1,7 @@
name: Playwright Tests
on:
push:
- branches: ['main']
+ branches: ['main', 'feat/rr7']
pull_request:
branches: ['main']
jobs:
diff --git a/apps/remix/app/routes/_unauthenticated+/share.$slug.tsx b/apps/remix/app/routes/_unauthenticated+/share.$slug.tsx
index f45f496af..e82ab6676 100644
--- a/apps/remix/app/routes/_unauthenticated+/share.$slug.tsx
+++ b/apps/remix/app/routes/_unauthenticated+/share.$slug.tsx
@@ -4,42 +4,41 @@ import { NEXT_PUBLIC_WEBAPP_URL } from '@documenso/lib/constants/app';
import type { Route } from './+types/share.$slug';
-// Todo: (RR7) Test on stg
export function meta({ params: { slug } }: Route.MetaArgs) {
return [
{ title: 'Documenso - Share' },
{ description: 'I just signed a document in style with Documenso!' },
{
property: 'og:title',
- title: 'Documenso - Join the open source signing revolution',
+ content: 'Documenso - Join the open source signing revolution',
},
{
property: 'og:description',
- description: 'I just signed with Documenso!',
+ content: 'I just signed with Documenso!',
},
{
property: 'og:type',
- type: 'website',
+ content: 'website',
},
{
- property: 'og:images',
- images: [`${NEXT_PUBLIC_WEBAPP_URL()}/share/${slug}/opengraph`],
+ property: 'og:image',
+ content: `${NEXT_PUBLIC_WEBAPP_URL()}/share/${slug}/opengraph`,
},
{
name: 'twitter:site',
- site: '@documenso',
+ content: '@documenso',
},
{
name: 'twitter:card',
- card: 'summary_large_image',
+ content: 'summary_large_image',
},
{
- name: 'twitter:images',
- images: [`${NEXT_PUBLIC_WEBAPP_URL()}/share/${slug}/opengraph`],
+ name: 'twitter:image',
+ content: `${NEXT_PUBLIC_WEBAPP_URL()}/share/${slug}/opengraph`,
},
{
name: 'twitter:description',
- description: 'I just signed with Documenso!',
+ content: 'I just signed with Documenso!',
},
];
}
diff --git a/packages/api/hono.ts b/packages/api/hono.ts
index bd7aedee8..6f66f7bd6 100644
--- a/packages/api/hono.ts
+++ b/packages/api/hono.ts
@@ -19,7 +19,6 @@ tsRestHonoApp
.get('/me', async (c) => testCredentialsHandler(c.req.raw));
// Zapier. Todo: (RR7) Check methods. Are these get/post/update requests?
-// Todo: (RR7) Is there really no validations?
tsRestHonoApp
.all('/zapier/list-documents', async (c) => listDocumentsHandler(c.req.raw))
.all('/zapier/subscribe', async (c) => subscribeHandler(c.req.raw))
diff --git a/packages/api/v1/middleware/authenticated.ts b/packages/api/v1/middleware/authenticated.ts
index ba7fb85a5..a3129de4c 100644
--- a/packages/api/v1/middleware/authenticated.ts
+++ b/packages/api/v1/middleware/authenticated.ts
@@ -52,7 +52,7 @@ export const authenticatedMiddleware = <
}
const metadata: ApiRequestMetadata = {
- requestMetadata: extractRequestMetadata(request), // Todo: (RR7) Test
+ requestMetadata: extractRequestMetadata(request),
source: 'apiV1',
auth: 'api',
auditUser: {
diff --git a/packages/auth/server/lib/utils/handle-oauth-callback-url.ts b/packages/auth/server/lib/utils/handle-oauth-callback-url.ts
index eb8aa682d..f534c6b66 100644
--- a/packages/auth/server/lib/utils/handle-oauth-callback-url.ts
+++ b/packages/auth/server/lib/utils/handle-oauth-callback-url.ts
@@ -146,8 +146,7 @@ export const handleOAuthCallbackUrl = async (options: HandleOAuthCallbackUrlOpti
data: {
emailVerified: new Date(),
password: null,
- // Todo: (RR7) Check this
- // Todo: (RR7) Not required after we setup password specific accounts.
+ // Todo: (RR7) Will need to update the "password" account after the migration.
},
});
}
diff --git a/packages/lib/jobs/client/inngest.ts b/packages/lib/jobs/client/inngest.ts
index 0da2ed374..95f5d5a6e 100644
--- a/packages/lib/jobs/client/inngest.ts
+++ b/packages/lib/jobs/client/inngest.ts
@@ -71,28 +71,6 @@ export class InngestJobProvider extends BaseJobProvider {
});
}
- // public getApiHandler() {
- // const handler = createPagesRoute({
- // client: this._client,
- // functions: this._functions,
- // });
-
- // return async (req: NextApiRequest, res: NextApiResponse) => {
- // // Since body-parser is disabled for this route we need to patch in the parsed body
- // if (req.headers['content-type'] === 'application/json') {
- // Object.assign(req, {
- // body: await json(req),
- // });
- // }
-
- // // eslint-disable-next-line @typescript-eslint/consistent-type-assertions
- // const nextReq = req as unknown as NextRequest;
-
- // return await handler(nextReq, res);
- // };
- // }
-
- // Todo: (RR7) Do we need to handle the above?
public getApiHandler() {
return async (context: HonoContext) => {
const handler = createHonoPagesRoute({
diff --git a/packages/lib/server-only/webhooks/zapier/list-documents.ts b/packages/lib/server-only/webhooks/zapier/list-documents.ts
index f0c4380da..8835b6581 100644
--- a/packages/lib/server-only/webhooks/zapier/list-documents.ts
+++ b/packages/lib/server-only/webhooks/zapier/list-documents.ts
@@ -64,6 +64,8 @@ export const listDocumentsHandler = async (req: Request) => {
return Response.json([]);
} catch (err) {
+ console.error(err);
+
return Response.json(
{
message: 'Internal Server Error',
diff --git a/packages/lib/server-only/webhooks/zapier/subscribe.ts b/packages/lib/server-only/webhooks/zapier/subscribe.ts
index 6629b5f8c..a72ad4738 100644
--- a/packages/lib/server-only/webhooks/zapier/subscribe.ts
+++ b/packages/lib/server-only/webhooks/zapier/subscribe.ts
@@ -27,6 +27,8 @@ export const subscribeHandler = async (req: Request) => {
return Response.json(createdWebhook);
} catch (err) {
+ console.error(err);
+
return Response.json(
{
message: 'Internal Server Error',
diff --git a/packages/lib/server-only/webhooks/zapier/unsubscribe.ts b/packages/lib/server-only/webhooks/zapier/unsubscribe.ts
index 6e26a2c15..4772c164b 100644
--- a/packages/lib/server-only/webhooks/zapier/unsubscribe.ts
+++ b/packages/lib/server-only/webhooks/zapier/unsubscribe.ts
@@ -24,6 +24,8 @@ export const unsubscribeHandler = async (req: Request) => {
return Response.json(deletedWebhook);
} catch (err) {
+ console.error(err);
+
return Response.json(
{
message: 'Internal Server Error',