Skip to content

The Open Source DocuSign Alternative.

fix(i18n): mark dropdown and radio placeholder for translation (#2537)

Konradc63b4ca3cc92
diff --git a/apps/remix/app/components/forms/editor/editor-field-dropdown-form.tsx b/apps/remix/app/components/forms/editor/editor-field-dropdown-form.tsx
index df95dcd07..ed4ae9ee9 100644
--- a/apps/remix/app/components/forms/editor/editor-field-dropdown-form.tsx
+++ b/apps/remix/app/components/forms/editor/editor-field-dropdown-form.tsx
@@ -96,7 +96,7 @@ export const EditorFieldDropdownForm = ({
mode: 'onChange',
defaultValues: {
defaultValue: value.defaultValue,
- values: value.values || [{ value: 'Option 1' }],
+ values: [{ value: t`Option 1` }],
required: value.required || false,
readOnly: value.readOnly || false,
fontSize: value.fontSize || DEFAULT_FIELD_FONT_SIZE,
@@ -110,13 +110,13 @@ export const EditorFieldDropdownForm = ({
const addValue = () => {
const currentValues = form.getValues('values') || [];
- let newValue = 'New option';
+ let newValue = t`New option`;
// Iterate to create a unique value
for (let i = 0; i < currentValues.length; i++) {
- newValue = `New option ${i + 1}`;
- if (currentValues.some((item) => item.value === `New option ${i + 1}`)) {
- newValue = `New option ${i + 1}`;
+ newValue = t`New option ${i + 1}`;
+ if (currentValues.some((item) => item.value === t`New option ${i + 1}`)) {
+ newValue = t`New option ${i + 1}`;
} else {
break;
}
diff --git a/apps/remix/app/components/forms/editor/editor-field-radio-form.tsx b/apps/remix/app/components/forms/editor/editor-field-radio-form.tsx
index c2ea00716..d6d20bada 100644
--- a/apps/remix/app/components/forms/editor/editor-field-radio-form.tsx
+++ b/apps/remix/app/components/forms/editor/editor-field-radio-form.tsx
@@ -79,7 +79,7 @@ export const EditorFieldRadioForm = ({
mode: 'onChange',
defaultValues: {
label: value.label || '',
- values: value.values || [{ id: 1, checked: false, value: 'Default value' }],
+ values: value.values || [{ id: 1, checked: false, value: t`Default value` }],
required: value.required || false,
readOnly: value.readOnly || false,
direction: value.direction || 'vertical',
diff --git a/packages/ui/primitives/document-flow/field-items-advanced-settings/dropdown-field.tsx b/packages/ui/primitives/document-flow/field-items-advanced-settings/dropdown-field.tsx
index e6b78a729..da0e6f825 100644
--- a/packages/ui/primitives/document-flow/field-items-advanced-settings/dropdown-field.tsx
+++ b/packages/ui/primitives/document-flow/field-items-advanced-settings/dropdown-field.tsx
@@ -36,14 +36,14 @@ export const DropdownFieldAdvancedSettings = ({
const { _ } = useLingui();
const [showValidation, setShowValidation] = useState(false);
- const [values, setValues] = useState(fieldState.values ?? [{ value: 'Option 1' }]);
+ const [values, setValues] = useState(fieldState.values ?? [{ value: _(msg`Option 1`) }]);
const [readOnly, setReadOnly] = useState(fieldState.readOnly ?? false);
const [required, setRequired] = useState(fieldState.required ?? false);
- const [defaultValue, setDefaultValue] = useState(fieldState.defaultValue ?? 'Option 1');
+ const [defaultValue, setDefaultValue] = useState(fieldState.defaultValue ?? _(msg`Option 1`));
const addValue = () => {
- setValues([...values, { value: 'New option' }]);
- handleFieldChange('values', [...values, { value: 'New option' }]);
+ setValues([...values, { value: _(msg`New option`) }]);
+ handleFieldChange('values', [...values, { value: _(msg`New option`) }]);
};
const removeValue = (index: number) => {
@@ -90,11 +90,11 @@ export const DropdownFieldAdvancedSettings = ({
}, [values]);
useEffect(() => {
- setValues(fieldState.values ?? [{ value: 'Option 1' }]);
+ setValues(fieldState.values ?? [{ value: _(msg`Option 1`) }]);
}, [fieldState.values]);
useEffect(() => {
- setDefaultValue(fieldState.defaultValue ?? 'Option 1');
+ setDefaultValue(fieldState.defaultValue ?? _(msg`Option 1`));
}, [fieldState.defaultValue]);
return (
diff --git a/packages/ui/primitives/document-flow/field-items-advanced-settings/radio-field.tsx b/packages/ui/primitives/document-flow/field-items-advanced-settings/radio-field.tsx
index 49dc8eba7..e4bc9f073 100644
--- a/packages/ui/primitives/document-flow/field-items-advanced-settings/radio-field.tsx
+++ b/packages/ui/primitives/document-flow/field-items-advanced-settings/radio-field.tsx
@@ -31,7 +31,7 @@ export const RadioFieldAdvancedSettings = ({
const [showValidation, setShowValidation] = useState(false);
const [values, setValues] = useState(
- fieldState.values ?? [{ id: 1, checked: false, value: 'Default value' }],
+ fieldState.values ?? [{ id: 1, checked: false, value: _(msg`Default value`) }],
);
const [readOnly, setReadOnly] = useState(fieldState.readOnly ?? false);
const [required, setRequired] = useState(fieldState.required ?? false);
@@ -99,7 +99,7 @@ export const RadioFieldAdvancedSettings = ({
};
useEffect(() => {
- setValues(fieldState.values ?? [{ id: 1, checked: false, value: 'Default value' }]);
+ setValues(fieldState.values ?? [{ id: 1, checked: false, value: _(msg`Default value`) }]);
}, [fieldState.values]);
useEffect(() => {