Skip to content

The Open Source DocuSign Alternative.

fix: external id null for documents created from templates (#1362)

Ephraim Duncancd3d9b701b7b
diff --git a/packages/lib/server-only/template/create-document-from-template.ts b/packages/lib/server-only/template/create-document-from-template.ts
index 8ac36393b..8cf2e59af 100644
--- a/packages/lib/server-only/template/create-document-from-template.ts
+++ b/packages/lib/server-only/template/create-document-from-template.ts
@@ -1,8 +1,9 @@
import { nanoid } from '@documenso/lib/universal/id';
import { prisma } from '@documenso/prisma';
-import type { DocumentSigningOrder, Field } from '@documenso/prisma/client';
import {
+ DocumentSigningOrder,
DocumentSource,
+ type Field,
type Recipient,
RecipientRole,
SendStatus,
@@ -153,7 +154,7 @@ export const createDocumentFromTemplate = async ({
const document = await tx.document.create({
data: {
source: DocumentSource.TEMPLATE,
- externalId,
+ externalId: externalId || template.externalId,
templateId: template.id,
userId,
teamId: template.teamId,
@@ -172,7 +173,9 @@ export const createDocumentFromTemplate = async ({
dateFormat: override?.dateFormat || template.templateMeta?.dateFormat,
redirectUrl: override?.redirectUrl || template.templateMeta?.redirectUrl,
signingOrder:
- override?.signingOrder || template.templateMeta?.signingOrder || undefined,
+ override?.signingOrder ||
+ template.templateMeta?.signingOrder ||
+ DocumentSigningOrder.PARALLEL,
},
},
Recipient: {
diff --git a/packages/lib/server-only/template/update-template-settings.ts b/packages/lib/server-only/template/update-template-settings.ts
index aec91be4e..22ea56db2 100644
--- a/packages/lib/server-only/template/update-template-settings.ts
+++ b/packages/lib/server-only/template/update-template-settings.ts
@@ -100,7 +100,7 @@ export const updateTemplateSettings = async ({
},
data: {
title: data.title,
- externalId: data.externalId || null,
+ externalId: data.externalId,
type: data.type,
publicDescription: data.publicDescription,
publicTitle: data.publicTitle,
diff --git a/packages/trpc/server/template-router/router.ts b/packages/trpc/server/template-router/router.ts
index 265fe1916..a1a17d688 100644
--- a/packages/trpc/server/template-router/router.ts
+++ b/packages/trpc/server/template-router/router.ts
@@ -101,7 +101,7 @@ export const templateRouter = router({
.input(ZCreateDocumentFromTemplateMutationSchema)
.mutation(async ({ input, ctx }) => {
try {
- const { templateId, teamId } = input;
+ const { templateId, teamId, recipients } = input;
const limits = await getServerLimits({ email: ctx.user.email, teamId });
@@ -115,7 +115,7 @@ export const templateRouter = router({
templateId,
teamId,
userId: ctx.user.id,
- recipients: input.recipients,
+ recipients,
requestMetadata,
});