Skip to content

The Open Source DocuSign Alternative.

fix: document title truncation (#1467)

Catalin Pite6d4005cd145
diff --git a/apps/web/src/app/(dashboard)/documents/[id]/document-page-view.tsx b/apps/web/src/app/(dashboard)/documents/[id]/document-page-view.tsx
index d4b137aeb..f05d148f7 100644
--- a/apps/web/src/app/(dashboard)/documents/[id]/document-page-view.tsx
+++ b/apps/web/src/app/(dashboard)/documents/[id]/document-page-view.tsx
@@ -146,7 +146,10 @@ export const DocumentPageView = async ({ params, team }: DocumentPageViewProps)
<div className="flex flex-row justify-between truncate">
<div>
- <h1 className="mt-4 truncate text-2xl font-semibold md:text-3xl" title={document.title}>
+ <h1
+ className="mt-4 block max-w-[20rem] truncate text-2xl font-semibold md:max-w-[30rem] md:text-3xl"
+ title={document.title}
+ >
{document.title}
</h1>
diff --git a/apps/web/src/app/(dashboard)/documents/[id]/edit/document-edit-page-view.tsx b/apps/web/src/app/(dashboard)/documents/[id]/edit/document-edit-page-view.tsx
index 23357074a..531f7e439 100644
--- a/apps/web/src/app/(dashboard)/documents/[id]/edit/document-edit-page-view.tsx
+++ b/apps/web/src/app/(dashboard)/documents/[id]/edit/document-edit-page-view.tsx
@@ -109,7 +109,10 @@ export const DocumentEditPageView = async ({ params, team }: DocumentEditPageVie
<Trans>Documents</Trans>
</Link>
- <h1 className="mt-4 truncate text-2xl font-semibold md:text-3xl" title={document.title}>
+ <h1
+ className="mt-4 block max-w-[20rem] truncate text-2xl font-semibold md:max-w-[30rem] md:text-3xl"
+ title={document.title}
+ >
{document.title}
</h1>
diff --git a/apps/web/src/app/(dashboard)/documents/[id]/logs/document-logs-page-view.tsx b/apps/web/src/app/(dashboard)/documents/[id]/logs/document-logs-page-view.tsx
index 4bd852248..f681437a4 100644
--- a/apps/web/src/app/(dashboard)/documents/[id]/logs/document-logs-page-view.tsx
+++ b/apps/web/src/app/(dashboard)/documents/[id]/logs/document-logs-page-view.tsx
@@ -121,7 +121,10 @@ export const DocumentLogsPageView = async ({ params, team }: DocumentLogsPageVie
<div className="flex flex-col justify-between truncate sm:flex-row">
<div>
- <h1 className="mt-4 truncate text-2xl font-semibold md:text-3xl" title={document.title}>
+ <h1
+ className="mt-4 block max-w-[20rem] truncate text-2xl font-semibold md:max-w-[30rem] md:text-3xl"
+ title={document.title}
+ >
{document.title}
</h1>
diff --git a/apps/web/src/app/(dashboard)/templates/[id]/edit/template-edit-page-view.tsx b/apps/web/src/app/(dashboard)/templates/[id]/edit/template-edit-page-view.tsx
index d7d6d86b4..7217b6be1 100644
--- a/apps/web/src/app/(dashboard)/templates/[id]/edit/template-edit-page-view.tsx
+++ b/apps/web/src/app/(dashboard)/templates/[id]/edit/template-edit-page-view.tsx
@@ -63,7 +63,10 @@ export const TemplateEditPageView = async ({ params, team }: TemplateEditPageVie
<Trans>Template</Trans>
</Link>
- <h1 className="mt-4 truncate text-2xl font-semibold md:text-3xl" title={template.title}>
+ <h1
+ className="mt-4 block max-w-[20rem] truncate text-2xl font-semibold md:max-w-[30rem] md:text-3xl"
+ title={template.title}
+ >
{template.title}
</h1>
diff --git a/apps/web/src/app/(dashboard)/templates/[id]/template-page-view.tsx b/apps/web/src/app/(dashboard)/templates/[id]/template-page-view.tsx
index ba011b2f3..f27688816 100644
--- a/apps/web/src/app/(dashboard)/templates/[id]/template-page-view.tsx
+++ b/apps/web/src/app/(dashboard)/templates/[id]/template-page-view.tsx
@@ -88,7 +88,10 @@ export const TemplatePageView = async ({ params, team }: TemplatePageViewProps)
<div className="flex flex-row justify-between truncate">
<div>
- <h1 className="mt-4 truncate text-2xl font-semibold md:text-3xl" title={template.title}>
+ <h1
+ className="mt-4 block max-w-[20rem] truncate text-2xl font-semibold md:max-w-[30rem] md:text-3xl"
+ title={template.title}
+ >
{template.title}
</h1>
diff --git a/apps/web/src/app/(recipient)/d/[token]/page.tsx b/apps/web/src/app/(recipient)/d/[token]/page.tsx
index a2ace350c..dfbbd4595 100644
--- a/apps/web/src/app/(recipient)/d/[token]/page.tsx
+++ b/apps/web/src/app/(recipient)/d/[token]/page.tsx
@@ -12,7 +12,6 @@ import { extractDocumentAuthMethods } from '@documenso/lib/utils/document-auth';
import { DocumentAuthProvider } from '~/app/(signing)/sign/[token]/document-auth-provider';
import { SigningProvider } from '~/app/(signing)/sign/[token]/provider';
-import { truncateTitle } from '~/helpers/truncate-title';
import { DirectTemplatePageView } from './direct-template';
import { DirectTemplateAuthPageView } from './signing-auth-page';
@@ -72,8 +71,11 @@ export default async function TemplatesDirectPage({ params }: TemplatesDirectPag
user={user}
>
<div className="mx-auto -mt-4 w-full max-w-screen-xl px-4 md:px-8">
- <h1 className="mt-4 truncate text-2xl font-semibold md:text-3xl" title={template.title}>
- {truncateTitle(template.title)}
+ <h1
+ className="mt-4 block max-w-[20rem] truncate text-2xl font-semibold md:max-w-[30rem] md:text-3xl"
+ title={template.title}
+ >
+ {template.title}
</h1>
<div className="text-muted-foreground mb-8 mt-2.5 flex items-center gap-x-2">
diff --git a/apps/web/src/app/(signing)/sign/[token]/complete/page.tsx b/apps/web/src/app/(signing)/sign/[token]/complete/page.tsx
index 7e183da1d..b1ca1c9c6 100644
--- a/apps/web/src/app/(signing)/sign/[token]/complete/page.tsx
+++ b/apps/web/src/app/(signing)/sign/[token]/complete/page.tsx
@@ -24,8 +24,6 @@ import { SigningCard3D } from '@documenso/ui/components/signing-card';
import { cn } from '@documenso/ui/lib/utils';
import { Badge } from '@documenso/ui/primitives/badge';
-import { truncateTitle } from '~/helpers/truncate-title';
-
import { SigningAuthPageView } from '../signing-auth-page';
import { ClaimAccount } from './claim-account';
import { DocumentPreviewButton } from './document-preview-button';
@@ -61,8 +59,6 @@ export default async function CompletedSigningPage({
return notFound();
}
- const truncatedTitle = truncateTitle(document.title);
-
const { documentData } = document;
const [fields, recipient] = await Promise.all([
@@ -118,7 +114,9 @@ export default async function CompletedSigningPage({
})}
>
<Badge variant="neutral" size="default" className="mb-6 rounded-xl border bg-transparent">
- {truncatedTitle}
+ <span className="block max-w-[10rem] truncate font-medium hover:underline md:max-w-[20rem]">
+ {document.title}
+ </span>
</Badge>
{/* Card with recipient */}
diff --git a/apps/web/src/app/(signing)/sign/[token]/sign-dialog.tsx b/apps/web/src/app/(signing)/sign/[token]/sign-dialog.tsx
index 09e97b7c4..a3a396a04 100644
--- a/apps/web/src/app/(signing)/sign/[token]/sign-dialog.tsx
+++ b/apps/web/src/app/(signing)/sign/[token]/sign-dialog.tsx
@@ -14,7 +14,6 @@ import {
} from '@documenso/ui/primitives/dialog';
import { SigningDisclosure } from '~/components/general/signing-disclosure';
-import { truncateTitle } from '~/helpers/truncate-title';
export type SignDialogProps = {
isSubmitting: boolean;
@@ -36,7 +35,7 @@ export const SignDialog = ({
disabled = false,
}: SignDialogProps) => {
const [showDialog, setShowDialog] = useState(false);
- const truncatedTitle = truncateTitle(documentTitle);
+
const isComplete = fields.every((field) => field.inserted);
const handleOpenChange = (open: boolean) => {
@@ -75,7 +74,13 @@ export const SignDialog = ({
{role === RecipientRole.VIEWER && (
<span>
<Trans>
- You are about to complete viewing "{truncatedTitle}".
+ <span className="inline-flex flex-wrap">
+ You are about to complete viewing "
+ <span className="inline-block max-w-[11rem] truncate align-baseline">
+ {documentTitle}
+ </span>
+ ".
+ </span>
<br /> Are you sure?
</Trans>
</span>
@@ -83,7 +88,13 @@ export const SignDialog = ({
{role === RecipientRole.SIGNER && (
<span>
<Trans>
- You are about to complete signing "{truncatedTitle}".
+ <span className="inline-flex flex-wrap">
+ You are about to complete signing "
+ <span className="inline-block max-w-[11rem] truncate align-baseline">
+ {documentTitle}
+ </span>
+ ".
+ </span>
<br /> Are you sure?
</Trans>
</span>
@@ -91,7 +102,13 @@ export const SignDialog = ({
{role === RecipientRole.APPROVER && (
<span>
<Trans>
- You are about to complete approving "{truncatedTitle}".
+ <span className="inline-flex flex-wrap">
+ You are about to complete approving{' '}
+ <span className="inline-block max-w-[11rem] truncate align-baseline">
+ "{documentTitle}"
+ </span>
+ .
+ </span>
<br /> Are you sure?
</Trans>
</span>
diff --git a/apps/web/src/app/(signing)/sign/[token]/signing-page-view.tsx b/apps/web/src/app/(signing)/sign/[token]/signing-page-view.tsx
index 16242381a..19057abf8 100644
--- a/apps/web/src/app/(signing)/sign/[token]/signing-page-view.tsx
+++ b/apps/web/src/app/(signing)/sign/[token]/signing-page-view.tsx
@@ -55,7 +55,10 @@ export const SigningPageView = ({
return (
<div className="mx-auto w-full max-w-screen-xl">
- <h1 className="mt-4 truncate text-2xl font-semibold md:text-3xl" title={document.title}>
+ <h1
+ className="mt-4 block max-w-[20rem] truncate text-2xl font-semibold md:max-w-[30rem] md:text-3xl"
+ title={document.title}
+ >
{document.title}
</h1>