Skip to content

Full Toolkit for Next-Level Domain Analysis

Fix isValidDomain throwing on invalid input ✅

Felix Wotschofsky6d0965adf64f
diff --git a/lib/utils.test.ts b/lib/utils.test.ts
index e6fdec7..c047976 100644
--- a/lib/utils.test.ts
+++ b/lib/utils.test.ts
@@ -81,6 +81,17 @@ describe('retry', () => {
});
describe('isValidDomain', () => {
+ it('filters non-strings', () => {
+ // @ts-expect-error Testing invalid input
+ expect(isValidDomain(null)).toBe(false);
+ // @ts-expect-error Testing invalid input
+ expect(isValidDomain(undefined)).toBe(false);
+ // @ts-expect-error Testing invalid input
+ expect(isValidDomain(123)).toBe(false);
+ // @ts-expect-error Testing invalid input
+ expect(isValidDomain({})).toBe(false);
+ });
+
it('validates typical domains', () => {
expect(isValidDomain('example.com')).toBe(true);
expect(isValidDomain('subdomain.example.com')).toBe(true);
@@ -94,6 +105,7 @@ describe('isValidDomain', () => {
});
it('rejects invalid domains', () => {
+ expect(isValidDomain('')).toBe(false);
expect(isValidDomain('-example.com')).toBe(false); // Starts with a hyphen
expect(isValidDomain('.com')).toBe(false); // No domain name
expect(isValidDomain('test.bad')).toBe(false); // Invalid TLD
diff --git a/lib/utils.ts b/lib/utils.ts
index 6bd03c2..efee47f 100644
--- a/lib/utils.ts
+++ b/lib/utils.ts
@@ -17,6 +17,13 @@ export const retry = <T extends Function>(fn: T, maxRetries: number) =>
});
export const isValidDomain = (domain: string) => {
+ if (typeof domain !== 'string') {
+ if (process?.env.VITEST !== 'true') {
+ console.warn('isValidDomain expects a string input, received', domain);
+ }
+ return false;
+ }
+
// TODO Integrate hyphen check into regex
const regexResult =
/^(\*\.)?(((?!-))(xn--|_)?[a-z0-9-]{0,61}[a-z0-9]{1,1}\.)*(xn--)?([a-z0-9][a-z0-9\-]{0,60}|[a-z0-9-]{1,30}\.[a-z]{2,})$/.test(