Skip to content

Full Toolkit for Next-Level Domain Analysis

Extract deduplicate utility function 🤝

Felix Wotschofsky9575a8324faf
diff --git a/lib/subdomains.ts b/lib/subdomains.ts
index 8dd1176..b18d323 100644
--- a/lib/subdomains.ts
+++ b/lib/subdomains.ts
@@ -1,6 +1,6 @@
import { lookupCerts } from './certs';
import type { DnsResolver } from './resolvers/base';
-import { isValidDomain } from './utils';
+import { deduplicate, isValidDomain } from './utils';
const RESULTS_LIMIT = 500;
@@ -12,9 +12,7 @@ export const findSubdomains = async (domain: string, resolver: DnsResolver) => {
domains: [cert.common_name, ...cert.name_value.split(/\n/g)],
}));
- const uniqueDomains = Array.from(
- new Set<string>(issuedCerts.flatMap((r) => r.domains))
- )
+ const uniqueDomains = deduplicate(issuedCerts.flatMap((r) => r.domains))
.filter(isValidDomain)
.filter((d) => d.endsWith(`.${domain}`));
diff --git a/lib/utils.test.ts b/lib/utils.test.ts
index bc207d9..e6fdec7 100644
--- a/lib/utils.test.ts
+++ b/lib/utils.test.ts
@@ -8,7 +8,28 @@ import {
vi,
} from 'vitest';
-import { isAppleDevice, isValidDomain, retry } from './utils';
+import { deduplicate, isAppleDevice, isValidDomain, retry } from './utils';
+
+describe('deduplicate', () => {
+ it('removes duplicate numbers from an array', () => {
+ expect(deduplicate([1, 2, 2, 3])).toEqual([1, 2, 3]);
+ });
+
+ it('removes duplicate strings from an array', () => {
+ expect(deduplicate(['a', 'b', 'b', 'c'])).toEqual(['a', 'b', 'c']);
+ });
+
+ it('handles arrays of objects based on strict equality', () => {
+ const obj1 = { id: 1 };
+ const obj2 = { id: 2 };
+ // These are two different references, so both should remain
+ expect(deduplicate([obj1, obj2, obj1])).toEqual([obj1, obj2]);
+ });
+
+ it('returns an empty array when given an empty array', () => {
+ expect(deduplicate([])).toEqual([]);
+ });
+});
describe('retry', () => {
let warnSpy: MockInstance;
diff --git a/lib/utils.ts b/lib/utils.ts
index a585cbb..6bd03c2 100644
--- a/lib/utils.ts
+++ b/lib/utils.ts
@@ -4,6 +4,8 @@ import { parse as tldtsParse } from 'tldts';
export const cn = (...inputs: ClassValue[]) => twMerge(clsx(inputs));
+export const deduplicate = <T>(array: T[]): T[] => Array.from(new Set(array));
+
// From https://stackoverflow.com/a/30471209/12475254
export const retry = <T extends Function>(fn: T, maxRetries: number) =>
fn().catch((err: Error) => {