Skip to content

Python tool for aircraft Doppler audio geolocation using historical ADS-B flight data (Source-available)

Validate no-fit score ceilings before rejection bounds

Cinna Daviscb970a521c73
diff --git a/src/dopplergeist/finite_search.py b/src/dopplergeist/finite_search.py
index 680cf5e..739f022 100644
--- a/src/dopplergeist/finite_search.py
+++ b/src/dopplergeist/finite_search.py
@@ -81,14 +81,15 @@ def bounded_assessment(row):
if not 0 < unknown == bounded or rejected > bounded:
return False
upper = assessment.get("unknown_score_upper_bound")
- if rejected == bounded:
- return upper is None
if assessment["unknown_score_bound_method"] == "group_count_ceiling":
# This method skips every fit, so only the trivial per-group ceiling is valid.
return (row.get("score") is None
and assessment["evaluated_trials"] == 0 and assessment["rejected_trials"] == 0
and unknown == scheduled and assessment["bounded_unknown_rejections"] == 0
- and upper == len(indices))
+ and isinstance(upper, (int, float)) and not isinstance(upper, bool)
+ and math.isfinite(upper) and upper == len(indices))
+ if rejected == bounded:
+ return upper is None
return (isinstance(upper, (int, float)) and not isinstance(upper, bool)
and math.isfinite(upper) and 0 <= upper <= len(indices))
diff --git a/tests/test_real_score_ceiling_validation.py b/tests/test_real_score_ceiling_validation.py
new file mode 100644
index 0000000..53918b5
--- /dev/null
+++ b/tests/test_real_score_ceiling_validation.py
@@ -0,0 +1,38 @@
+"""Validate bound records produced from actual audio and flight candidates."""
+import copy
+import json
+import os
+from pathlib import Path
+from types import SimpleNamespace
+
+import pandas as pd
+import pytest
+
+from dopplergeist.finite_search import bounded_assessment
+from dopplergeist.matching import association_candidates, prepare_events
+from dopplergeist.search import score_candidate
+
+
+def test_real_score_ceiling_rejects_malformed_support_claims():
+ source = os.environ.get("DOPPLERGEIST_REAL_CPA_FIXTURE")
+ if not source:
+ pytest.skip("set DOPPLERGEIST_REAL_CPA_FIXTURE to the real reference diagnostic")
+ fixture = json.loads(Path(source).read_text())
+ events, measurements = prepare_events(fixture["events"])
+ candidates, _ = association_candidates(pd.DataFrame(fixture["cpa_rows"]), events, max_candidates=20000)
+ singleton = next(candidate for candidate in candidates if len(candidate["event_indices"]) == 1)
+ point = SimpleNamespace(**fixture["point"], x=0.0, y=0.0)
+ row = score_candidate(singleton, point, {}, events, measurements, mode="robust_ridge", score_floor=2.0)
+ assert bounded_assessment(row)
+
+ # A no-fit ceiling cannot certify that unknown trials are rejections.
+ malformed = copy.deepcopy(row)
+ assessment = malformed["scoring_assessment"]
+ assessment["bounded_unknown_rejections"] = assessment["bounded_unknown_trials"]
+ assessment["unknown_score_upper_bound"] = None
+ assert not bounded_assessment(malformed)
+
+ # bool compares equal to one in Python but is not a numeric score ceiling.
+ malformed = copy.deepcopy(row)
+ malformed["scoring_assessment"]["unknown_score_upper_bound"] = True
+ assert not bounded_assessment(malformed)