Skip to content

Free, simple, and intuitive online database diagram editor and SQL generator.

Remove panning from undo stack (#483)

Karen Mkrtumyan14ee753d477a
diff --git a/src/components/EditorCanvas/Canvas.jsx b/src/components/EditorCanvas/Canvas.jsx
index 4724ac5e..ca26b51e 100644
--- a/src/components/EditorCanvas/Canvas.jsx
+++ b/src/components/EditorCanvas/Canvas.jsx
@@ -23,12 +23,13 @@ import {
useAreas,
useNotes,
useLayout,
+ useSaveState,
} from "../../hooks";
import { useTranslation } from "react-i18next";
import { useEventListener } from "usehooks-ts";
import { areFieldsCompatible } from "../../utils/utils";
import { getRectFromEndpoints, isInsideRect } from "../../utils/rect";
-import { noteWidth } from "../../data/constants";
+import { noteWidth, State } from "../../data/constants";
export default function Canvas() {
const { t } = useTranslation();
@@ -42,6 +43,7 @@ export default function Canvas() {
const { tables, updateTable, relationships, addRelationship, database } =
useDiagram();
+ const { setSaveState } = useSaveState();
const { areas, updateArea } = useAreas();
const { notes, updateNote } = useNotes();
const { layout } = useLayout();
@@ -540,19 +542,7 @@ export default function Canvas() {
}
if (panning.isPanning && didPan()) {
- setUndoStack((prev) => [
- ...prev,
- {
- action: Action.PAN,
- undo: { x: panning.panStart.x, y: panning.panStart.y },
- redo: transform.pan,
- message: t("move_element", {
- coords: `(${transform?.pan.x}, ${transform?.pan.y})`,
- name: "diagram",
- }),
- },
- ]);
- setRedoStack([]);
+ setSaveState(State.SAVING);
setSelectedElement((prev) => ({
...prev,
element: ObjectType.NONE,
diff --git a/src/components/EditorHeader/ControlPanel.jsx b/src/components/EditorHeader/ControlPanel.jsx
index 955fe54a..2c50c976 100644
--- a/src/components/EditorHeader/ControlPanel.jsx
+++ b/src/components/EditorHeader/ControlPanel.jsx
@@ -297,12 +297,6 @@ export default function ControlPanel({
}
}
setRedoStack((prev) => [...prev, a]);
- } else if (a.action === Action.PAN) {
- setTransform((prev) => ({
- ...prev,
- pan: a.undo,
- }));
- setRedoStack((prev) => [...prev, a]);
}
};
@@ -477,12 +471,6 @@ export default function ControlPanel({
}
}
setUndoStack((prev) => [...prev, a]);
- } else if (a.action === Action.PAN) {
- setTransform((prev) => ({
- ...prev,
- pan: a.redo,
- }));
- setUndoStack((prev) => [...prev, a]);
}
};
diff --git a/src/data/constants.js b/src/data/constants.js
index 72e64f85..4f58a314 100644
--- a/src/data/constants.js
+++ b/src/data/constants.js
@@ -59,7 +59,6 @@ export const Action = {
MOVE: 1,
DELETE: 2,
EDIT: 3,
- PAN: 4,
};
export const State = {