Skip to content

Free, simple, and intuitive online database diagram editor and SQL generator.

Fix getting the correct version to compare to (#851)

1ilit19140d28d584
diff --git a/src/components/EditorHeader/SideSheet/Versions.jsx b/src/components/EditorHeader/SideSheet/Versions.jsx
index 6f93adf5..cd0cd0dd 100644
--- a/src/components/EditorHeader/SideSheet/Versions.jsx
+++ b/src/components/EditorHeader/SideSheet/Versions.jsx
@@ -229,19 +229,24 @@ export default function Versions({ open, title, setTitle }) {
const getVersionToCompareTo = useCallback(async () => {
if (!selectedVersion) return null;
+
const currentIndex = versions.findIndex(
(v) => v.version === selectedVersion,
);
if (currentIndex === -1) return null;
- if (currentIndex === versions.length - 1) {
+ if (currentIndex === versions.length - 1 && hasMore) {
const res = await getCommitsWithFile(gistId, VERSION_FILENAME, 1, cursor);
+ const version = res.data.length ? res.data[0].version : "null";
+
+ if (version === selectedVersion) return null;
- return res.data.length ? res.data[0].version : null;
+ return version;
+ } else {
+ return versions[currentIndex + 1]?.version || "null";
}
- return versions[currentIndex + 1].version;
- }, [selectedVersion, versions, gistId, cursor]);
+ }, [selectedVersion, versions, gistId, cursor, hasMore]);
useEffect(() => {
const getVersionToCompare = async () => {