Skip to content

Free, simple, and intuitive online database diagram editor and SQL generator.

fix: release pointer capture when using `onPointerLeave` events

Felix Zedén Yverås3659ba914345
diff --git a/src/components/EditorCanvas/Note.jsx b/src/components/EditorCanvas/Note.jsx
index 381682e8..cff89ba8 100644
--- a/src/components/EditorCanvas/Note.jsx
+++ b/src/components/EditorCanvas/Note.jsx
@@ -85,6 +85,11 @@ export default function Note({ data, onPointerDown }) {
<g
onPointerEnter={(e) => e.isPrimary && setHovered(true)}
onPointerLeave={(e) => e.isPrimary && setHovered(false)}
+ onPointerDown={(e) => {
+ // Required for onPointerLeave to trigger when a touch pointer leaves
+ // https://stackoverflow.com/a/70976017/1137077
+ e.target.releasePointerCapture(e.pointerId);
+ }}
>
<path
d={`M${data.x + fold} ${data.y} L${data.x + w - r} ${
diff --git a/src/components/EditorCanvas/Table.jsx b/src/components/EditorCanvas/Table.jsx
index 3dfd84fc..20936502 100644
--- a/src/components/EditorCanvas/Table.jsx
+++ b/src/components/EditorCanvas/Table.jsx
@@ -280,6 +280,11 @@ export default function Table(props) {
setHoveredField(-1);
}}
+ onPointerDown={(e) => {
+ // Required for onPointerLeave to trigger when a touch pointer leaves
+ // https://stackoverflow.com/a/70976017/1137077
+ e.target.releasePointerCapture(e.pointerId);
+ }}
>
<div
className={`${
diff --git a/src/components/EditorHeader/ControlPanel.jsx b/src/components/EditorHeader/ControlPanel.jsx
index c234e3e5..2cc81aa6 100644
--- a/src/components/EditorHeader/ControlPanel.jsx
+++ b/src/components/EditorHeader/ControlPanel.jsx
@@ -1540,6 +1540,11 @@ export default function ControlPanel({
className="text-xl me-1"
onPointerEnter={(e) => e.isPrimary && setShowEditName(true)}
onPointerLeave={(e) => e.isPrimary && setShowEditName(false)}
+ onPointerDown={(e) => {
+ // Required for onPointerLeave to trigger when a touch pointer leaves
+ // https://stackoverflow.com/a/70976017/1137077
+ e.target.releasePointerCapture(e.pointerId);
+ }}
onClick={() => setModal(MODAL.RENAME)}
>
{window.name.split(" ")[0] === "t" ? "Templates/" : "Diagrams/"}
diff --git a/src/components/SimpleCanvas.jsx b/src/components/SimpleCanvas.jsx
index 91a4be8b..a2742559 100644
--- a/src/components/SimpleCanvas.jsx
+++ b/src/components/SimpleCanvas.jsx
@@ -24,7 +24,15 @@ function Table({ table, grab }) {
width={tableWidth}
height={height}
className="drop-shadow-lg rounded-md cursor-move"
- onPointerDown={(e) => e.isPrimary && grab(e)}
+ onPointerDown={(e) => {
+ // Required for onPointerLeave to trigger when a touch pointer leaves
+ // https://stackoverflow.com/a/70976017/1137077
+ e.target.releasePointerCapture(e.pointerId);
+
+ if (!e.isPrimary) return;
+
+ grab(e);
+ }}
onPointerEnter={(e) => e.isPrimary && setIsHovered(true)}
onPointerLeave={(e) => e.isPrimary && setIsHovered(false)}
>
@@ -48,6 +56,11 @@ function Table({ table, grab }) {
} h-[36px] px-2 py-1 flex justify-between`}
onPointerEnter={(e) => e.isPrimary && setHoveredField(i)}
onPointerLeave={(e) => e.isPrimary && setHoveredField(-1)}
+ onPointerDown={(e) => {
+ // Required for onPointerLeave to trigger when a touch pointer leaves
+ // https://stackoverflow.com/a/70976017/1137077
+ e.target.releasePointerCapture(e.pointerId);
+ }}
>
<div className={hoveredField === i ? "text-zinc-500" : ""}>
<button
diff --git a/src/components/Workspace.jsx b/src/components/Workspace.jsx
index fc16187a..6546ec85 100644
--- a/src/components/Workspace.jsx
+++ b/src/components/Workspace.jsx
@@ -352,6 +352,11 @@ export default function WorkSpace() {
onPointerUp={(e) => e.isPrimary && setResize(false)}
onPointerLeave={(e) => e.isPrimary && setResize(false)}
onPointerMove={(e) => e.isPrimary && handleResize(e)}
+ onPointerDown={(e) => {
+ // Required for onPointerLeave to trigger when a touch pointer leaves
+ // https://stackoverflow.com/a/70976017/1137077
+ e.target.releasePointerCapture(e.pointerId);
+ }}
>
{layout.sidebar && (
<SidePanel resize={resize} setResize={setResize} width={width} />