Skip to content

Free, simple, and intuitive online database diagram editor and SQL generator.

Disable keepDOM in tabs and collapses (#335)

1ilit40ef1ca91ba0
diff --git a/src/components/EditorSidePanel/Issues.jsx b/src/components/EditorSidePanel/Issues.jsx
index 3e9cc901..f3de9a30 100644
--- a/src/components/EditorSidePanel/Issues.jsx
+++ b/src/components/EditorSidePanel/Issues.jsx
@@ -32,7 +32,7 @@ export default function Issues() {
}, [tables, relationships, issues, types, database, enums]);
return (
- <Collapse keepDOM lazyRender style={{ width: "100%" }}>
+ <Collapse lazyRender keepDOM={false} style={{ width: "100%" }}>
<Collapse.Panel
header={
<Badge
diff --git a/src/components/EditorSidePanel/NotesTab/NotesTab.jsx b/src/components/EditorSidePanel/NotesTab/NotesTab.jsx
index 1473d264..07b68600 100644
--- a/src/components/EditorSidePanel/NotesTab/NotesTab.jsx
+++ b/src/components/EditorSidePanel/NotesTab/NotesTab.jsx
@@ -33,7 +33,7 @@ export default function NotesTab() {
) : (
<Collapse
activeKey={selectedElement.open ? `${selectedElement.id}` : ""}
- keepDOM
+ keepDOM={false}
lazyRender
onChange={(activeKey) => {
setSelectedElement((prev) => ({
diff --git a/src/components/EditorSidePanel/RelationshipsTab/RelationshipsTab.jsx b/src/components/EditorSidePanel/RelationshipsTab/RelationshipsTab.jsx
index e492a967..ac2a058d 100644
--- a/src/components/EditorSidePanel/RelationshipsTab/RelationshipsTab.jsx
+++ b/src/components/EditorSidePanel/RelationshipsTab/RelationshipsTab.jsx
@@ -27,7 +27,7 @@ export default function RelationshipsTab() {
? `${selectedElement.id}`
: ""
}
- keepDOM
+ keepDOM={false}
lazyRender
onChange={(k) =>
setSelectedElement((prev) => ({
diff --git a/src/components/EditorSidePanel/SidePanel.jsx b/src/components/EditorSidePanel/SidePanel.jsx
index 75f3600d..01689409 100644
--- a/src/components/EditorSidePanel/SidePanel.jsx
+++ b/src/components/EditorSidePanel/SidePanel.jsx
@@ -62,6 +62,7 @@ export default function SidePanel({ width, resize, setResize }) {
type="card"
activeKey={selectedElement.currentTab}
lazyRender
+ keepDOM={false}
onChange={(key) =>
setSelectedElement((prev) => ({ ...prev, currentTab: key }))
}
diff --git a/src/components/EditorSidePanel/TablesTab/TableInfo.jsx b/src/components/EditorSidePanel/TablesTab/TableInfo.jsx
index 659669e5..9b0efb1a 100644
--- a/src/components/EditorSidePanel/TablesTab/TableInfo.jsx
+++ b/src/components/EditorSidePanel/TablesTab/TableInfo.jsx
@@ -160,7 +160,7 @@ export default function TableInfo({ data }) {
>
<Collapse
activeKey={indexActiveKey}
- keepDOM
+ keepDOM={false}
lazyRender
onChange={(itemKey) => setIndexActiveKey(itemKey)}
accordion
@@ -187,7 +187,7 @@ export default function TableInfo({ data }) {
style={{ marginTop: "12px", marginBottom: "12px" }}
headerLine={false}
>
- <Collapse keepDOM lazyRender>
+ <Collapse keepDOM={false} lazyRender>
<Collapse.Panel header={t("comment")} itemKey="1">
<TextArea
field="comment"
diff --git a/src/components/EditorSidePanel/TablesTab/TablesTab.jsx b/src/components/EditorSidePanel/TablesTab/TablesTab.jsx
index 2f1ea91d..774d65dd 100644
--- a/src/components/EditorSidePanel/TablesTab/TablesTab.jsx
+++ b/src/components/EditorSidePanel/TablesTab/TablesTab.jsx
@@ -31,7 +31,7 @@ export default function TablesTab() {
? `${selectedElement.id}`
: ""
}
- keepDOM
+ keepDOM={false}
lazyRender
onChange={(k) =>
setSelectedElement((prev) => ({
diff --git a/src/components/EditorSidePanel/TypesTab/TypeInfo.jsx b/src/components/EditorSidePanel/TypesTab/TypeInfo.jsx
index 2c2c5563..91bfb825 100644
--- a/src/components/EditorSidePanel/TypesTab/TypeInfo.jsx
+++ b/src/components/EditorSidePanel/TypesTab/TypeInfo.jsx
@@ -89,7 +89,7 @@ export default function TypeInfo({ index, data }) {
style={{ marginTop: "12px", marginBottom: "12px" }}
headerLine={false}
>
- <Collapse keepDOM lazyRender>
+ <Collapse lazyRender keepDOM={false}>
<Collapse.Panel header={t("comment")} itemKey="1">
<TextArea
field="comment"
diff --git a/src/components/EditorSidePanel/TypesTab/TypesTab.jsx b/src/components/EditorSidePanel/TypesTab/TypesTab.jsx
index 6d13c6cb..80b85196 100644
--- a/src/components/EditorSidePanel/TypesTab/TypesTab.jsx
+++ b/src/components/EditorSidePanel/TypesTab/TypesTab.jsx
@@ -49,7 +49,7 @@ export default function TypesTab() {
? `${selectedElement.id}`
: ""
}
- keepDOM
+ keepDOM={false}
lazyRender
onChange={(id) =>
setSelectedElement((prev) => ({