Skip to content

Free, simple, and intuitive online database diagram editor and SQL generator.

Handle issues in the diagram

1ilit794ecdba0819
diff --git a/src/components/issues.jsx b/src/components/issues.jsx
index e76fddfe..6033e9de 100644
--- a/src/components/issues.jsx
+++ b/src/components/issues.jsx
@@ -1,9 +1,28 @@
-import React, { useContext } from "react";
+import React, { useContext, useState, useEffect } from "react";
import { Collapse } from "@douyinfe/semi-ui";
-import { SettingsContext } from "../pages/editor";
+import { SettingsContext, TableContext } from "../pages/editor";
+import { validateDiagram, arrayIsEqual } from "../utils";
export default function Issues() {
const { settings } = useContext(SettingsContext);
+ const { tables, relationships } = useContext(TableContext);
+ const [issues, setIssues] = useState([]);
+
+ useEffect(() => {
+ const findIssues = async () => {
+ const newIssues = validateDiagram({
+ tables: tables,
+ relationships: relationships,
+ });
+
+ if (!arrayIsEqual(newIssues, issues)) {
+ setIssues(newIssues);
+ }
+ };
+
+ findIssues();
+ }, [tables, relationships, issues]);
+
return (
<Collapse style={{ width: "100%" }}>
<Collapse.Panel
@@ -22,12 +41,11 @@ export default function Issues() {
</div>
) : (
<div>
- <div className="py-2">Issue 1</div>
- <div className="py-2">Issue 2</div>
- <div className="py-2">Issue 3</div>
- <div className="py-2">Issue 4</div>
- <div className="py-2">Issue 5</div>
- <div className="py-2">Issue 6</div>
+ {issues.map((e, i) => (
+ <div key={i} className="py-2">
+ {e}
+ </div>
+ ))}
</div>
)}
</div>
diff --git a/src/utils/index.js b/src/utils/index.js
index c513c898..c44debcb 100644
--- a/src/utils/index.js
+++ b/src/utils/index.js
@@ -111,6 +111,51 @@ function jsonToSQL(obj) {
.join("\n")}`;
}
+function arrayIsEqual(arr1, arr2) {
+ return JSON.stringify(arr1) === JSON.stringify(arr2);
+}
+
+function validateDiagram(diagram) {
+ const issues = [];
+ const duplicateTableNames = {};
+
+ diagram.tables.forEach((table) => {
+ if (duplicateTableNames[table.name]) {
+ issues.push(`Duplicate table name: "${table.name}"`);
+ } else {
+ duplicateTableNames[table.name] = true;
+ }
+ });
+
+ const visitedTables = new Set();
+
+ function checkCircularRelationships(tableId, visited = []) {
+ if (visited.includes(tableId)) {
+ issues.push(
+ `Circular relationship involving table: "${diagram.tables[tableId].name}"`
+ );
+ return;
+ }
+
+ visited.push(tableId);
+ visitedTables.add(tableId);
+
+ diagram.relationships.forEach((relationship) => {
+ if (relationship.startTableId === tableId) {
+ checkCircularRelationships(relationship.endTableId, [...visited]);
+ }
+ });
+ }
+
+ diagram.tables.forEach((table) => {
+ if (!visitedTables.has(table.id)) {
+ checkCircularRelationships(table.id);
+ }
+ });
+
+ return issues;
+}
+
export {
enterFullscreen,
exitFullscreen,
@@ -118,4 +163,6 @@ export {
ddbDiagramIsValid,
dataURItoBlob,
jsonToSQL,
+ validateDiagram,
+ arrayIsEqual,
};