Skip to content

armgit / dspy

Public Imported from GitHub
0

DSPy: The framework for programming—not prompting—language models

Python

FIX: streamify was appending StatusStreamingCallback directly to the shared settings.callbacks list (#9073)

Gabriel Lesperance7fffca1f945c
diff --git a/dspy/streaming/streamify.py b/dspy/streaming/streamify.py
index 9cfec34d4..4d935308a 100644
--- a/dspy/streaming/streamify.py
+++ b/dspy/streaming/streamify.py
@@ -161,7 +161,7 @@ def streamify(
elif not iscoroutinefunction(program):
program = asyncify(program)
- callbacks = settings.callbacks
+ callbacks = list(settings.callbacks)
status_streaming_callback = StatusStreamingCallback(status_message_provider)
if not any(isinstance(c, StatusStreamingCallback) for c in callbacks):
callbacks.append(status_streaming_callback)
diff --git a/tests/streaming/test_streaming.py b/tests/streaming/test_streaming.py
index 08946a761..8c1e51ef6 100644
--- a/tests/streaming/test_streaming.py
+++ b/tests/streaming/test_streaming.py
@@ -135,6 +135,90 @@ async def test_custom_status_streaming():
assert status_messages[2].message == "Predict starting!"
+async def test_concurrent_status_message_providers():
+ class MyProgram(dspy.Module):
+ def __init__(self):
+ self.generate_question = dspy.Tool(lambda x: f"What color is the {x}?", name="generate_question")
+ self.predict = dspy.Predict("question->answer")
+
+ def __call__(self, x: str):
+ question = self.generate_question(x=x)
+ return self.predict(question=question)
+
+ class MyStatusMessageProvider1(StatusMessageProvider):
+ def tool_start_status_message(self, instance, inputs):
+ return "Provider1: Tool starting!"
+
+ def tool_end_status_message(self, outputs):
+ return "Provider1: Tool finished!"
+
+ def module_start_status_message(self, instance, inputs):
+ if isinstance(instance, dspy.Predict):
+ return "Provider1: Predict starting!"
+
+ class MyStatusMessageProvider2(StatusMessageProvider):
+ def tool_start_status_message(self, instance, inputs):
+ return "Provider2: Tool starting!"
+
+ def tool_end_status_message(self, outputs):
+ return "Provider2: Tool finished!"
+
+ def module_start_status_message(self, instance, inputs):
+ if isinstance(instance, dspy.Predict):
+ return "Provider2: Predict starting!"
+
+ # Store the original callbacks to verify they're not modified
+ original_callbacks = list(dspy.settings.callbacks)
+
+ lm = dspy.utils.DummyLM([{"answer": "red"}, {"answer": "blue"}, {"answer": "green"}, {"answer": "yellow"}])
+
+ # Results storage for each thread
+ results = {}
+
+ async def run_with_provider1():
+ with dspy.context(lm=lm):
+ program = dspy.streamify(MyProgram(), status_message_provider=MyStatusMessageProvider1())
+ output = program("sky")
+
+ status_messages = []
+ async for value in output:
+ if isinstance(value, StatusMessage):
+ status_messages.append(value.message)
+
+ results["provider1"] = status_messages
+
+ async def run_with_provider2():
+ with dspy.context(lm=lm):
+ program = dspy.streamify(MyProgram(), status_message_provider=MyStatusMessageProvider2())
+ output = program("ocean")
+
+ status_messages = []
+ async for value in output:
+ if isinstance(value, StatusMessage):
+ status_messages.append(value.message)
+
+ results["provider2"] = status_messages
+
+ # Run both tasks concurrently
+ await asyncio.gather(run_with_provider1(), run_with_provider2())
+
+ # Verify provider1 got its expected messages
+ assert len(results["provider1"]) == 3
+ assert results["provider1"][0] == "Provider1: Tool starting!"
+ assert results["provider1"][1] == "Provider1: Tool finished!"
+ assert results["provider1"][2] == "Provider1: Predict starting!"
+
+ # Verify provider2 got its expected messages
+ assert len(results["provider2"]) == 3
+ assert results["provider2"][0] == "Provider2: Tool starting!"
+ assert results["provider2"][1] == "Provider2: Tool finished!"
+ assert results["provider2"][2] == "Provider2: Predict starting!"
+
+ # Verify that the global callbacks were not modified
+ assert dspy.settings.callbacks == original_callbacks
+
+
@pytest.mark.llm_call
@pytest.mark.anyio
async def test_stream_listener_chat_adapter(lm_for_test):