DSPy: The framework for programming—not prompting—language models
Python
fix: handle error responses from ColBERTv2 server (#9227)
Emmanuel Ferdman8ccaaa35d6b8
diff --git a/dspy/dsp/colbertv2.py b/dspy/dsp/colbertv2.pyindex d6c01fb8b..23b77c8eb 100644--- a/dspy/dsp/colbertv2.py+++ b/dspy/dsp/colbertv2.py@@ -43,8 +43,16 @@ def colbertv2_get_request_v2(url: str, query: str, k: int):payload = {"query": query, "k": k}res = requests.get(url, params=payload, timeout=10)+ res.raise_for_status()- topk = res.json()["topk"][:k]+ res_json = res.json()+ if res_json.get("error"):+ error_message = res_json.get("message", "Unknown error")+ raise ValueError(f"ColBERTv2 server returned an error: {error_message}")+ if "topk" not in res_json:+ raise ValueError(f"ColBERTv2 server returned an unexpected response: {res_json}")++ topk = res_json["topk"][:k]topk = [{**d, "long_text": d["text"]} for d in topk]return topk[:k]@@ -62,8 +70,16 @@ def colbertv2_post_request_v2(url: str, query: str, k: int):headers = {"Content-Type": "application/json; charset=utf-8"}payload = {"query": query, "k": k}res = requests.post(url, json=payload, headers=headers, timeout=10)+ res.raise_for_status()++ res_json = res.json()+ if res_json.get("error"):+ error_message = res_json.get("message", "Unknown error")+ raise ValueError(f"ColBERTv2 server returned an error: {error_message}")+ if "topk" not in res_json:+ raise ValueError(f"ColBERTv2 server returned an unexpected response: {res_json}")- return res.json()["topk"][:k]+ return res_json["topk"][:k]@request_cache()diff --git a/tests/retrievers/test_colbertv2.py b/tests/retrievers/test_colbertv2.pynew file mode 100644index 000000000..3c3144c53--- /dev/null+++ b/tests/retrievers/test_colbertv2.py@@ -0,0 +1,41 @@+from unittest.mock import MagicMock, patch++import pytest++from dspy.dsp.colbertv2 import colbertv2_get_request_v2, colbertv2_post_request_v2+++def test_get_request_raises_on_server_error():+ mock_response = MagicMock()+ mock_response.json.return_value = {"error": True, "message": "connection failed"}++ with patch("dspy.dsp.colbertv2.requests.get", return_value=mock_response):+ with pytest.raises(ValueError, match="connection failed"):+ colbertv2_get_request_v2("http://test", "query", k=3)+++def test_post_request_raises_on_server_error():+ mock_response = MagicMock()+ mock_response.json.return_value = {"error": True, "message": "server error"}++ with patch("dspy.dsp.colbertv2.requests.post", return_value=mock_response):+ with pytest.raises(ValueError, match="server error"):+ colbertv2_post_request_v2("http://test2", "query", k=3)+++def test_get_request_success():+ mock_response = MagicMock()+ mock_response.json.return_value = {"topk": [{"text": "doc1", "score": 0.9}]}++ with patch("dspy.dsp.colbertv2.requests.get", return_value=mock_response):+ result = colbertv2_get_request_v2("http://test3", "query", k=3)+ assert result[0]["long_text"] == "doc1"+++def test_post_request_success():+ mock_response = MagicMock()+ mock_response.json.return_value = {"topk": [{"text": "doc1", "score": 0.9}]}++ with patch("dspy.dsp.colbertv2.requests.post", return_value=mock_response):+ result = colbertv2_post_request_v2("http://test4", "query", k=3)+ assert result[0]["text"] == "doc1"