DSPy: The framework for programming—not prompting—language models
Python
fix(interpreter): Harden JSONRPC communication and tool bridge (#9341)
Isaac Millera8041dae3691
diff --git a/dspy/primitives/python_interpreter.py b/dspy/primitives/python_interpreter.pyindex 76b685ad5..bee88643a 100644--- a/dspy/primitives/python_interpreter.py+++ b/dspy/primitives/python_interpreter.py@@ -31,13 +31,6 @@ LARGE_VAR_THRESHOLD = 100 * 1024 * 1024# JSON-RPC 2.0 Helpers# =============================================================================-# JSON-RPC 2.0 protocol errors (reserved range: -32700 to -32600)-JSONRPC_PROTOCOL_ERRORS = {- "ParseError": -32700,- "InvalidRequest": -32600,- "MethodNotFound": -32601,-}-# Application errors (range: -32000 to -32099)JSONRPC_APP_ERRORS = {"SyntaxError": -32000,@@ -301,16 +294,15 @@ class PythonInterpreter:request_id = request["id"]params = request.get("params", {})tool_name = params.get("name")- args = params.get("args", [])kwargs = params.get("kwargs", {})try:if tool_name not in self.tools:raise CodeInterpreterError(f"Unknown tool: {tool_name}")- result = self.tools[tool_name](*args, **kwargs)+ result = self.tools[tool_name](**kwargs)is_json = isinstance(result, (list, dict))response = _jsonrpc_result(- {"value": json.dumps(result) if is_json else str(result or ""), "type": "json" if is_json else "string"},+ {"value": json.dumps(result) if is_json else (str(result) if result is not None else ""), "type": "json" if is_json else "string"},request_id)except Exception as e:@@ -345,28 +337,59 @@ class PythonInterpreter:raise CodeInterpreterError(install_instructions) from eself._health_check()+ _MAX_SKIP_LINES = 100++ def _read_response_line(self, context: str) -> str:+ """Read one stdout line from Deno or raise a process-level error."""+ response_line = self.deno_process.stdout.readline().strip()+ if response_line:+ return response_line++ exit_code = self.deno_process.poll()+ if exit_code is not None:+ stderr = self.deno_process.stderr.read() if self.deno_process.stderr else ""+ raise CodeInterpreterError(f"Deno exited (code {exit_code}) {context}: {stderr}")+ raise CodeInterpreterError(f"No response {context}")++ def _parse_response_line(self, response_line: str, context: str) -> dict | None:+ """Parse a JSON-RPC line, returning None for non-JSON or malformed lines."""+ if not response_line.startswith("{"):+ logger.debug("Skipping non-JSON output during %s: %s", context, response_line)+ return None++ try:+ return json.loads(response_line)+ except json.JSONDecodeError:+ logger.debug("Skipping malformed JSON during %s: %s", context, response_line[:100])+ return None+def _send_request(self, method: str, params: dict, context: str) -> dict:- """Send a JSON-RPC request and return the parsed response."""+ """Send a JSON-RPC request and return the parsed response.++ Non-JSON lines (e.g. Pyodide package loading messages) are skipped,+ up to ``_MAX_SKIP_LINES`` to prevent unbounded blocking.+ """self._request_id += 1request_id = self._request_idmsg = _jsonrpc_request(method, params, request_id)self.deno_process.stdin.write(msg + "\n")self.deno_process.stdin.flush()- response_line = self.deno_process.stdout.readline().strip()- if not response_line:- exit_code = self.deno_process.poll()- if exit_code is not None:- stderr = self.deno_process.stderr.read() if self.deno_process.stderr else ""- raise CodeInterpreterError(f"Deno exited (code {exit_code}) {context}: {stderr}")- raise CodeInterpreterError(f"No response {context}")-- response = json.loads(response_line)- if response.get("id") != request_id:- raise CodeInterpreterError(f"Response ID mismatch {context}: expected {request_id}, got {response.get('id')}")- if "error" in response:- raise CodeInterpreterError(f"Error {context}: {response['error'].get('message', 'Unknown error')}")- return response+ skipped = 0+ while skipped <= self._MAX_SKIP_LINES:+ response_line = self._read_response_line(context)+ response = self._parse_response_line(response_line, context)+ if response is None:+ skipped += 1+ continue++ if response.get("id") != request_id:+ raise CodeInterpreterError(f"Response ID mismatch {context}: expected {request_id}, got {response.get('id')}")+ if "error" in response:+ raise CodeInterpreterError(f"Error {context}: {response['error'].get('message', 'Unknown error')}")+ return response++ raise CodeInterpreterError(f"Too many non-JSON lines ({skipped}) {context}")def _health_check(self) -> None:"""Verify the subprocess is alive by executing a simple expression."""@@ -491,24 +514,12 @@ class PythonInterpreter:# Read and handle messages until we get the final output.# Loop is needed because tool calls require back-and-forth communication.- while True:- output_line = self.deno_process.stdout.readline().strip()- if not output_line:- # Possibly the subprocess died or gave no output- err_output = self.deno_process.stderr.read()- raise CodeInterpreterError(f"No output from Deno subprocess. Stderr: {err_output}")-- # Skip non-JSON lines (e.g., Pyodide package loading messages)- if not output_line.startswith("{"):- logger.debug(f"Skipping non-JSON output: {output_line}")- continue-- # Parse that line as JSON- try:- msg = json.loads(output_line)- except json.JSONDecodeError:- # Malformed JSON starting with '{' - log and continue- logger.info(f"Skipping malformed JSON: {output_line[:100]}")+ skipped = 0+ while skipped <= self._MAX_SKIP_LINES:+ output_line = self._read_response_line("during execution")+ msg = self._parse_response_line(output_line, "during execution")+ if msg is None:+ skipped += 1continue# Handle incoming requests (tool calls from sandbox)@@ -548,6 +559,8 @@ class PythonInterpreter:# Unexpected message format - neither a recognized method nor a responseraise CodeInterpreterError(f"Unexpected message format from sandbox: {msg}")+ raise CodeInterpreterError(f"Too many non-JSON lines ({skipped}) during execution")+def start(self) -> None:"""Initialize the Deno/Pyodide sandbox.diff --git a/dspy/primitives/runner.js b/dspy/primitives/runner.jsindex 5e11c2c80..170c0f956 100644--- a/dspy/primitives/runner.js+++ b/dspy/primitives/runner.js@@ -50,25 +50,17 @@ const makeToolWrapper = (toolName, parameters = []) => {});const signature = sigParts.join(', ');const argNames = parameters.map(p => p.name);-- // If no parameters, fall back to *args, **kwargs for flexibility- if (parameters.length === 0) {- return `-import json-from pyodide.ffi import run_sync, JsProxy-def ${toolName}(*args, **kwargs):- result = run_sync(_js_tool_call("${toolName}", json.dumps({"args": args, "kwargs": kwargs})))- return result.to_py() if isinstance(result, JsProxy) else result-`;- }+ const kwargParts = argNames.map(n => `"${n}": ${n}`).join(', ');return `import jsonfrom pyodide.ffi import run_sync, JsProxydef ${toolName}(${signature}):- _args = [${argNames.join(', ')}]- result = run_sync(_js_tool_call("${toolName}", json.dumps({"args": _args, "kwargs": {}})))- return result.to_py() if isinstance(result, JsProxy) else result+ result = run_sync(_js_tool_call("${toolName}", json.dumps({"kwargs": {${kwargParts}}})))+ parsed = result.to_py() if isinstance(result, JsProxy) else result+ if isinstance(parsed, dict) and parsed.get("${TOOL_BRIDGE_ERROR_KEY}"):+ raise RuntimeError(parsed.get("message", "Tool bridge error"))+ return parsed`;};@@ -153,18 +145,18 @@ const pyodide = await pyodideModule.loadPyodide();const stdinReader = readLines(Deno.stdin);let requestIdCounter = 0;+const TOOL_BRIDGE_ERROR_KEY = "__dspy_tool_bridge_error__";+// This function is called from Python to invoke a host-side toolasync function toolCallBridge(name, argsJson) {const requestId = `tc_${Date.now()}_${++requestIdCounter}`;try {- // Parse args to extract positional and keyword argsconst parsedArgs = JSON.parse(argsJson);// Send tool call request to host using JSON-RPCconsole.log(jsonrpcRequest("tool_call", {name: name,- args: parsedArgs.args || [],kwargs: parsedArgs.kwargs || {}}, requestId));@@ -178,11 +170,19 @@ async function toolCallBridge(name, argsJson) {// Expect JSON-RPC result or error with matching idif (response.id !== requestId) {- throw new Error(`Unexpected response: expected id ${requestId}, got ${response.id}`);+ return {+ [TOOL_BRIDGE_ERROR_KEY]: true,+ message: `Tool bridge error for '${name}': Unexpected response: expected id ${requestId}, got ${response.id}`+ };}if (response.error) {- throw new Error(response.error.message || "Tool call failed");+ const errorType = response.error.data?.type || "ToolError";+ const errorMessage = response.error.message || "Tool call failed";+ return {+ [TOOL_BRIDGE_ERROR_KEY]: true,+ message: `${errorType}: ${errorMessage}`+ };}// Deserialize result based on type@@ -192,8 +192,12 @@ async function toolCallBridge(name, argsJson) {}return result.value;} catch (error) {- // Re-throw with context so Python can catch it properly- throw new Error(`Tool bridge error for '${name}': ${error.message}`);+ // Return a structured error payload so Python can raise with full context+ // without triggering a top-level unhandled rejection in Deno.+ return {+ [TOOL_BRIDGE_ERROR_KEY]: true,+ message: `Tool bridge error for '${name}': ${error.message}`+ };}}diff --git a/tests/primitives/test_python_interpreter.py b/tests/primitives/test_python_interpreter.pyindex 4a34b7f68..41c45556f 100644--- a/tests/primitives/test_python_interpreter.py+++ b/tests/primitives/test_python_interpreter.py@@ -297,6 +297,41 @@ def test_tool_default_args():assert result == "Hi, World!"+def test_tool_all_positional_args():+ """Test that tools work when all arguments are passed positionally."""++ def add(a: int, b: int, c: int) -> str:+ return f"{a + b + c}"++ with PythonInterpreter(tools={"add": add}) as sandbox:+ result = sandbox.execute("add(1, 2, 3)")+ assert result == "6"++ # Mixed: some positional, some keyword+ result = sandbox.execute("add(10, 20, c=30)")+ assert result == "60"+++def test_tool_error_surfaces_as_runtime_error():+ """Test that exceptions raised by a tool surface as RuntimeError in the sandbox."""++ def failing_tool(x: int) -> str:+ raise ValueError(f"bad value: {x}")++ with PythonInterpreter(tools={"failing_tool": failing_tool}) as sandbox:+ result = sandbox.execute(+ "try:\n"+ " failing_tool(42)\n"+ " output = 'no error'\n"+ "except RuntimeError as e:\n"+ " output = str(e)\n"+ "output"+ )+ assert "ValueError" in result+ assert "bad value: 42" in result+++# =============================================================================# Multi-Output SUBMIT Tests# =============================================================================