DSPy: The framework for programming—not prompting—language models
Python
Refactor URL construction in ArborReinforceJob to use urljoin (#8951)
Noah Ziemsa90cc44774a6
diff --git a/dspy/clients/lm_local_arbor.py b/dspy/clients/lm_local_arbor.pyindex dd2e12308..da9117cdd 100644--- a/dspy/clients/lm_local_arbor.py+++ b/dspy/clients/lm_local_arbor.py@@ -157,7 +157,7 @@ class ArborReinforceJob(ReinforceJob):},},}- url = f"{api_base}fine_tuning/grpo/initialize"+ url = urljoin(api_base, "fine_tuning/grpo/initialize")headers = {"Content-Type": "application/json"}response = requests.post(url=url, headers=headers, json=data)print(json.dumps(response.json(), indent=2))@@ -201,7 +201,7 @@ class ArborReinforceJob(ReinforceJob):def get_status(self) -> GRPOStatus:api_base = self.lm.kwargs["api_base"]- url = f"{api_base}fine_tuning/grpo/status"+ url = urljoin(api_base, "fine_tuning/grpo/status")headers = {"Content-Type": "application/json"}body = {"job_id": self.provider_job_id}response = requests.post(url, headers=headers, json=body)@@ -210,9 +210,9 @@ class ArborReinforceJob(ReinforceJob):def save_checkpoint(self, checkpoint_name: str, score: float | None = None):api_base = self.lm.kwargs["api_base"]- url = urljoin(api_base, f"fine_tuning/grpo/{self.provider_job_id}/checkpoint")+ url = urljoin(api_base, "fine_tuning/grpo/checkpoint")headers = {"Content-Type": "application/json"}- body = {"job_id": self.provider_job_id, "checkpoint_name": checkpoint_name}+ body = {"checkpoint_name": checkpoint_name, "job_id": self.provider_job_id}response = requests.post(url, headers=headers, json=body)assert response.status_code == 200, f"Failed to save checkpoint: {response.text}"response = response.json()@@ -229,7 +229,7 @@ class ArborReinforceJob(ReinforceJob):def terminate(self):api_base = self.lm.kwargs["api_base"]- url = urljoin(api_base, f"fine_tuning/grpo/{self.provider_job_id}/terminate")+ url = urljoin(api_base, "fine_tuning/grpo/terminate")headers = {"Content-Type": "application/json"}body = {"job_id": self.provider_job_id}response = requests.post(url, headers=headers, json=body)diff --git a/dspy/clients/provider.py b/dspy/clients/provider.pyindex 01952cd23..94612eb02 100644--- a/dspy/clients/provider.py+++ b/dspy/clients/provider.py@@ -55,10 +55,6 @@ class ReinforceJob:def terminate(self):raise NotImplementedError- @abstractmethod- def update_model(self):- raise NotImplementedError-@abstractmethoddef save_checkpoint(self, checkpoint_name: str):raise NotImplementedError