DSPy: The framework for programming—not prompting—language models
Python
fix: correct return annotations that say bool but return something else (#10408)
Aryan Kochharbc9214ab4304
diff --git a/dspy/adapters/base.py b/dspy/adapters/base.pyindex 028df7a0d..421cc3acb 100644--- a/dspy/adapters/base.py+++ b/dspy/adapters/base.py@@ -488,13 +488,13 @@ class Adapter:return messages- def _get_history_field_name(self, signature: type[Signature]) -> bool:+ def _get_history_field_name(self, signature: type[Signature]) -> str | None:for name, field in signature.input_fields.items():if field.annotation == History:return namereturn None- def _get_tool_call_input_field_name(self, signature: type[Signature]) -> bool:+ def _get_tool_call_input_field_name(self, signature: type[Signature]) -> str | None:for name, field in signature.input_fields.items():# Look for annotation `list[dspy.Tool]` or `dspy.Tool`origin = get_origin(field.annotation)@@ -504,7 +504,7 @@ class Adapter:return namereturn None- def _get_tool_call_output_field_name(self, signature: type[Signature]) -> bool:+ def _get_tool_call_output_field_name(self, signature: type[Signature]) -> str | None:for name, field in signature.output_fields.items():if field.annotation == ToolCalls:return namediff --git a/dspy/adapters/types/citation.py b/dspy/adapters/types/citation.pyindex a8c5461a5..2f4ca4648 100644--- a/dspy/adapters/types/citation.py+++ b/dspy/adapters/types/citation.py@@ -1,10 +1,13 @@-from typing import Any, Optional+from typing import TYPE_CHECKING, Any, Optionalimport pydanticfrom dspy.adapters.types.base_type import Typefrom dspy.utils.annotation import experimental+if TYPE_CHECKING:+ from dspy.signatures.signature import Signature+@experimental(version="3.0.4")class Citations(Type):@@ -168,7 +171,7 @@ class Citations(Type):return self.citations[index]@classmethod- def adapt_to_native_lm_feature(cls, signature, field_name, lm, lm_kwargs) -> bool:+ def adapt_to_native_lm_feature(cls, signature, field_name, lm, lm_kwargs) -> type["Signature"]:if lm.model.startswith("anthropic/"):return signature.delete(field_name)return signature