Skip to content

armgit / dub

Public Imported from GitHub
0

The modern link attribution platform. Loved by world-class engineering teams at Twilio, Zillow, Jobber, Vercel, Raycast, and more.

Treat empty metadata objects as absent instead of storing {}.

Kiran K01894769afb9
diff --git a/apps/web/lib/zod/schemas/misc.ts b/apps/web/lib/zod/schemas/misc.ts
index 2e55ccd523..a6f583a2db 100644
--- a/apps/web/lib/zod/schemas/misc.ts
+++ b/apps/web/lib/zod/schemas/misc.ts
@@ -98,6 +98,7 @@ export const metadataSchema = z
.record(z.string(), z.any())
.nullish()
.default(null)
+ .transform((val) => (val != null && Object.keys(val).length > 0 ? val : null))
.refine((val) => !val || JSON.stringify(val).length <= 10000, {
message: "Metadata must be less than 10,000 characters when stringified",
});
diff --git a/apps/web/playwright/api/commissions/commissions.spec.ts b/apps/web/playwright/api/commissions/commissions.spec.ts
index 9dddf1bb0f..137fedb963 100644
--- a/apps/web/playwright/api/commissions/commissions.spec.ts
+++ b/apps/web/playwright/api/commissions/commissions.spec.ts
@@ -173,6 +173,27 @@ test.describe("Lead commissions", () => {
});
});
+ test("treats empty lead metadata as absent", async ({ api, program }) => {
+ await withCommissionPartner(api, program, async (partnerId) => {
+ expect(
+ await api.post("/api/commissions", {
+ type: "lead",
+ partnerId,
+ lead: { metadata: {} },
+ customer: customerBody(),
+ }),
+ ).toEqual(expectedQueuedResponse);
+
+ await expectCommissionCreated({
+ api,
+ partnerId,
+ programId: program.id,
+ type: "lead",
+ expectedMetadata: null,
+ });
+ });
+ });
+
test("supports deprecated leadEventName + leadEventDate", async ({
api,
program,