The modern link attribution platform. Loved by world-class engineering teams at Twilio, Zillow, Jobber, Vercel, Raycast, and more.
TypeScript clickhousemysqlnextjsopen-sourceplanetscaleprismatailwindcsstinybirdtypescriptupstashvercel
code improvements
Pedro Ladeira02002c50ed14
diff --git a/apps/web/lib/email/parse-campaign-from-address.ts b/apps/web/lib/email/parse-campaign-from-address.tsindex 789333b1b9..0666a88e71 100644--- a/apps/web/lib/email/parse-campaign-from-address.ts+++ b/apps/web/lib/email/parse-campaign-from-address.ts@@ -16,7 +16,12 @@ export function parseCampaignFromAddress(const displayName = namedMatch[1].trim();const email = namedMatch[2].trim();- if (!displayName || !z.email().safeParse(email).success) {+ if (+ !displayName ||+ displayName.includes("<") ||+ displayName.includes(">") ||+ !z.email().safeParse(email).success+ ) {return null;}diff --git a/apps/web/tests/misc/parse-campaign-from-address.test.ts b/apps/web/tests/misc/parse-campaign-from-address.test.tsindex 107bdcd67f..5b84a37d5a 100644--- a/apps/web/tests/misc/parse-campaign-from-address.test.ts+++ b/apps/web/tests/misc/parse-campaign-from-address.test.ts@@ -35,6 +35,9 @@ describe("parseCampaignFromAddress", () => {["Alice <>", "empty email"],["Alice <not-an-email>", "invalid email in brackets"],["Name <[email protected]> extra", "trailing junk"],+ ["Sales <EMEA> <[email protected]>", "nested angle brackets"],+ ["Sales <EMEA <[email protected]>", "unclosed bracket in display name"],+ ["Foo > Bar <[email protected]>", "closing bracket in display name"],])("rejects invalid: %s — %s", (input) => {expect(parseCampaignFromAddress(input)).toBeNull();});