Skip to content

armgit / dub

Public Imported from GitHub
0

The modern link attribution platform. Loved by world-class engineering teams at Twilio, Zillow, Jobber, Vercel, Raycast, and more.

Extract send campaign condition schema into its own workflow schema file

Kiran K02bfc1b8ca24
diff --git a/apps/web/app/app.dub.co/(dashboard)/[slug]/(ee)/program/campaigns/[campaignId]/transactional-campaign-logic.tsx b/apps/web/app/app.dub.co/(dashboard)/[slug]/(ee)/program/campaigns/[campaignId]/transactional-campaign-logic.tsx
index af8324e667..c633347c93 100644
--- a/apps/web/app/app.dub.co/(dashboard)/[slug]/(ee)/program/campaigns/[campaignId]/transactional-campaign-logic.tsx
+++ b/apps/web/app/app.dub.co/(dashboard)/[slug]/(ee)/program/campaigns/[campaignId]/transactional-campaign-logic.tsx
@@ -1,6 +1,8 @@
+import {
+ SEND_CAMPAIGN_ATTRIBUTE_CONFIG,
+ SEND_CAMPAIGN_ATTRIBUTES,
+} from "@/lib/api/workflows/send-campaign/schema";
import { handleMoneyInputChange, handleMoneyKeyDown } from "@/lib/form-utils";
-import { CAMPAIGN_WORKFLOW_ATTRIBUTE_CONFIG } from "@/lib/zod/schemas/campaigns";
-import { WORKFLOW_ATTRIBUTES } from "@/lib/zod/schemas/workflows";
import { DurationPopoverContent } from "@/ui/shared/duration-popover-content";
import {
InlineBadgePopover,
@@ -19,9 +21,7 @@ export function TransactionalCampaignLogic() {
const value = watch("triggerCondition.value");
const prevAttributeRef = useRef(attribute);
- const config = attribute
- ? CAMPAIGN_WORKFLOW_ATTRIBUTE_CONFIG[attribute]
- : null;
+ const config = attribute ? SEND_CAMPAIGN_ATTRIBUTE_CONFIG[attribute] : null;
// Reset value when attribute changes
useEffect(() => {
@@ -55,7 +55,7 @@ export function TransactionalCampaignLogic() {
<InlineBadgePopover
text={
field.value
- ? CAMPAIGN_WORKFLOW_ATTRIBUTE_CONFIG[field.value].label
+ ? SEND_CAMPAIGN_ATTRIBUTE_CONFIG[field.value].label
: "activity"
}
invalid={!field.value}
@@ -63,8 +63,8 @@ export function TransactionalCampaignLogic() {
<InlineBadgePopoverMenu
selectedValue={field.value}
onSelect={field.onChange}
- items={WORKFLOW_ATTRIBUTES.map((attr) => ({
- text: CAMPAIGN_WORKFLOW_ATTRIBUTE_CONFIG[attr].label,
+ items={SEND_CAMPAIGN_ATTRIBUTES.map((attr) => ({
+ text: SEND_CAMPAIGN_ATTRIBUTE_CONFIG[attr].label,
value: attr,
}))}
/>
diff --git a/apps/web/app/app.dub.co/(dashboard)/[slug]/(ee)/program/campaigns/[campaignId]/utils.ts b/apps/web/app/app.dub.co/(dashboard)/[slug]/(ee)/program/campaigns/[campaignId]/utils.ts
index 4aa1340a2c..93e9f1dd76 100644
--- a/apps/web/app/app.dub.co/(dashboard)/[slug]/(ee)/program/campaigns/[campaignId]/utils.ts
+++ b/apps/web/app/app.dub.co/(dashboard)/[slug]/(ee)/program/campaigns/[campaignId]/utils.ts
@@ -1,8 +1,10 @@
-import { WorkflowCondition } from "@/lib/types";
-import { CAMPAIGN_WORKFLOW_ATTRIBUTE_CONFIG } from "@/lib/zod/schemas/campaigns";
+import {
+ SEND_CAMPAIGN_ATTRIBUTE_CONFIG,
+ SendCampaignCondition,
+} from "@/lib/api/workflows/send-campaign/schema";
export function isValidTriggerCondition(
- triggerCondition: WorkflowCondition,
+ triggerCondition: SendCampaignCondition | null | undefined,
): boolean {
// Null/undefined is valid (no trigger condition set)
if (!triggerCondition) {
@@ -14,7 +16,7 @@ export function isValidTriggerCondition(
return false;
}
- const config = CAMPAIGN_WORKFLOW_ATTRIBUTE_CONFIG[triggerCondition.attribute];
+ const config = SEND_CAMPAIGN_ATTRIBUTE_CONFIG[triggerCondition.attribute];
// If attribute doesn't exist in config, invalid
if (!config) {
diff --git a/apps/web/lib/api/workflows/send-campaign/execute.ts b/apps/web/lib/api/workflows/send-campaign/execute.ts
index 37023f09aa..392fb38359 100644
--- a/apps/web/lib/api/workflows/send-campaign/execute.ts
+++ b/apps/web/lib/api/workflows/send-campaign/execute.ts
@@ -3,7 +3,6 @@ import { aggregatePartnerLinksStats } from "@/lib/partners/aggregate-partner-lin
import { constructPartnerLink } from "@/lib/partners/construct-partner-link";
import { prisma } from "@/lib/prisma";
import {
- CampaignTriggerCondition,
TiptapNode,
WorkflowConditionAttribute,
WorkflowContext,
@@ -14,10 +13,11 @@ import CampaignEmail from "@dub/email/templates/campaign-email";
import { chunk } from "@dub/utils";
import { NotificationEmailType, Prisma, Workflow } from "@prisma/client";
import { addHours, differenceInDays, subDays } from "date-fns";
+import { renderCampaignEmailHTML } from "../../campaigns/render-campaign-email-html";
import { validateCampaignFromAddress } from "../../campaigns/validate-campaign";
import { createId } from "../../create-id";
import { parseWorkflowConfig } from "../parse-workflow-config";
-import { renderCampaignEmailHTML } from "../../campaigns/render-campaign-email-html";
+import { SendCampaignCondition } from "./schema";
export const executeSendCampaignWorkflow = async ({
workflow,
@@ -73,7 +73,7 @@ export const executeSendCampaignWorkflow = async ({
programId,
partnerId,
groupIds: campaign.groups.map(({ groupId }) => groupId),
- condition: condition as CampaignTriggerCondition,
+ condition: condition as SendCampaignCondition,
});
if (programEnrollments.length === 0) {
@@ -251,7 +251,7 @@ async function getProgramEnrollments({
programId: string;
partnerId?: string;
groupIds: string[];
- condition: CampaignTriggerCondition;
+ condition: SendCampaignCondition;
}) {
if (partnerId) {
const { attribute } = condition;
diff --git a/apps/web/lib/api/workflows/send-campaign/schema.ts b/apps/web/lib/api/workflows/send-campaign/schema.ts
new file mode 100644
index 0000000000..515a28969e
--- /dev/null
+++ b/apps/web/lib/api/workflows/send-campaign/schema.ts
@@ -0,0 +1,75 @@
+import * as z from "zod/v4";
+
+export const SEND_CAMPAIGN_ATTRIBUTES = [
+ "totalLeads",
+ "totalConversions",
+ "totalSaleAmount",
+ "totalCommissions",
+ "partnerEnrolledDays",
+ "partnerJoined",
+] as const;
+
+export const SEND_CAMPAIGN_OPERATORS = ["gte"] as const;
+
+export const SEND_CAMPAIGN_ATTRIBUTE_CONFIG: Record<
+ SendCampaignAttribute,
+ SendCampaignAttributeConfig
+> = {
+ totalLeads: {
+ label: "total leads",
+ inputType: "number",
+ operators: ["gte"],
+ },
+ totalConversions: {
+ label: "total conversions",
+ inputType: "number",
+ operators: ["gte"],
+ },
+ totalSaleAmount: {
+ label: "total revenue",
+ inputType: "currency",
+ operators: ["gte"],
+ },
+ totalCommissions: {
+ label: "total commissions",
+ inputType: "currency",
+ operators: ["gte"],
+ },
+ partnerEnrolledDays: {
+ label: "enrollment duration",
+ inputType: "dropdown",
+ operators: ["gte"],
+ dropdownValues: [1, 3, 7, 14, 30],
+ },
+ partnerJoined: {
+ label: "joins the program",
+ inputType: "none",
+ operators: ["gte"],
+ },
+};
+
+export const SEND_CAMPAIGN_OPERATOR_LABELS: Record<
+ SendCampaignOperator,
+ string
+> = {
+ gte: "at least",
+} as const;
+
+export const sendCampaignConditionSchema = z.object({
+ attribute: z.enum(SEND_CAMPAIGN_ATTRIBUTES),
+ operator: z.enum(SEND_CAMPAIGN_OPERATORS).default("gte"),
+ value: z.number(),
+});
+
+export type SendCampaignCondition = z.infer<typeof sendCampaignConditionSchema>;
+
+export type SendCampaignAttribute = (typeof SEND_CAMPAIGN_ATTRIBUTES)[number];
+
+type SendCampaignOperator = (typeof SEND_CAMPAIGN_OPERATORS)[number];
+
+export type SendCampaignAttributeConfig = {
+ label: string;
+ inputType: "number" | "currency" | "dropdown" | "none";
+ operators: readonly SendCampaignOperator[];
+ dropdownValues?: number[];
+};
diff --git a/apps/web/lib/types.ts b/apps/web/lib/types.ts
index 783b5b0ee1..c6c7ef2c2a 100644
--- a/apps/web/lib/types.ts
+++ b/apps/web/lib/types.ts
@@ -83,7 +83,6 @@ import {
CampaignListSchema,
CampaignSchema,
campaignSummarySchema,
- campaignTriggerConditionSchema,
EMAIL_TEMPLATE_VARIABLES,
updateCampaignSchema,
} from "./zod/schemas/campaigns";
@@ -725,9 +724,7 @@ export type BountySocialMetricsIncrementalBonus = z.infer<
typeof bountySocialContentIncrementalBonusSchema
>;
-export type CampaignTriggerCondition = z.infer<
- typeof campaignTriggerConditionSchema
->;
+export type { SendCampaignCondition } from "./api/workflows/send-campaign/schema";
export type WorkflowConditionAttribute = (typeof WORKFLOW_ATTRIBUTES)[number];
@@ -767,12 +764,6 @@ export interface TiptapNode {
marks?: Array<{ type: string; attrs?: Record<string, any> }>;
}
-export interface CampaignWorkflowAttributeConfig {
- label: string;
- inputType: "number" | "currency" | "dropdown" | "none";
- dropdownValues?: number[];
-}
-
export type WorkflowAttribute = (typeof WORKFLOW_ATTRIBUTES)[number];
export type EmailDomainProps = z.infer<typeof EmailDomainSchema>;
diff --git a/apps/web/lib/zod/schemas/campaigns.ts b/apps/web/lib/zod/schemas/campaigns.ts
index 46bcfeb8ac..e9c83034a1 100644
--- a/apps/web/lib/zod/schemas/campaigns.ts
+++ b/apps/web/lib/zod/schemas/campaigns.ts
@@ -1,14 +1,11 @@
-import {
- CampaignWorkflowAttributeConfig,
- WorkflowAttribute,
-} from "@/lib/types";
import { CampaignStatus, CampaignType } from "@prisma/client";
import * as z from "zod/v4";
+import { sendCampaignConditionSchema } from "../../api/workflows/send-campaign/schema";
import { GroupSchema } from "./groups";
import { getPaginationQuerySchema } from "./misc";
import { EnrolledPartnerSchema } from "./partners";
import { parseDateSchema } from "./utils";
-import { WORKFLOW_ATTRIBUTES, workflowConditionSchema } from "./workflows";
+import { workflowConditionSchema } from "./workflows";
export const EMAIL_TEMPLATE_VARIABLES = [
"PartnerName",
@@ -16,43 +13,6 @@ export const EMAIL_TEMPLATE_VARIABLES = [
"PartnerLink",
] as const;
-export const CAMPAIGN_WORKFLOW_ATTRIBUTE_CONFIG: Record<
- WorkflowAttribute,
- CampaignWorkflowAttributeConfig
-> = {
- totalLeads: {
- label: "total leads",
- inputType: "number",
- },
- totalConversions: {
- label: "total conversions",
- inputType: "number",
- },
- totalSaleAmount: {
- label: "total revenue",
- inputType: "currency",
- },
- totalCommissions: {
- label: "total commissions",
- inputType: "currency",
- },
- partnerEnrolledDays: {
- label: "enrollment duration",
- inputType: "dropdown",
- dropdownValues: [1, 3, 7, 14, 30],
- },
- partnerJoined: {
- label: "joins the program",
- inputType: "none",
- },
-};
-
-export const campaignTriggerConditionSchema = z.object({
- attribute: z.enum(WORKFLOW_ATTRIBUTES),
- operator: z.literal("gte").default("gte"),
- value: z.number(),
-});
-
export const CampaignSchema = z.object({
id: z.string(),
name: z.string(),
@@ -62,7 +22,7 @@ export const CampaignSchema = z.object({
bodyJson: z.record(z.string(), z.any()),
type: z.enum(CampaignType),
status: z.enum(CampaignStatus),
- triggerCondition: campaignTriggerConditionSchema.nullable().default(null),
+ triggerCondition: sendCampaignConditionSchema.nullable().default(null),
groups: z.array(GroupSchema.pick({ id: true })),
scheduledAt: z.date().nullable(),
createdAt: z.date(),
@@ -95,7 +55,7 @@ export const updateCampaignSchema = z
preview: z.string().nullish(),
from: z.email().trim().toLowerCase(),
bodyJson: z.record(z.string(), z.any()),
- triggerCondition: campaignTriggerConditionSchema.nullish(),
+ triggerCondition: sendCampaignConditionSchema.nullish(),
groupIds: z.array(z.string()).nullable(),
scheduledAt: parseDateSchema.nullish(),
status: z.enum([