Skip to content

armgit / dub

Public Imported from GitHub
0

The modern link attribution platform. Loved by world-class engineering teams at Twilio, Zillow, Jobber, Vercel, Raycast, and more.

fix naming

Steven Tey03dd8706c4c4
diff --git a/apps/web/lib/actions/partners/reactivate-partner.ts b/apps/web/lib/actions/partners/reactivate-partner.ts
index 31dcbc21c6..1d3d637777 100644
--- a/apps/web/lib/actions/partners/reactivate-partner.ts
+++ b/apps/web/lib/actions/partners/reactivate-partner.ts
@@ -43,7 +43,7 @@ export const reactivatePartnerAction = authActionClient
throw new Error("This partner is not deactivated.");
}
- const defaultGroup = await getGroupOrThrow({
+ const partnerGroup = await getGroupOrThrow({
programId,
groupId:
programEnrollment.groupId || programEnrollment.program.defaultGroupId,
@@ -63,11 +63,11 @@ export const reactivatePartnerAction = authActionClient
},
data: {
status: "approved",
- groupId: defaultGroup.id,
- clickRewardId: defaultGroup.clickRewardId,
- leadRewardId: defaultGroup.leadRewardId,
- saleRewardId: defaultGroup.saleRewardId,
- discountId: defaultGroup.discountId,
+ groupId: partnerGroup.id,
+ clickRewardId: partnerGroup.clickRewardId,
+ leadRewardId: partnerGroup.leadRewardId,
+ saleRewardId: partnerGroup.saleRewardId,
+ discountId: partnerGroup.discountId,
},
}),
]);
diff --git a/apps/web/lib/api/conversions/track-sale.ts b/apps/web/lib/api/conversions/track-sale.ts
index 7fce91d470..ca7e394b67 100644
--- a/apps/web/lib/api/conversions/track-sale.ts
+++ b/apps/web/lib/api/conversions/track-sale.ts
@@ -253,8 +253,9 @@ export const trackSale = async ({
leadEventData = {
...clickData,
event_id: nanoid(16),
- // if leadEventName is provided, use it, otherwise use "Sign up"
- event_name: leadEventName ?? "Sign up",
+ // if leadEventName is provided, use it
+ // otherwise use "Direct sale tracking lead event" (since it's for direct sale tracking)
+ event_name: leadEventName ?? "Direct sale tracking lead event",
customer_id: newCustomer.id,
metadata: metadata ? JSON.stringify(metadata) : "",
};