Skip to content

armgit / dub

Public Imported from GitHub
0

The modern link attribution platform. Loved by world-class engineering teams at Twilio, Zillow, Jobber, Vercel, Raycast, and more.

code improvements

Pedro Ladeira04ec8000459a
diff --git a/apps/web/app/app.dub.co/(dashboard)/[slug]/(ee)/program/partners/[partnerId]/links/discount-codes.tsx b/apps/web/app/app.dub.co/(dashboard)/[slug]/(ee)/program/partners/[partnerId]/links/discount-codes.tsx
index ed84205df5..2e38ac7286 100644
--- a/apps/web/app/app.dub.co/(dashboard)/[slug]/(ee)/program/partners/[partnerId]/links/discount-codes.tsx
+++ b/apps/web/app/app.dub.co/(dashboard)/[slug]/(ee)/program/partners/[partnerId]/links/discount-codes.tsx
@@ -59,14 +59,11 @@ function getEffectiveDiscountProvider({
partnerDiscount?: Pick<DiscountProps, "id" | "provider"> | null;
groupDiscount?: Pick<DiscountProps, "id" | "provider"> | null;
}): DiscountProvider | null {
- const linkDiscount = discounts?.find((d) => d.id === link.discount);
+ if (link.discount) {
+ return discounts?.find((d) => d.id === link.discount)?.provider ?? null;
+ }
- return (
- linkDiscount?.provider ??
- partnerDiscount?.provider ??
- groupDiscount?.provider ??
- null
- );
+ return partnerDiscount?.provider ?? groupDiscount?.provider ?? null;
}
function linkHasEffectiveDiscount({
diff --git a/apps/web/ui/modals/add-discount-code-modal.tsx b/apps/web/ui/modals/add-discount-code-modal.tsx
index bd597bdfe9..6a28466359 100644
--- a/apps/web/ui/modals/add-discount-code-modal.tsx
+++ b/apps/web/ui/modals/add-discount-code-modal.tsx
@@ -90,6 +90,10 @@ const AddDiscountCodeModal = ({
}, [partnerLinks, debouncedSearch]);
const onSubmit = async (formData: FormData) => {
+ if (!provider) {
+ return;
+ }
+
await makeRequest("/api/discount-codes", {
method: "POST",
body: {
@@ -259,7 +263,7 @@ const AddDiscountCodeModal = ({
}
className="h-8 w-fit pl-2.5 pr-1.5"
loading={isSubmitting}
- disabled={!linkId || (codeWillChange && !codeToCreate)}
+ disabled={!linkId || !provider || (codeWillChange && !codeToCreate)}
/>
</div>
</form>