The modern link attribution platform. Loved by world-class engineering teams at Twilio, Zillow, Jobber, Vercel, Raycast, and more.
TypeScript clickhousemysqlnextjsopen-sourceplanetscaleprismatailwindcsstinybirdtypescriptupstashvercel
Reject unsupported operators and dangling AND/OR in metadata queries.
Kiran K0675faf4bade
diff --git a/apps/web/lib/api/commissions/metadata-filters.ts b/apps/web/lib/api/commissions/metadata-filters.tsindex 2e137e68cf..c1a77ed429 100644--- a/apps/web/lib/api/commissions/metadata-filters.ts+++ b/apps/web/lib/api/commissions/metadata-filters.ts@@ -67,6 +67,14 @@ function parseCondition(condition: string): CommissionMetadataFilter {});}+ // e.g. `==` leaves a leftover that starts with `=` after the first `=` is matched.+ if (/^[=:!<>]/.test(value)) {+ throw new DubApiError({+ code: "unprocessable_entity",+ message: "Metadata query only supports `=` and `!=` operators.",+ });+ }+return {key,op: mapOperator(operator),@@ -82,6 +90,14 @@ export function parseCommissionMetadataQuery(}const trimmed = query.trim();++ if (/\s+(?:and|or)\s*$/i.test(trimmed)) {+ throw new DubApiError({+ code: "unprocessable_entity",+ message: "Invalid metadata query.",+ });+ }+const hasAnd = /\s+and\s+/i.test(trimmed);const hasOr = /\s+or\s+/i.test(trimmed);@@ -99,7 +115,10 @@ export function parseCommissionMetadataQuery(for (const condition of conditions) {const trimmedCondition = condition.trim();if (!trimmedCondition) {- continue;+ throw new DubApiError({+ code: "unprocessable_entity",+ message: "Invalid metadata query.",+ });}filters.push(parseCondition(trimmedCondition));}diff --git a/apps/web/tests/commissions/metadata-filters.test.ts b/apps/web/tests/commissions/metadata-filters.test.tsindex 2e760ff461..b23066631d 100644--- a/apps/web/tests/commissions/metadata-filters.test.ts+++ b/apps/web/tests/commissions/metadata-filters.test.ts@@ -124,6 +124,34 @@ describe("parseCommissionMetadataQuery", () => {}});+ it("rejects double-equals and dangling connectives", () => {+ for (const query of [+ "metadata['plan']=='pro'",+ "metadata['a']='1' AND",+ "metadata['a']='1' AND ",+ "metadata['a']='1' OR",+ "metadata['a']='1' OR ",+ ]) {+ expect(() => parseCommissionMetadataQuery(query)).toThrow(DubApiError);+ }++ try {+ parseCommissionMetadataQuery("metadata['plan']=='pro'");+ } catch (error) {+ expect((error as DubApiError).code).toBe("unprocessable_entity");+ expect((error as DubApiError).message).toBe(+ "Metadata query only supports `=` and `!=` operators.",+ );+ }++ try {+ parseCommissionMetadataQuery("metadata['a']='1' AND");+ } catch (error) {+ expect((error as DubApiError).code).toBe("unprocessable_entity");+ expect((error as DubApiError).message).toBe("Invalid metadata query.");+ }+ });+it("rejects non-metadata fields and junk", () => {expect(() => parseCommissionMetadataQuery("status:active")).toThrow(DubApiError,