Skip to content

armgit / dub

Public Imported from GitHub
0

The modern link attribution platform. Loved by world-class engineering teams at Twilio, Zillow, Jobber, Vercel, Raycast, and more.

fix(advanced-filters): mismatch prevents root filter from rendering selected state.

Pedro Ladeira08d73a52f22a
diff --git a/apps/web/ui/analytics/use-analytics-filters.tsx b/apps/web/ui/analytics/use-analytics-filters.tsx
index 45c1ce0323..61cb788018 100644
--- a/apps/web/ui/analytics/use-analytics-filters.tsx
+++ b/apps/web/ui/analytics/use-analytics-filters.tsx
@@ -527,12 +527,12 @@ export function useAnalyticsFilters({
label: "Link type",
options: [
{
- value: true,
+ value: "true",
icon: Globe2,
label: "Root domain link",
},
{
- value: false,
+ value: "false",
icon: Hyperlink,
label: "Regular short link",
},
diff --git a/packages/tinybird/pipes/v3_count.pipe b/packages/tinybird/pipes/v3_count.pipe
index 35f4d0b082..7b87ce9d3b 100644
--- a/packages/tinybird/pipes/v3_count.pipe
+++ b/packages/tinybird/pipes/v3_count.pipe
@@ -481,13 +481,13 @@ SQL >
{% elif operator == 'notEquals' %}
AND JSONExtractString(se.metadata, {{ metadataKey }}) != {{ value }}
{% elif operator == 'greaterThan' %}
- AND JSONExtractString(se.metadata, {{ metadataKey }}) > {{ value }}
+ AND toFloat64OrNull(JSONExtractString(se.metadata, {{ metadataKey }})) > toFloat64OrNull({{ value }})
{% elif operator == 'lessThan' %}
- AND JSONExtractString(se.metadata, {{ metadataKey }}) < {{ value }}
+ AND toFloat64OrNull(JSONExtractString(se.metadata, {{ metadataKey }})) < toFloat64OrNull({{ value }})
{% elif operator == 'greaterThanOrEqual' %}
- AND JSONExtractString(se.metadata, {{ metadataKey }}) >= {{ value }}
+ AND toFloat64OrNull(JSONExtractString(se.metadata, {{ metadataKey }})) >= toFloat64OrNull({{ value }})
{% elif operator == 'lessThanOrEqual' %}
- AND JSONExtractString(se.metadata, {{ metadataKey }}) <= {{ value }}
+ AND toFloat64OrNull(JSONExtractString(se.metadata, {{ metadataKey }})) <= toFloat64OrNull({{ value }})
{% end %}
{% elif item.get('field', '') %}
{% set field = item.get('field', '') %}
diff --git a/packages/tinybird/pipes/v3_group_by.pipe b/packages/tinybird/pipes/v3_group_by.pipe
index 9dc57bdd71..d049c63709 100644
--- a/packages/tinybird/pipes/v3_group_by.pipe
+++ b/packages/tinybird/pipes/v3_group_by.pipe
@@ -643,13 +643,13 @@ SQL >
{% elif operator == 'notEquals' %}
AND JSONExtractString(se.metadata, {{ metadataKey }}) != {{ value }}
{% elif operator == 'greaterThan' %}
- AND JSONExtractString(se.metadata, {{ metadataKey }}) > {{ value }}
+ AND toFloat64OrNull(JSONExtractString(se.metadata, {{ metadataKey }})) > toFloat64OrNull({{ value }})
{% elif operator == 'lessThan' %}
- AND JSONExtractString(se.metadata, {{ metadataKey }}) < {{ value }}
+ AND toFloat64OrNull(JSONExtractString(se.metadata, {{ metadataKey }})) < toFloat64OrNull({{ value }})
{% elif operator == 'greaterThanOrEqual' %}
- AND JSONExtractString(se.metadata, {{ metadataKey }}) >= {{ value }}
+ AND toFloat64OrNull(JSONExtractString(se.metadata, {{ metadataKey }})) >= toFloat64OrNull({{ value }})
{% elif operator == 'lessThanOrEqual' %}
- AND JSONExtractString(se.metadata, {{ metadataKey }}) <= {{ value }}
+ AND toFloat64OrNull(JSONExtractString(se.metadata, {{ metadataKey }})) <= toFloat64OrNull({{ value }})
{% end %}
{% elif item.get('field', '') %}
{% set field = item.get('field', '') %}