The modern link attribution platform. Loved by world-class engineering teams at Twilio, Zillow, Jobber, Vercel, Raycast, and more.
TypeScript clickhousemysqlnextjsopen-sourceplanetscaleprismatailwindcsstinybirdtypescriptupstashvercel
Delete the fraud events when the partners are unbanned (#3288)
Kiran K1067b08b170e
diff --git a/apps/web/app/(ee)/api/cron/partners/ban/process/route.ts b/apps/web/app/(ee)/api/cron/partners/ban/process/route.tsindex 844086b143..ca214ef08f 100644--- a/apps/web/app/(ee)/api/cron/partners/ban/process/route.ts+++ b/apps/web/app/(ee)/api/cron/partners/ban/process/route.ts@@ -6,7 +6,10 @@ import { syncTotalCommissions } from "@/lib/api/partners/sync-total-commissions"import { getProgramEnrollmentOrThrow } from "@/lib/api/programs/get-program-enrollment-or-throw";import { withCron } from "@/lib/cron/with-cron";import { recordLink } from "@/lib/tinybird";-import { BAN_PARTNER_REASONS } from "@/lib/zod/schemas/partners";+import {+ BAN_PARTNER_REASONS,+ INACTIVE_ENROLLMENT_STATUSES,+} from "@/lib/zod/schemas/partners";import { sendEmail } from "@dub/email";import PartnerBanned from "@dub/email/templates/partner-banned";import { prisma } from "@dub/prisma";@@ -132,27 +135,34 @@ export const POST = withCron(async ({ rawBody }) => {),]);- // Find other programs where this partner is enrolled and approved- const programEnrollments = await prisma.programEnrollment.findMany({+ const affectedProgramEnrollments = await prisma.programEnrollment.findMany({where: {partnerId,programId: {not: programId,},- status: "approved",+ status: {+ notIn: INACTIVE_ENROLLMENT_STATUSES,+ },},select: {programId: true,+ partnerId: true,},});- // Create partnerCrossProgramBan fraud events for other programs where this partner- // is enrolled and approved, to flag potential cross-program fraud risk+ // Create partnerCrossProgramBan fraud events for all active enrollments+ // to flag potential cross-program fraud riskawait createFraudEvents(- programEnrollments.map(({ programId }) => ({- programId,- partnerId,+ affectedProgramEnrollments.map((affectedEnrollment) => ({+ programId: affectedEnrollment.programId,+ partnerId: affectedEnrollment.partnerId,type: FraudRuleType.partnerCrossProgramBan,+ sourceProgramId: programEnrollment.programId, // The program that issued the ban+ metadata: {+ bannedReason: programEnrollment.bannedReason,+ bannedAt: programEnrollment.bannedAt,+ },})),);diff --git a/apps/web/app/(ee)/api/fraud/events/route.ts b/apps/web/app/(ee)/api/fraud/events/route.tsindex 8d785ec4fe..5924de8e0d 100644--- a/apps/web/app/(ee)/api/fraud/events/route.ts+++ b/apps/web/app/(ee)/api/fraud/events/route.ts@@ -54,30 +54,6 @@ export const GET = withWorkspace(};eventGroupType = fraudGroup.type;-- // Special case for partnerCrossProgramBan rule type- if (eventGroupType === FraudRuleType.partnerCrossProgramBan) {- const bannedProgramEnrollments =- await prisma.programEnrollment.findMany({- where: {- partnerId: fraudGroup.partnerId,- programId: {- not: programId,- },- status: "banned",- },- select: {- bannedAt: true,- bannedReason: true,- },- });-- return NextResponse.json(- z- .array(fraudEventSchemas["partnerCrossProgramBan"])- .parse(bannedProgramEnrollments),- );- }}// Filter by customer ID and typediff --git a/apps/web/lib/actions/partners/bulk-reject-partner-applications.ts b/apps/web/lib/actions/partners/bulk-reject-partner-applications.tsindex 58d08d20d3..dcb59c2037 100644--- a/apps/web/lib/actions/partners/bulk-reject-partner-applications.ts+++ b/apps/web/lib/actions/partners/bulk-reject-partner-applications.ts@@ -70,7 +70,7 @@ export const bulkRejectPartnerApplicationsAction = authActionClientwaitUntil((async () => {- const otherProgramEnrollments = reportFraud+ const affectedProgramEnrollments = reportFraud? await prisma.programEnrollment.findMany({where: {partnerId: {@@ -111,10 +111,11 @@ export const bulkRejectPartnerApplicationsAction = authActionClient// Create fraud report events in other programs where these partners are enrolled// to help keep the network safe by alerting other programs about suspected fraudcreateFraudEvents(- otherProgramEnrollments.map(({ programId, partnerId }) => ({- programId,- partnerId,+ affectedProgramEnrollments.map((affectedEnrollment) => ({+ programId: affectedEnrollment.programId,+ partnerId: affectedEnrollment.partnerId,type: FraudRuleType.partnerFraudReport,+ sourceProgramId: programId, // The program that reported the fraud,})),),]);diff --git a/apps/web/lib/actions/partners/reject-partner-application.ts b/apps/web/lib/actions/partners/reject-partner-application.tsindex 8b3c49065e..9c6dbd521a 100644--- a/apps/web/lib/actions/partners/reject-partner-application.ts+++ b/apps/web/lib/actions/partners/reject-partner-application.ts@@ -9,11 +9,7 @@ import {rejectPartnerSchema,} from "@/lib/zod/schemas/partners";import { prisma } from "@dub/prisma";-import {- FraudRuleType,- ProgramEnrollment,- ProgramEnrollmentStatus,-} from "@dub/prisma/client";+import { FraudRuleType, ProgramEnrollmentStatus } from "@dub/prisma/client";import { waitUntil } from "@vercel/functions";import { authActionClient } from "../safe-action";@@ -54,25 +50,23 @@ export const rejectPartnerApplicationAction = authActionClientwaitUntil((async () => {- let otherProgramEnrollments: Pick<ProgramEnrollment, "programId">[] =- [];-- if (reportFraud) {- otherProgramEnrollments = await prisma.programEnrollment.findMany({- where: {- partnerId,- programId: {- not: programId,+ const affectedProgramEnrollments = reportFraud+ ? await prisma.programEnrollment.findMany({+ where: {+ partnerId,+ programId: {+ not: programId,+ },+ status: {+ notIn: INACTIVE_ENROLLMENT_STATUSES,+ },},- status: {- notIn: INACTIVE_ENROLLMENT_STATUSES,+ select: {+ programId: true,+ partnerId: true,},- },- select: {- programId: true,- },- });- }+ })+ : [];await Promise.allSettled([recordAuditLog({@@ -104,10 +98,11 @@ export const rejectPartnerApplicationAction = authActionClient// Create fraud report events in other programs where this partner is enrolled// to help keep the network safe by alerting other programs about suspected fraudcreateFraudEvents(- otherProgramEnrollments.map(({ programId }) => ({- programId,- partnerId,+ affectedProgramEnrollments.map((affectedEnrollment) => ({+ programId: affectedEnrollment.programId,+ partnerId: affectedEnrollment.partnerId,type: FraudRuleType.partnerFraudReport,+ sourceProgramId: programId, // The program that reported the fraud,})),),]);diff --git a/apps/web/lib/actions/partners/unban-partner.ts b/apps/web/lib/actions/partners/unban-partner.tsindex 2021bafdd1..f08da48300 100644--- a/apps/web/lib/actions/partners/unban-partner.ts+++ b/apps/web/lib/actions/partners/unban-partner.ts@@ -9,6 +9,7 @@ import { getDefaultProgramIdOrThrow } from "@/lib/api/programs/get-default-progrimport { recordLink } from "@/lib/tinybird";import { banPartnerSchema } from "@/lib/zod/schemas/partners";import { prisma } from "@dub/prisma";+import { FraudRuleType } from "@dub/prisma/client";import { waitUntil } from "@vercel/functions";import { authActionClient } from "../safe-action";@@ -138,6 +139,31 @@ export const unbanPartnerAction = authActionClient}),]);+ await prisma.$transaction([+ // Since we're unbanning the partner, we need to+ // clean up any pending cross-program ban alerts that originated from this program.+ prisma.fraudEvent.deleteMany({+ where: {+ partnerId,+ sourceProgramId: programId,+ fraudEventGroup: {+ type: FraudRuleType.partnerCrossProgramBan,+ },+ },+ }),++ // Delete the fraud group if it has no more fraud events+ prisma.fraudEventGroup.deleteMany({+ where: {+ partnerId,+ type: FraudRuleType.partnerCrossProgramBan,+ fraudEvents: {+ none: {},+ },+ },+ }),+ ]);+// TODO// Send email to partner about being unbanned})(),diff --git a/apps/web/lib/api/fraud/create-fraud-events.ts b/apps/web/lib/api/fraud/create-fraud-events.tsindex 9e4792a140..6b4c5bfaa0 100644--- a/apps/web/lib/api/fraud/create-fraud-events.ts+++ b/apps/web/lib/api/fraud/create-fraud-events.ts@@ -123,6 +123,7 @@ export async function createFraudEvents(fraudEvents: CreateFraudEventInput[]) {linkId: e.linkId,customerId: e.customerId,eventId: e.eventId,+ sourceProgramId: e.sourceProgramId,hash: e.hash,metadata: e.metadata ? sanitizeFraudEventMetadata(e.metadata) : undefined,}),diff --git a/apps/web/lib/api/fraud/detect-record-fraud-application.ts b/apps/web/lib/api/fraud/detect-record-fraud-application.tsindex 8b1870f098..43f747f43f 100644--- a/apps/web/lib/api/fraud/detect-record-fraud-application.ts+++ b/apps/web/lib/api/fraud/detect-record-fraud-application.ts@@ -12,7 +12,7 @@ interface FraudApplicationContext {// Detect and record fraud events for the partner when they apply to a program// Checks for cross-program bans and duplicate payout methodsexport async function detectAndRecordFraudApplication({- context,+ context: { program, partner },}: {context: FraudApplicationContext;}) {@@ -22,12 +22,11 @@ export async function detectAndRecordFraudApplication({return;}- const { partner, program } = context;const fraudEvents: CreateFraudEventInput[] = [];// Check if partner has been banned in other programs// indicates cross-program fraud risk- const bannedProgramEnrollments = await prisma.programEnrollment.count({+ const bannedProgramEnrollments = await prisma.programEnrollment.findMany({where: {partnerId: partner.id,programId: {@@ -35,15 +34,27 @@ export async function detectAndRecordFraudApplication({},status: "banned",},+ select: {+ programId: true,+ bannedReason: true,+ bannedAt: true,+ },});- if (bannedProgramEnrollments > 0) {- fraudEvents.push({- programId: program.id,- partnerId: partner.id,- type: FraudRuleType.partnerCrossProgramBan,- metadata: null,- });+ // Create a fraud event for each program that banned the partner+ if (bannedProgramEnrollments.length > 0) {+ for (const bannedEnrollment of bannedProgramEnrollments) {+ fraudEvents.push({+ programId: program.id,+ partnerId: partner.id,+ type: FraudRuleType.partnerCrossProgramBan,+ sourceProgramId: bannedEnrollment.programId,+ metadata: {+ bannedReason: bannedEnrollment.bannedReason,+ bannedAt: bannedEnrollment.bannedAt,+ },+ });+ }}// Check if partner shares the same payout method hash with other partnersdiff --git a/apps/web/lib/api/fraud/detect-record-fraud-event.ts b/apps/web/lib/api/fraud/detect-record-fraud-event.tsindex 2292018db3..f363fe5291 100644--- a/apps/web/lib/api/fraud/detect-record-fraud-event.ts+++ b/apps/web/lib/api/fraud/detect-record-fraud-event.ts@@ -1,7 +1,6 @@import { CreateFraudEventInput, FraudEventContext } from "@/lib/types";import { INACTIVE_ENROLLMENT_STATUSES } from "@/lib/zod/schemas/partners";import { prisma } from "@dub/prisma";-import { Prisma } from "@dub/prisma/client";import { prettyPrint } from "@dub/utils";import { fraudEventContext } from "../../zod/schemas/schemas";import { createFraudEvents } from "./create-fraud-events";@@ -54,7 +53,7 @@ export async function detectAndRecordFraudEvent(context: FraudEventContext) {if (triggered) {triggeredRules.push({type: rule.type,- metadata: metadata as unknown as Prisma.JsonValue,+ metadata,});}} catch (error) {diff --git a/apps/web/lib/api/fraud/utils.ts b/apps/web/lib/api/fraud/utils.tsindex d379a7dc61..6e31bf1f6a 100644--- a/apps/web/lib/api/fraud/utils.ts+++ b/apps/web/lib/api/fraud/utils.ts@@ -1,24 +1,20 @@import { CreateFraudEventInput } from "@/lib/types";-import { FraudEventGroup, FraudRuleType, Prisma } from "@dub/prisma/client";import { createHash } from "crypto";-interface CreateGroupKeyInput {- type: FraudRuleType;- programId: string;- groupingKey: string;-}--interface CreateEventHashInput- extends Pick<- CreateFraudEventInput,- "type" | "programId" | "partnerId" | "customerId" | "metadata"- > {}--interface GetIdentityFieldsForFraudEventInput- extends Pick<FraudEventGroup, "partnerId" | "type"> {- customerId?: string | null | undefined;- metadata?: Prisma.JsonValue | undefined;-}+type CreateEventHashInput = Pick<+ CreateFraudEventInput,+ | "type"+ | "programId"+ | "partnerId"+ | "customerId"+ | "sourceProgramId"+ | "metadata"+>;++type GetIdentityFieldsForFraudEventInput = Pick<+ CreateFraudEventInput,+ "type" | "partnerId" | "customerId" | "sourceProgramId" | "metadata"+>;// Normalize email for comparisonexport function normalizeEmail(email: string): string {@@ -76,6 +72,7 @@ function getIdentityFieldsForFraudEvent({type,customerId,metadata,+ sourceProgramId,}: GetIdentityFieldsForFraudEventInput): Record<string, string> {const eventMetadata = metadata as Record<string, string>;@@ -98,6 +95,14 @@ function getIdentityFieldsForFraudEvent({};case "partnerCrossProgramBan":+ if (!sourceProgramId) {+ throw new Error(`sourceProgramId is required for ${type} fraud rule.`);+ }++ return {+ sourceProgramId,+ };+case "partnerFraudReport":return {};}@@ -105,7 +110,7 @@ function getIdentityFieldsForFraudEvent({// Sanitize metadata by removing fields that are stored separately or shouldn't be persistedexport function sanitizeFraudEventMetadata(- metadata: Prisma.JsonValue | undefined,+ metadata: Record<string, unknown> | undefined,) {if (!metadata) {return undefined;diff --git a/apps/web/lib/types.ts b/apps/web/lib/types.tsindex 2c277898aa..a7ec1bff64 100644--- a/apps/web/lib/types.ts+++ b/apps/web/lib/types.ts@@ -740,4 +740,8 @@ export type CreateFraudEventInput = Pick<FraudEventGroup,"programId" | "partnerId" | "type"> &- Partial<Pick<FraudEvent, "linkId" | "eventId" | "customerId" | "metadata">>;+ Partial<+ Pick<FraudEvent, "linkId" | "eventId" | "customerId" | "sourceProgramId">+ > & {+ metadata?: Record<string, unknown> | null;+ };diff --git a/apps/web/lib/zod/schemas/fraud.ts b/apps/web/lib/zod/schemas/fraud.tsindex 93673de0d9..8d9474dfc4 100644--- a/apps/web/lib/zod/schemas/fraud.ts+++ b/apps/web/lib/zod/schemas/fraud.ts@@ -4,7 +4,6 @@ import { z } from "zod";import { CustomerSchema } from "./customers";import { getPaginationQuerySchema } from "./misc";import { EnrolledPartnerSchema, PartnerSchema } from "./partners";-import { ProgramEnrollmentSchema } from "./programs";import { UserSchema } from "./users";export const MAX_RESOLUTION_REASON_LENGTH = 200;@@ -252,9 +251,11 @@ export const fraudEventSchemas = {}),}),- partnerCrossProgramBan: ProgramEnrollmentSchema.pick({- bannedAt: true,- bannedReason: true,+ partnerCrossProgramBan: z.object({+ metadata: z.object({+ bannedAt: z.string(),+ bannedReason: z.string(),+ }),}),partnerDuplicatePayoutMethod: z.object({diff --git a/apps/web/scripts/migrations/backfill-cross-program-ban-fraud-events.ts b/apps/web/scripts/migrations/backfill-cross-program-ban-fraud-events.tsnew file mode 100644index 0000000000..67a7695e43--- /dev/null+++ b/apps/web/scripts/migrations/backfill-cross-program-ban-fraud-events.ts@@ -0,0 +1,136 @@+import { createId } from "@/lib/api/create-id";+import { createFraudEventHash } from "@/lib/api/fraud/utils";+import { prisma } from "@dub/prisma";+import { FraudRuleType, Prisma } from "@dub/prisma/client";+import { chunk, groupBy } from "@dub/utils";+import "dotenv-flow/config";++async function main() {+ const fraudGroups = await prisma.fraudEventGroup.findMany({+ where: {+ type: "partnerCrossProgramBan",+ fraudEvents: {+ some: {+ sourceProgramId: null,+ },+ },+ },+ select: {+ id: true,+ programId: true,+ partnerId: true,+ createdAt: true,+ },+ orderBy: {+ createdAt: "asc",+ },+ });++ if (fraudGroups.length === 0) {+ console.log("No fraud events to process.");+ return;+ }++ console.log(`Found ${fraudGroups.length} fraud groups to process.`);++ const bannedEnrollments = await prisma.programEnrollment.findMany({+ where: {+ partnerId: {+ in: fraudGroups.map((e) => e.partnerId),+ },+ status: "banned",+ },+ select: {+ programId: true,+ partnerId: true,+ bannedAt: true,+ bannedReason: true,+ },+ orderBy: {+ bannedAt: "asc",+ },+ });++ const bannedEnrollmentsByPartnerId = groupBy(+ bannedEnrollments,+ (e) => e.partnerId,+ );++ const fraudEventsToCreate: Prisma.FraudEventCreateManyInput[] = [];++ for (const fraudGroup of fraudGroups) {+ const bannedEnrollments =+ bannedEnrollmentsByPartnerId[fraudGroup.partnerId];++ if (!bannedEnrollments || bannedEnrollments.length === 0) {+ continue;+ }++ for (const bannedEnrollment of bannedEnrollments) {+ if (bannedEnrollment.programId === fraudGroup.programId) {+ continue;+ }++ const fraudEvent = {+ programId: fraudGroup.programId,+ partnerId: fraudGroup.partnerId,+ sourceProgramId: bannedEnrollment.programId,+ metadata: {+ bannedAt: bannedEnrollment.bannedAt,+ bannedReason: bannedEnrollment.bannedReason,+ },+ };++ fraudEventsToCreate.push({+ ...fraudEvent,+ id: createId({ prefix: "fre_" }),+ fraudEventGroupId: fraudGroup.id,+ hash: createFraudEventHash({+ ...fraudEvent,+ type: FraudRuleType.partnerCrossProgramBan,+ }),+ createdAt: bannedEnrollment.bannedAt ?? new Date(),+ updatedAt: bannedEnrollment.bannedAt ?? new Date(),+ });+ }+ }++ if (fraudEventsToCreate.length > 0) {+ const chunks = chunk(fraudEventsToCreate, 500);++ for (const chunk of chunks) {+ await prisma.fraudEvent.createMany({+ data: chunk,+ });+ }++ console.log(`Created ${fraudEventsToCreate.length} fraud events total.`);+ }++ // Delete old fraud events without sourceProgramId+ // These are the old fraud events that we're replacing with new ones that have sourceProgramId+ const deletedFraudEvent = await prisma.fraudEvent.deleteMany({+ where: {+ fraudEventGroup: {+ type: "partnerCrossProgramBan",+ },+ sourceProgramId: null,+ },+ });++ console.log(`Deleted ${deletedFraudEvent.count} old fraud events.`);++ // Delete fraud event groups that have no fraud events+ const deletedFraudEventGroups = await prisma.fraudEventGroup.deleteMany({+ where: {+ type: "partnerCrossProgramBan",+ fraudEvents: {+ none: {},+ },+ },+ });++ console.log(`Deleted ${deletedFraudEventGroups.count} fraud event groups.`);+}++main();diff --git a/apps/web/ui/partners/fraud-risks/fraud-events-tables/fraud-cross-program-ban-table.tsx b/apps/web/ui/partners/fraud-risks/fraud-events-tables/fraud-cross-program-ban-table.tsxindex 57e011e46b..f4314dfe87 100644--- a/apps/web/ui/partners/fraud-risks/fraud-events-tables/fraud-cross-program-ban-table.tsx+++ b/apps/web/ui/partners/fraud-risks/fraud-events-tables/fraud-cross-program-ban-table.tsx@@ -22,14 +22,14 @@ export function FraudCrossProgramBanTable() {header: "Date",minSize: 140,size: 160,- cell: ({ row }) => (+ cell: ({ row: { original } }) => (<TimestampTooltip- timestamp={row.original.bannedAt}+ timestamp={original.metadata.bannedAt}side="right"rows={["local", "utc", "unix"]}delayDuration={150}>- <p>{formatDateTimeSmart(row.original.bannedAt || "")}</p>+ <p>{formatDateTimeSmart(original.metadata.bannedAt || "")}</p></TimestampTooltip>),},@@ -38,10 +38,10 @@ export function FraudCrossProgramBanTable() {header: "Ban reason",minSize: 180,size: 220,- cell: ({ row }) => {- return row.original.bannedReason ? (+ cell: ({ row: { original } }) => {+ return original.metadata.bannedReason ? (<span className="text-sm text-neutral-600">- {BAN_PARTNER_REASONS[row.original.bannedReason]}+ {BAN_PARTNER_REASONS[original.metadata.bannedReason]}</span>) : ("-"diff --git a/packages/prisma/schema/fraud.prisma b/packages/prisma/schema/fraud.prismaindex 89c768c38f..da4e7c8d9e 100644--- a/packages/prisma/schema/fraud.prisma+++ b/packages/prisma/schema/fraud.prisma@@ -60,6 +60,7 @@ model FraudEvent {linkId String?customerId String?eventId String?+ sourceProgramId String? // The program that originated the ban/fraud reporthash Stringmetadata Json? @db.JsoncreatedAt DateTime @default(now())@@ -69,6 +70,7 @@ model FraudEvent {partner Partner @relation(fields: [partnerId], references: [id], onDelete: Cascade)customer Customer? @relation(fields: [customerId], references: [id])link Link? @relation(fields: [linkId], references: [id])+ sourceProgram Program? @relation("SourceFraudEvents", fields: [sourceProgramId], references: [id])@@index([programId, partnerId, customerId])@@index(partnerId)@@ -76,4 +78,5 @@ model FraudEvent {@@index(linkId)@@index(eventId)@@index(hash)+ @@index(sourceProgramId)}diff --git a/packages/prisma/schema/program.prisma b/packages/prisma/schema/program.prismaindex af20e95698..5d9c8205f9 100644--- a/packages/prisma/schema/program.prisma+++ b/packages/prisma/schema/program.prisma@@ -83,6 +83,7 @@ model Program {categories ProgramCategory[]fraudRules FraudRule[]fraudEventGroups FraudEventGroup[]+ sourceFraudEvents FraudEvent[] @relation("SourceFraudEvents")@@index(workspaceId)@@index(addedToMarketplaceAt)diff --git a/packages/utils/src/functions/group-by.ts b/packages/utils/src/functions/group-by.tsnew file mode 100644index 0000000000..040a44b24d--- /dev/null+++ b/packages/utils/src/functions/group-by.ts@@ -0,0 +1,13 @@+export function groupBy<T>(+ items: readonly T[],+ keyFn: (item: T) => string,+): Record<string, T[]> {+ const result: Record<string, T[]> = {};++ for (const item of items) {+ const key = keyFn(item);+ (result[key] ??= []).push(item);+ }++ return result;+}diff --git a/packages/utils/src/functions/index.ts b/packages/utils/src/functions/index.tsindex d813005259..73deb553e9 100644--- a/packages/utils/src/functions/index.ts+++ b/packages/utils/src/functions/index.ts@@ -14,6 +14,7 @@ export * from "./fetch-with-retry";export * from "./fetch-with-timeout";export * from "./fetcher";export * from "./format-file-size";+export * from "./group-by";export * from "./hash-string";export * from "./is-click-on-interactive-child";export * from "./is-iframeable";