Skip to content

armgit / dub

Public Imported from GitHub
0

The modern link attribution platform. Loved by world-class engineering teams at Twilio, Zillow, Jobber, Vercel, Raycast, and more.

follow up CR feedback

Steven Tey129e52df132c
diff --git a/apps/web/ui/analytics/events/events-table.tsx b/apps/web/ui/analytics/events/events-table.tsx
index 42ac84164b..32ffa96fb4 100644
--- a/apps/web/ui/analytics/events/events-table.tsx
+++ b/apps/web/ui/analytics/events/events-table.tsx
@@ -148,6 +148,8 @@ export default function EventsTable({
}) {
const { slug } = useWorkspace();
const { searchParams, queryParams } = useRouterStuff();
+ const { product } = useCurrentProduct();
+
const { setExportQueryString } = useContext(EventsContext);
const {
selectedTab: tab,
@@ -695,7 +697,7 @@ export default function EventsTable({
minSize: col.minSize || 100,
maxSize: col.maxSize || 1000,
})),
- [tab, partnerPage],
+ [tab, product, partnerPage],
);
const { pagination, setPagination } = usePagination();
@@ -729,8 +731,6 @@ export default function EventsTable({
[setExportQueryString, queryString, columnVisibility, tab],
);
- const { product } = useCurrentProduct();
-
const { data, isLoading, error } = useSWR<EventDatum[]>(
!requiresUpgrade &&
product &&
diff --git a/apps/web/ui/customers/customer-details-column.tsx b/apps/web/ui/customers/customer-details-column.tsx
index 641ebe0bb3..5d6a2134f4 100644
--- a/apps/web/ui/customers/customer-details-column.tsx
+++ b/apps/web/ui/customers/customer-details-column.tsx
@@ -285,11 +285,7 @@ export function CustomerDetailsColumn({
<Fragment key={key}>
<span className="truncate">{label}</span>
<ConditionalLink
- href={
- workspaceSlug
- ? `/${workspaceSlug}/${product}/analytics?${key}=${encodeURIComponent(value)}`
- : undefined
- }
+ href={`/${workspaceSlug ? `${workspaceSlug}/${product}` : `programs/${programSlug}`}/analytics?${key}=${encodeURIComponent(value)}`}
target="_blank"
className="truncate text-neutral-500"
>