Skip to content

armgit / dub

Public Imported from GitHub
0

The modern link attribution platform. Loved by world-class engineering teams at Twilio, Zillow, Jobber, Vercel, Raycast, and more.

Add `baseFraudEventSchema`, improve `HISTORICAL_DOMAIN_MATCH` internal link (#3603)

Steven Tey193b5632945b
diff --git a/apps/web/lib/zod/schemas/fraud.ts b/apps/web/lib/zod/schemas/fraud.ts
index b51e00225b..532cbb04bc 100644
--- a/apps/web/lib/zod/schemas/fraud.ts
+++ b/apps/web/lib/zod/schemas/fraud.ts
@@ -250,9 +250,18 @@ export const updateFraudRuleSettingsSchema = z.object({
partnerFraudReport: toggleOnlyFraudRuleSchema,
});
+const baseFraudEventSchema = z.object({
+ createdAt: z.date(),
+ partner: PartnerSchema.pick({
+ id: true,
+ name: true,
+ email: true,
+ image: true,
+ }),
+});
+
export const fraudEventSchemas = {
- referralSourceBanned: z.object({
- createdAt: z.date(),
+ referralSourceBanned: baseFraudEventSchema.extend({
customer: CustomerSchema.pick({
id: true,
name: true,
@@ -266,8 +275,7 @@ export const fraudEventSchemas = {
.nullable(),
}),
- paidTrafficDetected: z.object({
- createdAt: z.date(),
+ paidTrafficDetected: baseFraudEventSchema.extend({
customer: CustomerSchema.pick({
id: true,
name: true,
@@ -282,8 +290,7 @@ export const fraudEventSchemas = {
.nullable(),
}),
- customerEmailMatch: z.object({
- createdAt: z.date(),
+ customerEmailMatch: baseFraudEventSchema.extend({
customer: CustomerSchema.pick({
id: true,
name: true,
@@ -298,8 +305,7 @@ export const fraudEventSchemas = {
.optional(),
}),
- customerEmailSuspiciousDomain: z.object({
- createdAt: z.date(),
+ customerEmailSuspiciousDomain: baseFraudEventSchema.extend({
customer: CustomerSchema.pick({
id: true,
name: true,
@@ -308,30 +314,14 @@ export const fraudEventSchemas = {
}),
}),
- partnerCrossProgramBan: z.object({
+ partnerCrossProgramBan: baseFraudEventSchema.extend({
metadata: z.object({
bannedAt: z.string(),
bannedReason: z.string(),
}),
}),
- partnerDuplicatePayoutMethod: z.object({
- createdAt: z.date(),
- partner: PartnerSchema.pick({
- id: true,
- name: true,
- email: true,
- image: true,
- }),
- }),
+ partnerDuplicatePayoutMethod: baseFraudEventSchema,
- partnerFraudReport: z.object({
- createdAt: z.date(),
- partner: PartnerSchema.pick({
- id: true,
- name: true,
- email: true,
- image: true,
- }),
- }),
+ partnerFraudReport: baseFraudEventSchema,
};
diff --git a/apps/web/tests/fraud/index.test.ts b/apps/web/tests/fraud/index.test.ts
index 831c7f9a3e..21bf74b52a 100644
--- a/apps/web/tests/fraud/index.test.ts
+++ b/apps/web/tests/fraud/index.test.ts
@@ -4,7 +4,7 @@ import {
CustomerEmailMatchType,
fraudEventSchemas,
} from "@/lib/zod/schemas/fraud";
-import { FraudRuleType } from "@dub/prisma/client";
+import { FraudRuleType, Partner } from "@dub/prisma/client";
import { randomCustomer, retry } from "tests/utils/helpers";
import { HttpClient } from "tests/utils/http";
import {
@@ -57,6 +57,7 @@ describe.concurrent("/fraud/**", async () => {
await verifyFraudEvent({
http,
+ partner: E2E_FRAUD_PARTNER,
customer,
ruleType: "customerEmailMatch",
metadata: {
@@ -94,6 +95,7 @@ describe.concurrent("/fraud/**", async () => {
await verifyFraudEvent({
http,
+ partner: E2E_FRAUD_PARTNER,
customer,
ruleType: "customerEmailMatch",
metadata: {
@@ -129,6 +131,7 @@ describe.concurrent("/fraud/**", async () => {
await verifyFraudEvent({
http,
+ partner: E2E_FRAUD_PARTNER,
customer,
ruleType: "customerEmailMatch",
metadata: {
@@ -171,6 +174,7 @@ describe.concurrent("/fraud/**", async () => {
await verifyFraudEvent({
http,
+ partner: E2E_FRAUD_PARTNER,
customer,
ruleType: "customerEmailSuspiciousDomain",
});
@@ -212,6 +216,7 @@ describe.concurrent("/fraud/**", async () => {
await verifyFraudEvent({
http,
customer,
+ partner: E2E_FRAUD_PARTNER,
ruleType: "referralSourceBanned",
metadata: {
source: E2E_FRAUD_REFERRAL_SOURCE_BANNED_DOMAIN,
@@ -254,6 +259,7 @@ describe.concurrent("/fraud/**", async () => {
await verifyFraudEvent({
http,
+ partner: E2E_FRAUD_PARTNER,
customer,
ruleType: "paidTrafficDetected",
metadata: {
@@ -266,11 +272,13 @@ describe.concurrent("/fraud/**", async () => {
const verifyFraudEvent = async ({
http,
+ partner,
customer,
ruleType,
metadata,
}: {
http: HttpClient;
+ partner: Pick<Partner, "id" | "name" | "email" | "image">;
customer: Pick<Customer, "externalId">;
ruleType: FraudRuleType;
metadata?: Record<string, unknown>;
@@ -292,8 +300,14 @@ const verifyFraudEvent = async ({
// Assert fraud event shape
expect(fraudEvent).toStrictEqual({
- ...(metadata && { metadata }),
createdAt: expect.any(String),
+ partner: expect.objectContaining({
+ id: partner.id,
+ name: partner.name,
+ email: partner.email,
+ image: partner.image,
+ }),
+ ...(metadata && { metadata }),
customer: expect.objectContaining({
id: customers[0].id,
name: customers[0].name,
diff --git a/apps/web/tests/utils/resource.ts b/apps/web/tests/utils/resource.ts
index 72c670dbad..11c2068577 100644
--- a/apps/web/tests/utils/resource.ts
+++ b/apps/web/tests/utils/resource.ts
@@ -234,7 +234,9 @@ export const E2E_PARTNERS = [
export const E2E_FRAUD_PARTNER = {
id: "pn_1K8ND11BZ4XPEX39QX3YMBGY0",
+ image: null,
links: {
customerEmailMatch: {
domain: "getacme.link",
diff --git a/apps/web/ui/partners/fraud-risks/fraud-events-tables/fraud-matching-customer-email-table.tsx b/apps/web/ui/partners/fraud-risks/fraud-events-tables/fraud-matching-customer-email-table.tsx
index b001ae5078..7f29fa3716 100644
--- a/apps/web/ui/partners/fraud-risks/fraud-events-tables/fraud-matching-customer-email-table.tsx
+++ b/apps/web/ui/partners/fraud-risks/fraud-events-tables/fraud-matching-customer-email-table.tsx
@@ -1,5 +1,6 @@
"use client";
+import { extractEmailDomain } from "@/lib/email/extract-email-domain";
import { useFraudEventsPaginated } from "@/lib/swr/use-fraud-events-paginated";
import useWorkspace from "@/lib/swr/use-workspace";
import {
@@ -106,7 +107,13 @@ export function FraudMatchingCustomerEmailTable() {
return (
<Link
- href={`/${workspaceSlug}/program/customers/${row.original.customer.id}`}
+ href={
+ row.original.customer.email &&
+ row.original.metadata?.matchType ===
+ CustomerEmailMatchType.HISTORICAL_DOMAIN_MATCH
+ ? `/${workspaceSlug}/program/customers?partnerId=${row.original.partner.id}&search=${extractEmailDomain(row.original.customer.email)}`
+ : `/${workspaceSlug}/events?event=leads&interval=all&customerId=${row.original.customer.id}`
+ }
target="_blank"
>
<Button