Skip to content

armgit / dub

Public Imported from GitHub
0

The modern link attribution platform. Loved by world-class engineering teams at Twilio, Zillow, Jobber, Vercel, Raycast, and more.

Move every pending source fraud group onto the target before release

Kiran K1bd5b1aa4219
diff --git a/apps/web/app/(ee)/api/workflows/merge-partner-accounts/route.ts b/apps/web/app/(ee)/api/workflows/merge-partner-accounts/route.ts
index d3e3635587..00618bf64c 100644
--- a/apps/web/app/(ee)/api/workflows/merge-partner-accounts/route.ts
+++ b/apps/web/app/(ee)/api/workflows/merge-partner-accounts/route.ts
@@ -980,15 +980,18 @@ async function cleanupFraudEvents({
(e) => e.fraudEventGroup._count.fraudEvents === 2,
);
- // Move the source's pending groups onto the target, which now holds the commissions.
+ // Move every pending source group onto the target, which now holds the
+ // commissions. Customer-level groups and cross-program bans stay pending so
+ // the release check can still see them. Only cleared duplicate-account
+ // groups are resolved below.
const sourceFraudGroups = await prisma.fraudEventGroup.findMany({
where: {
partnerId: sourcePartnerId,
- type: FraudRuleType.partnerDuplicateAccount,
status: FraudEventStatus.pending,
},
select: {
id: true,
+ type: true,
_count: {
select: {
fraudEvents: true,
@@ -998,10 +1001,12 @@ async function cleanupFraudEvents({
});
if (sourceFraudGroups.length > 0) {
+ const sourceFraudGroupIds = pluck(sourceFraudGroups, "id");
+
await prisma.fraudEventGroup.updateMany({
where: {
id: {
- in: pluck(sourceFraudGroups, "id"),
+ in: sourceFraudGroupIds,
},
status: FraudEventStatus.pending,
},
@@ -1009,6 +1014,18 @@ async function cleanupFraudEvents({
partnerId: targetPartnerId,
},
});
+
+ await prisma.fraudEvent.updateMany({
+ where: {
+ fraudEventGroupId: {
+ in: sourceFraudGroupIds,
+ },
+ partnerId: sourcePartnerId,
+ },
+ data: {
+ partnerId: targetPartnerId,
+ },
+ });
}
// Bucket group ids by the partner whose held commissions should be released.
@@ -1016,7 +1033,11 @@ async function cleanupFraudEvents({
// A source group with another partner still listed stays pending.
const sourceGroupIdsToResolve = pluck(
- sourceFraudGroups.filter((group) => group._count.fraudEvents <= 1),
+ sourceFraudGroups.filter(
+ (group) =>
+ group.type === FraudRuleType.partnerDuplicateAccount &&
+ group._count.fraudEvents <= 1,
+ ),
"id",
);