Skip to content

armgit / dub

Public Imported from GitHub
0

The modern link attribution platform. Loved by world-class engineering teams at Twilio, Zillow, Jobber, Vercel, Raycast, and more.

Add group setting to hide sale amounts from partners.

Kiran K1c3617716d45
diff --git a/apps/web/app/(ee)/api/cron/export/customers/partner/route.ts b/apps/web/app/(ee)/api/cron/export/customers/partner/route.ts
index 4b357bb3bf..bdd9818ce0 100644
--- a/apps/web/app/(ee)/api/cron/export/customers/partner/route.ts
+++ b/apps/web/app/(ee)/api/cron/export/customers/partner/route.ts
@@ -6,6 +6,7 @@ import { generateRandomString } from "@/lib/api/utils/generate-random-string";
import { CUSTOMER_LTV_EXCLUDED_PROGRAM_IDS } from "@/lib/constants/partner-profile";
import { withCron } from "@/lib/cron/with-cron";
import { formatPartnerCustomersForExport } from "@/lib/customers/api/format-partner-customers-export";
+import { isPartnerRevenueHidden } from "@/lib/partners/is-partner-revenue-hidden";
import { prisma, sanitizeFullTextSearch } from "@/lib/prisma";
import { partnerCustomersExportCronInputSchema } from "@/lib/zod/schemas/partner-profile";
import { sendEmail } from "@dub/email";
@@ -53,16 +54,29 @@ export const POST = withCron(async ({ rawBody }) => {
return logAndRespond(`User ${userId} has no email.`);
}
- const { program, customerDataSharingEnabledAt } =
+ const { program, customerDataSharingEnabledAt, partnerGroup } =
await getProgramEnrollmentOrThrow({
partnerId,
programId,
include: {
- program: true,
+ program: {
+ select: {
+ id: true,
+ name: true,
+ workspaceId: true,
+ },
+ },
+ partnerGroup: {
+ select: {
+ hideRevenueFromPartnersAt: true,
+ },
+ },
},
});
- const ltvExcluded = CUSTOMER_LTV_EXCLUDED_PROGRAM_IDS.includes(program.id);
+ const ltvExcluded =
+ CUSTOMER_LTV_EXCLUDED_PROGRAM_IDS.includes(program.id) ||
+ isPartnerRevenueHidden(partnerGroup);
const where = {
partnerId,
diff --git a/apps/web/app/(ee)/api/groups/[groupIdOrSlug]/route.ts b/apps/web/app/(ee)/api/groups/[groupIdOrSlug]/route.ts
index c48e1e8cc9..0c4b87d80b 100644
--- a/apps/web/app/(ee)/api/groups/[groupIdOrSlug]/route.ts
+++ b/apps/web/app/(ee)/api/groups/[groupIdOrSlug]/route.ts
@@ -62,6 +62,7 @@ export const PATCH = withWorkspace(
landerData,
holdingPeriodDays,
autoApprovePartners,
+ hideRevenueFromPartners,
updateAutoApprovePartnersForAllGroups,
updateHoldingPeriodDaysForAllGroups,
moveRules,
@@ -153,6 +154,11 @@ export const PATCH = withWorkspace(
? new Date()
: null,
}),
+ ...(hideRevenueFromPartners !== undefined && {
+ hideRevenueFromPartnersAt: hideRevenueFromPartners
+ ? new Date()
+ : null,
+ }),
},
include: {
clickReward: true,
diff --git a/apps/web/app/(ee)/api/groups/route.ts b/apps/web/app/(ee)/api/groups/route.ts
index c58dfdc5ba..7b88c46fe2 100644
--- a/apps/web/app/(ee)/api/groups/route.ts
+++ b/apps/web/app/(ee)/api/groups/route.ts
@@ -114,6 +114,7 @@ export const POST = withWorkspace(
landerData,
holdingPeriodDays,
autoApprovePartnersEnabledAt,
+ hideRevenueFromPartnersAt,
submittedLeadFormData,
submittedLeadsEnabledAt,
} = program.groups[0];
@@ -130,6 +131,7 @@ export const POST = withWorkspace(
brandColor,
holdingPeriodDays,
autoApprovePartnersEnabledAt,
+ hideRevenueFromPartnersAt,
submittedLeadsEnabledAt,
...(additionalLinks && {
additionalLinks: sanitizeAdditionalLinks(additionalLinks),
diff --git a/apps/web/app/app.dub.co/(dashboard)/[slug]/(ee)/program/groups/[groupSlug]/settings/group-additional-settings.tsx b/apps/web/app/app.dub.co/(dashboard)/[slug]/(ee)/program/groups/[groupSlug]/settings/group-additional-settings.tsx
index 50657d92c4..fce3df1dae 100644
--- a/apps/web/app/app.dub.co/(dashboard)/[slug]/(ee)/program/groups/[groupSlug]/settings/group-additional-settings.tsx
+++ b/apps/web/app/app.dub.co/(dashboard)/[slug]/(ee)/program/groups/[groupSlug]/settings/group-additional-settings.tsx
@@ -64,6 +64,23 @@ function GroupAdditionalSettingsForm({
}
}, [group]);
+ const handleHideRevenueToggle = async () => {
+ if (!group) return;
+ const currentValue = Boolean(group.hideRevenueFromPartnersAt);
+ await updateGroup(`/api/groups/${group.id}`, {
+ method: "PATCH",
+ body: {
+ hideRevenueFromPartners: !currentValue,
+ },
+ onSuccess: async () => {
+ await mutatePrefix(`/api/groups/${group.slug}`);
+ toast.success(
+ `Partners in this group will ${currentValue ? "now see" : "no longer see"} sale amounts`,
+ );
+ },
+ });
+ };
+
const handleAutoApproveConfirm = async ({
applyToAllGroups,
}: {
@@ -250,6 +267,29 @@ function GroupAdditionalSettingsForm({
)}
</GroupSettingsRow>
+ <GroupSettingsRow
+ heading="Hide revenue from partners"
+ description="Partners in this group will not see sale amounts. They will still see clicks, leads, sales, and commissions."
+ >
+ {isLoading ? (
+ <div className="h-[38px] w-full animate-pulse rounded-md bg-neutral-200" />
+ ) : (
+ <label>
+ <div className="flex select-none items-center gap-2">
+ <Switch
+ checked={Boolean(group!.hideRevenueFromPartnersAt)}
+ fn={handleHideRevenueToggle}
+ disabled={isSubmitting}
+ trackDimensions="radix-state-checked:bg-black focus-visible:ring-black/20"
+ />
+ <span className="text-content-emphasis text-sm">
+ Hide sale amounts
+ </span>
+ </div>
+ </label>
+ )}
+ </GroupSettingsRow>
+
<GroupSettingsRow
heading="Group move rules"
description="[Automatically move partners to this group](https://dub.co/help/article/partner-groups#group-move-rules) when they meet specific criteria."
diff --git a/apps/web/lib/api/groups/get-groups.ts b/apps/web/lib/api/groups/get-groups.ts
index 93388820cc..9194458601 100644
--- a/apps/web/lib/api/groups/get-groups.ts
+++ b/apps/web/lib/api/groups/get-groups.ts
@@ -42,6 +42,7 @@ export async function getGroups(filters: GroupFilters) {
pg.brandColor,
pg.holdingPeriodDays,
pg.autoApprovePartnersEnabledAt,
+ pg.hideRevenueFromPartnersAt,
pg.submittedLeadsEnabledAt,
pg.utmTemplateId,
pg.createdAt,
diff --git a/apps/web/lib/firstpromoter/import-campaigns.ts b/apps/web/lib/firstpromoter/import-campaigns.ts
index 283653d488..ead01eb8f1 100644
--- a/apps/web/lib/firstpromoter/import-campaigns.ts
+++ b/apps/web/lib/firstpromoter/import-campaigns.ts
@@ -44,6 +44,7 @@ export async function importCampaigns(payload: FirstPromoterImportPayload) {
brandColor,
holdingPeriodDays,
autoApprovePartnersEnabledAt,
+ hideRevenueFromPartnersAt,
additionalLinks,
maxPartnerLinks,
linkStructure,
@@ -93,6 +94,7 @@ export async function importCampaigns(payload: FirstPromoterImportPayload) {
brandColor,
holdingPeriodDays,
autoApprovePartnersEnabledAt,
+ hideRevenueFromPartnersAt,
submittedLeadsEnabledAt,
...(additionalLinks && {
additionalLinks: sanitizeAdditionalLinks(additionalLinks),
diff --git a/apps/web/lib/partners/is-partner-revenue-hidden.ts b/apps/web/lib/partners/is-partner-revenue-hidden.ts
new file mode 100644
index 0000000000..d58411cf69
--- /dev/null
+++ b/apps/web/lib/partners/is-partner-revenue-hidden.ts
@@ -0,0 +1,15 @@
+import { PartnerGroup } from "@prisma/client";
+
+/** Group shape used to decide whether sale dollar amounts are hidden from partners. */
+export type PartnerRevenueVisibilityGroup =
+ | Pick<PartnerGroup, "hideRevenueFromPartnersAt">
+ | { hideRevenueFromPartnersAt?: Date | string | null }
+ | null
+ | undefined;
+
+/** Whether partners in this group should not see sale dollar amounts. */
+export function isPartnerRevenueHidden(
+ group: PartnerRevenueVisibilityGroup,
+): boolean {
+ return Boolean(group?.hideRevenueFromPartnersAt);
+}
diff --git a/apps/web/lib/rewardful/import-campaigns.ts b/apps/web/lib/rewardful/import-campaigns.ts
index 47672517c6..ce6bff707b 100644
--- a/apps/web/lib/rewardful/import-campaigns.ts
+++ b/apps/web/lib/rewardful/import-campaigns.ts
@@ -52,6 +52,7 @@ export async function importCampaigns(payload: RewardfulImportPayload) {
brandColor,
holdingPeriodDays,
autoApprovePartnersEnabledAt,
+ hideRevenueFromPartnersAt,
additionalLinks,
maxPartnerLinks,
linkStructure,
@@ -106,6 +107,7 @@ export async function importCampaigns(payload: RewardfulImportPayload) {
brandColor,
holdingPeriodDays,
autoApprovePartnersEnabledAt,
+ hideRevenueFromPartnersAt,
submittedLeadsEnabledAt,
...(additionalLinks && {
additionalLinks: sanitizeAdditionalLinks(additionalLinks),
diff --git a/apps/web/lib/zod/schemas/groups.ts b/apps/web/lib/zod/schemas/groups.ts
index 7e6b21ef08..0815465f4c 100644
--- a/apps/web/lib/zod/schemas/groups.ts
+++ b/apps/web/lib/zod/schemas/groups.ts
@@ -65,6 +65,7 @@ export const GroupSchema = z.object({
brandColor: z.string().nullable(),
holdingPeriodDays: z.number(),
autoApprovePartnersEnabledAt: z.coerce.date().nullish(),
+ hideRevenueFromPartnersAt: z.coerce.date().nullish(),
submittedLeadsEnabledAt: z.coerce.date().nullish(),
clickReward: RewardSchema.nullish(),
leadReward: RewardSchema.nullish(),
@@ -154,6 +155,7 @@ export const updateGroupSchema = createGroupSchema.partial().extend({
)
.optional(),
autoApprovePartners: z.coerce.boolean().optional(),
+ hideRevenueFromPartners: z.coerce.boolean().optional(),
updateAutoApprovePartnersForAllGroups: z.coerce.boolean().optional(),
updateHoldingPeriodDaysForAllGroups: z.coerce.boolean().optional(),
moveRules: workflowConditionsSchema.optional(),
diff --git a/apps/web/lib/zod/schemas/programs.ts b/apps/web/lib/zod/schemas/programs.ts
index 7378e924c4..49f7aad01e 100644
--- a/apps/web/lib/zod/schemas/programs.ts
+++ b/apps/web/lib/zod/schemas/programs.ts
@@ -204,6 +204,7 @@ export const ProgramEnrollmentSchema = z.object({
wordmark: true,
brandColor: true,
holdingPeriodDays: true,
+ hideRevenueFromPartnersAt: true,
additionalLinks: true,
maxPartnerLinks: true,
linkStructure: true,
diff --git a/apps/web/prisma/schema/group.prisma b/apps/web/prisma/schema/group.prisma
index 67b6fca11b..4f83190059 100644
--- a/apps/web/prisma/schema/group.prisma
+++ b/apps/web/prisma/schema/group.prisma
@@ -28,6 +28,7 @@ model PartnerGroup {
brandColor String?
holdingPeriodDays Int @default(0) // number of days to wait before earnings are added to a payout
autoApprovePartnersEnabledAt DateTime?
+ hideRevenueFromPartnersAt DateTime?
submittedLeadFormData Json? @db.Json
submittedLeadsEnabledAt DateTime?
workflowId String? @unique