Skip to content

armgit / dub

Public Imported from GitHub
0

The modern link attribution platform. Loved by world-class engineering teams at Twilio, Zillow, Jobber, Vercel, Raycast, and more.

Bulk reject by partner's pending application so group applications are covered

Kiran K1f099784d3b7
diff --git a/apps/web/lib/actions/partners/bulk-reject-program-applications.ts b/apps/web/lib/actions/partners/bulk-reject-program-applications.ts
index 4446f10def..9202604bd8 100644
--- a/apps/web/lib/actions/partners/bulk-reject-program-applications.ts
+++ b/apps/web/lib/actions/partners/bulk-reject-program-applications.ts
@@ -1,6 +1,7 @@
"use server";
import { trackActivityLog } from "@/lib/api/activity-log/track-activity-log";
+import { DubApiError } from "@/lib/api/errors";
import { resolveFraudGroups } from "@/lib/api/fraud/resolve-fraud-groups";
import { queuePartnerSearchSync } from "@/lib/api/partners/queue-partner-search-sync";
import { getDefaultProgramIdOrThrow } from "@/lib/api/programs/get-default-program-id-or-throw";
@@ -17,7 +18,14 @@ import { waitUntil } from "@vercel/functions";
import { authActionClient } from "../safe-action";
import { throwIfNoPermission } from "../throw-if-no-permission";
-// Reject a list of pending partners
+// Only these enrollments are rejected along with the application. Any other
+// status (approved, banned, deactivated, ...) is left untouched.
+const ENROLLMENT_STATUSES_TO_REJECT: ProgramEnrollmentStatus[] = [
+ ProgramEnrollmentStatus.pending,
+ ProgramEnrollmentStatus.rejected,
+];
+
+// Reject the pending program application of each partner
export const bulkRejectProgramApplicationsAction = authActionClient
.inputSchema(bulkRejectProgramApplicationsSchema)
.action(async ({ parsedInput, ctx }) => {
@@ -31,170 +39,253 @@ export const bulkRejectProgramApplicationsAction = authActionClient
const programId = getDefaultProgramIdOrThrow(workspace);
- const programEnrollments = await prisma.programEnrollment.findMany({
- where: {
- programId,
- status: "pending",
- partnerId: {
- in: partnerIds,
- },
- },
- select: {
- id: true,
- applicationId: true,
- partner: true,
- },
- });
-
- if (programEnrollments.length === 0) {
- return;
- }
-
- const reviewedAt = new Date();
+ // A partner has at most one pending application per program
+ const [program, programApplications, programEnrollments] =
+ await Promise.all([
+ prisma.program.findUniqueOrThrow({
+ where: {
+ id: programId,
+ },
+ select: {
+ name: true,
+ slug: true,
+ supportEmail: true,
+ },
+ }),
- const rejectedEnrollmentIds = await prisma.$transaction(async (tx) => {
- const transitionedIds = new Set<string>();
+ prisma.programApplication.findMany({
+ where: {
+ programId,
+ partnerId: {
+ in: partnerIds,
+ },
+ status: ProgramApplicationStatus.pending,
+ },
+ select: {
+ id: true,
+ partnerId: true,
+ partner: {
+ select: {
+ name: true,
+ email: true,
+ },
+ },
+ },
+ }),
- for (const { id } of programEnrollments) {
- const { count } = await tx.programEnrollment.updateMany({
+ prisma.programEnrollment.findMany({
where: {
- id,
- status: ProgramEnrollmentStatus.pending,
+ programId,
+ partnerId: {
+ in: partnerIds,
+ },
},
- data: {
- status: ProgramEnrollmentStatus.rejected,
- clickRewardId: null,
- leadRewardId: null,
- saleRewardId: null,
- referralRewardId: null,
- customRewardId: null,
- discountId: null,
+ select: {
+ id: true,
+ partnerId: true,
+ status: true,
},
- });
+ }),
+ ]);
- if (count > 0) {
- transitionedIds.add(id);
- }
- }
+ if (programApplications.length === 0) {
+ throw new DubApiError({
+ code: "bad_request",
+ message: "No pending applications found.",
+ });
+ }
+
+ const enrollmentsByPartnerId = new Map(
+ programEnrollments.map((enrollment) => [
+ enrollment.partnerId,
+ enrollment,
+ ]),
+ );
+
+ // Every pending application is rejected. Approved partners are applying to
+ // join another group, and banned/deactivated/archived partners were already
+ // removed, so their enrollment is left untouched
+ const reviews = programApplications.map((application) => {
+ const enrollment = enrollmentsByPartnerId.get(application.partnerId!);
- const applicationIds = programEnrollments
- .filter(({ id }) => transitionedIds.has(id))
- .map(({ applicationId }) => applicationId)
- .filter((id): id is string => Boolean(id));
+ const isNewApplication =
+ !enrollment ||
+ ENROLLMENT_STATUSES_TO_REJECT.includes(enrollment.status);
- if (applicationIds.length > 0) {
+ const isApplyingToAdditionalGroup =
+ enrollment?.status === ProgramEnrollmentStatus.approved;
+
+ // Partners removed from the program are not emailed
+ const shouldEmailPartner =
+ isNewApplication || isApplyingToAdditionalGroup;
+
+ return {
+ application,
+ partnerId: application.partnerId!,
+ enrollmentToReject: isNewApplication ? enrollment : undefined,
+ isNewApplication,
+ isApplyingToAdditionalGroup,
+ shouldEmailPartner,
+ };
+ });
+
+ const enrollmentIdsToReject = reviews.flatMap(({ enrollmentToReject }) =>
+ enrollmentToReject ? [enrollmentToReject.id] : [],
+ );
+
+ const newApplicationPartnerIds = reviews
+ .filter(({ isNewApplication }) => isNewApplication)
+ .map(({ partnerId }) => partnerId);
+
+ await prisma.$transaction(async (tx) => {
+ const { count: rejectedApplicationsCount } =
await tx.programApplication.updateMany({
where: {
id: {
- in: applicationIds,
+ in: reviews.map(({ application }) => application.id),
},
+ status: ProgramApplicationStatus.pending,
},
data: {
status: ProgramApplicationStatus.rejected,
- reviewedAt,
+ reviewedAt: new Date(),
rejectionReason: null,
rejectionNote: null,
userId: user.id,
},
});
+
+ if (rejectedApplicationsCount !== reviews.length) {
+ throw new DubApiError({
+ code: "conflict",
+ message:
+ "Some of the selected applications were already reviewed. Refresh and try again.",
+ });
}
- return transitionedIds;
- });
+ if (enrollmentIdsToReject.length === 0) {
+ return;
+ }
- // Find the rejected enrollments
- const rejectedEnrollments = programEnrollments.filter(({ id }) =>
- rejectedEnrollmentIds.has(id),
- );
+ const { count: rejectedEnrollmentsCount } =
+ await tx.programEnrollment.updateMany({
+ where: {
+ id: {
+ in: enrollmentIdsToReject,
+ },
+ status: {
+ in: ENROLLMENT_STATUSES_TO_REJECT,
+ },
+ },
+ data: {
+ status: ProgramEnrollmentStatus.rejected,
+ reapplicationTimeframe: "standard",
+ clickRewardId: null,
+ leadRewardId: null,
+ saleRewardId: null,
+ referralRewardId: null,
+ customRewardId: null,
+ discountId: null,
+ },
+ });
- if (rejectedEnrollments.length === 0) {
- return;
- }
+ if (rejectedEnrollmentsCount !== enrollmentIdsToReject.length) {
+ throw new DubApiError({
+ code: "conflict",
+ message:
+ "Some of the selected partners changed status. Refresh and try again.",
+ });
+ }
+ });
waitUntil(
(async () => {
await Promise.allSettled([
// Queue an index update because the enrollment statuses moved to rejected
queuePartnerSearchSync({
- enrollmentIds: rejectedEnrollments.map(({ id }) => id),
+ enrollmentIds: enrollmentIdsToReject,
}),
trackActivityLog(
- rejectedEnrollments.map(({ partner }) => ({
+ reviews.map(({ partnerId }) => ({
workspaceId: workspace.id,
programId,
resourceType: "partner",
- resourceId: partner.id,
+ resourceId: partnerId,
userId: user.id,
action: "partner_application.rejected",
changeSet: {
status: {
- old: "pending",
- new: "rejected",
+ old: ProgramApplicationStatus.pending,
+ new: ProgramApplicationStatus.rejected,
},
},
})),
),
- resolveFraudGroups({
- where: {
- programEnrollment: {
- id: {
- in: rejectedEnrollments.map(({ id }) => id),
+ newApplicationPartnerIds.length > 0 &&
+ resolveFraudGroups({
+ where: {
+ programId,
+ partnerId: {
+ in: newApplicationPartnerIds,
},
},
- },
- userId: user.id,
- resolutionReason:
- "Resolved automatically because the partner application was rejected.",
- }),
+ userId: user.id,
+ resolutionReason:
+ "Resolved automatically because the partner application was rejected.",
+ }),
trackApplicationEvents({
event: "rejected",
programId,
- partnerIds: rejectedEnrollments.map(({ partner }) => partner.id),
+ partnerIds: newApplicationPartnerIds,
}),
]);
- const program = await prisma.program.findUniqueOrThrow({
- where: {
- id: programId,
- },
- select: {
- name: true,
- slug: true,
- supportEmail: true,
- },
- });
+ const emails = reviews.flatMap(
+ ({
+ application: { partner },
+ isApplyingToAdditionalGroup,
+ shouldEmailPartner,
+ }) =>
+ partner?.email && shouldEmailPartner
+ ? [
+ {
+ to: partner.email,
+ subject: isApplyingToAdditionalGroup
+ ? `Your application to join a new group in ${program.name} was not approved`
+ : `Your application to ${program.name} was not approved`,
+ variant: "notifications" as const,
+ replyTo: program.supportEmail || "noreply",
+ react: ProgramApplicationRejected({
+ partner: {
+ name: partner.name ?? "there",
+ email: partner.email,
+ },
+ program: {
+ name: program.name,
+ slug: program.slug,
+ supportEmail: program.supportEmail ?? undefined,
+ },
+ isApplyingToAdditionalGroup,
+ rejectionReason: undefined,
+ additionalNotes: undefined,
+ reapplicationTimeframe: "standard",
+ }),
+ },
+ ]
+ : [],
+ );
- const partnersWithEmail = rejectedEnrollments
- .filter(({ partner }) => partner.email)
- .map(({ partner }) => partner);
-
- if (partnersWithEmail.length > 0) {
- await sendBatchEmail(
- partnersWithEmail.map((partner) => ({
- to: partner.email!,
- subject: `Your application to ${program.name} was not approved`,
- variant: "notifications",
- replyTo: program.supportEmail || "noreply",
- react: ProgramApplicationRejected({
- partner: {
- name: partner.name ?? "there",
- email: partner.email!,
- },
- program: {
- name: program.name,
- slug: program.slug,
- supportEmail: program.supportEmail ?? undefined,
- },
- rejectionReason: undefined,
- additionalNotes: undefined,
- reapplicationTimeframe: "standard",
- }),
- })),
- );
+ if (emails.length > 0) {
+ await sendBatchEmail(emails);
}
})(),
);
+
+ return {
+ rejectedCount: reviews.length,
+ skippedCount: partnerIds.length - reviews.length,
+ };
});
diff --git a/apps/web/ui/modals/bulk-reject-program-applications-modal.tsx b/apps/web/ui/modals/bulk-reject-program-applications-modal.tsx
index 3e663e943f..13645aaf68 100644
--- a/apps/web/ui/modals/bulk-reject-program-applications-modal.tsx
+++ b/apps/web/ui/modals/bulk-reject-program-applications-modal.tsx
@@ -30,14 +30,17 @@ function BulkRejectProgramApplicationsModal({
const { executeAsync, isPending } = useAction(
bulkRejectProgramApplicationsAction,
{
- onSuccess: async () => {
+ onSuccess: async ({ data }) => {
setShowBulkRejectProgramApplicationsModal(false);
await mutatePrefix([
"/api/partners",
"/api/partners/count",
"/api/program-applications",
]);
- toast.success(`${pluralize("Partner", partners.length)} rejected.`);
+ const { rejectedCount, skippedCount } = data;
+ toast.success(
+ `${rejectedCount} ${pluralize("partner", rejectedCount)} rejected.${skippedCount > 0 ? ` ${skippedCount} skipped because ${pluralize("it was", skippedCount, { plural: "they were" })} already reviewed.` : ""}`,
+ );
},
onError({ error }) {
toast.error(error.serverError);