Skip to content

armgit / dub

Public Imported from GitHub
0

The modern link attribution platform. Loved by world-class engineering teams at Twilio, Zillow, Jobber, Vercel, Raycast, and more.

Fix 1

Marcus Farrell20ff07cd05ce
diff --git a/packages/ui/src/rich-text-area/link-modal.tsx b/packages/ui/src/rich-text-area/link-modal.tsx
index 94c677de29..4ece879e02 100644
--- a/packages/ui/src/rich-text-area/link-modal.tsx
+++ b/packages/ui/src/rich-text-area/link-modal.tsx
@@ -58,17 +58,25 @@ function RichTextLinkModalInner({ state }: { state: RichTextLinkModalState }) {
return;
}
- editor
+ const trimmedText = text.trim();
+ const chain = editor
.chain()
.focus()
- .insertContentAt({ from: state.from, to: state.to }, [
+ .setTextSelection({ from: state.from, to: state.to });
+
+ if (trimmedText && trimmedText === state.text.trim()) {
+ chain.setLink({ href: finalHref });
+ } else {
+ chain.insertContent([
{
type: "text",
- text: text.trim() || finalHref,
+ text: trimmedText || finalHref,
marks: [{ type: "link", attrs: { href: finalHref } }],
},
- ])
- .run();
+ ]);
+ }
+
+ chain.run();
setLinkModalState(null);
};
diff --git a/packages/ui/src/rich-text-area/rich-text-provider.tsx b/packages/ui/src/rich-text-area/rich-text-provider.tsx
index 8850db69bd..4200a6b029 100644
--- a/packages/ui/src/rich-text-area/rich-text-provider.tsx
+++ b/packages/ui/src/rich-text-area/rich-text-provider.tsx
@@ -318,6 +318,7 @@ export const RichTextProvider = forwardRef<
// Open the link edit modal when clicking a link in the editor
if (
+ view.editable &&
features.includes("links") &&
event.target instanceof Element &&
event.target.closest("a[href]")