Skip to content

armgit / dub

Public Imported from GitHub
0

The modern link attribution platform. Loved by world-class engineering teams at Twilio, Zillow, Jobber, Vercel, Raycast, and more.

Drop em dashes from the rollout comments

Rafi2190e17cccfe
diff --git a/apps/web/lib/api/partners/program-enrollment-query.ts b/apps/web/lib/api/partners/program-enrollment-query.ts
index 86b38e0a27..3df1b16547 100644
--- a/apps/web/lib/api/partners/program-enrollment-query.ts
+++ b/apps/web/lib/api/partners/program-enrollment-query.ts
@@ -17,7 +17,7 @@ export function isExactEmailQuery(query: string): boolean {
/**
* A pasted partner ID, not a prefix of one. IDs are 24 or 25 characters after
- * `pn_` — verified against all 626,348 production documents — so a shorter
+ * `pn_`, verified against all 626,348 production documents, so a shorter
* suffix is someone typing, and matching it exactly would return nothing.
*/
export function isExactPartnerIdQuery(query: string): boolean {
diff --git a/apps/web/lib/api/partners/search/find-candidates.ts b/apps/web/lib/api/partners/search/find-candidates.ts
index bae9e0fb93..0671a7619b 100644
--- a/apps/web/lib/api/partners/search/find-candidates.ts
+++ b/apps/web/lib/api/partners/search/find-candidates.ts
@@ -23,8 +23,8 @@ interface FindPartnerSearchCandidatesOptions {
* A complete email address takes the same exit, but only once the database
* confirms it: `email` is unique and indexed, so the lookup is a point read
* against a network round trip. A miss still goes to the provider, because an
- * address matching nothing exactly is usually one the caller is still typing —
- * `[email protected]` on the way to `[email protected]` — and n-grams still match it.
+ * address matching nothing exactly is usually one the caller is still typing,
+ * `[email protected]` on the way to `[email protected]`, and n-grams still match it.
*/
export async function findPartnerSearchCandidates(
searchProvider: PartnerSearchProvider,
diff --git a/apps/web/lib/api/partners/search/providers/turbopuffer.ts b/apps/web/lib/api/partners/search/providers/turbopuffer.ts
index 99a2f50623..bed4d48352 100644
--- a/apps/web/lib/api/partners/search/providers/turbopuffer.ts
+++ b/apps/web/lib/api/partners/search/providers/turbopuffer.ts
@@ -16,7 +16,7 @@ import { getEmailNgrams, getQueryNgrams } from "./shared";
/**
* Bumped whenever the document shape changes, because turbopuffer keeps the
- * schema a namespace was created with — writing a new one does not migrate an
+ * schema a namespace was created with, and writing a new one does not migrate an
* existing namespace. A new version is backfilled alongside the old one and
* swapped in, rather than rebuilt in place.
*/
@@ -30,7 +30,7 @@ const WRITE_BATCH_SIZE = 500;
* with it. Measured against 626K documents: one character takes the count from
* ~50ms to ~1.2s, past the query deadline on every attempt, and two characters
* are still 2-3x slower than three. Production holds roughly 1.6M documents, so
- * the margin matters more there than the extra character costs — the first
+ * the margin matters more there than the extra character costs, so the first
* keystrokes of a search fall back to the database count instead.
*/
const MIN_COUNT_PREFIX_LENGTH = 3;
@@ -153,7 +153,7 @@ function serializeTurbopufferRow(
emailNgrams: getEmailNgrams(document.email),
status: document.status,
// Omitted rather than stored null, which is what makes a NotIn filter match
- // the partners that have no group or no country — the same rows the
+ // the partners that have no group or no country, the same rows the
// database includes when it ORs the negation with IS NULL.
...(document.groupId ? { groupId: document.groupId } : {}),
...(document.country ? { country: document.country } : {}),
diff --git a/apps/web/lib/api/partners/search/types.ts b/apps/web/lib/api/partners/search/types.ts
index 98dd9c9f19..479a8cfd10 100644
--- a/apps/web/lib/api/partners/search/types.ts
+++ b/apps/web/lib/api/partners/search/types.ts
@@ -100,7 +100,7 @@ export interface PartnerSearchCandidateQuery {
/**
* Applied by the provider before it truncates to `limit`. The database still
* re-applies every one of them, so the index only ever narrows the candidate
- * pool — it never decides the result on its own.
+ * pool, and it never decides the result on its own.
*/
filters?: {
status?: PartnerSearchCandidateFilter;
diff --git a/apps/web/scripts/dev/seed-100k-partners.ts b/apps/web/scripts/dev/seed-100k-partners.ts
index b7a29d9f9a..df84471be4 100644
--- a/apps/web/scripts/dev/seed-100k-partners.ts
+++ b/apps/web/scripts/dev/seed-100k-partners.ts
@@ -645,7 +645,7 @@ async function main() {
})),
});
- // The program's own default group, the seeded ones, and null — so "no group"
+ // The program's own default group, the seeded ones, and null, so "no group"
// is represented too, which is what a negated filter has to include.
const groupIds: (string | null)[] = [
program.defaultGroupId,
diff --git a/apps/web/scripts/partners/delete-partner-search-index.ts b/apps/web/scripts/partners/delete-partner-search-index.ts
index e811f1f9f7..711bd02a09 100644
--- a/apps/web/scripts/partners/delete-partner-search-index.ts
+++ b/apps/web/scripts/partners/delete-partner-search-index.ts
@@ -2,7 +2,7 @@
* Empties a partner search namespace.
*
* Takes the namespace explicitly rather than reading the one the code writes to,
- * so retiring an old version after a migration is possible — and requires it
+ * so retiring an old version after a migration is possible, and requires it
* twice, because this is not recoverable without a backfill.
*
* cd apps/web